6:14 a.m.
URL: https://github.com/SSSD/sssd/pull/516
Author: fidencio
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/516/head:pr516
git checkout pr516
2:20 p.m.
New subject: [sssd PR#516][+Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: +Changes requested
1:31 a.m.
New subject: [sssd PR#516][synchronized] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Author: fidencio
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/516/head:pr516
git checkout pr516
1:32 a.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
fidencio commented:
"""
Changes done according to your suggestion.
Thanks for the review and I'm removing the "Changes Requested" label.u
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-366889568
1:32 a.m.
New subject: [sssd PR#516][-Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: -Changes requested
1:32 a.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
fidencio commented:
"""
Changes done according to your suggestion.
Thanks for the review and I'm removing the "Changes Requested" label.
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-366889568
6:51 a.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
fidencio commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-366967908
4:54 a.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
lslebodn commented:
"""
LGTM from content point of view.
@justin-stephenson could you check this PR as well?
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367288934
8:54 a.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
justin-stephenson commented:
"""
Okay from my side.
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367351699
2:15 p.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
lslebodn commented:
"""
Justin,
thank you for review
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367457190
2:16 p.m.
New subject: [sssd PR#516][+Accepted] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: +Accepted
2:21 p.m.
New subject: [sssd PR#516][-Accepted] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: -Accepted
2:24 p.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
lslebodn commented:
"""
I tried to figure out why centos CI is failing and I noticed that xml element `note` is
not allowed in DTD
```
/usr/bin/xmllint --catalogs --postvalid --nonet --noent --xinclude --noout
../../../sssd/src/man/sssd.conf.5.xml
../../../sssd/src/man/sssd.conf.5.xml:2464: element note: validity error : Element note
content does not follow the DTD, expecting (title? , (calloutlist | glosslist | bibliolist
| itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | literallayout |
programlisting | programlistingco | screen | screenco | screenshot | synopsis |
cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis |
destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote |
graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample |
informalfigure | informaltable | equation | example | figure | table | procedure | sidebar
| anchor | bridgehead | remark | indexterm | beginpage)+), got (CDATA)
Document ../../../sssd/src/man/sssd.conf.5.xml does not validate
make[2]: *** [Makefile:938: sssd.conf.5] Error 3
```
I can see that on other places in sssd.conf.5.xml we use either
```
<para>
<emphasis>NOTE:</emphasis> Sudo rules are
```
or NOTE without emphasis
```
<para>
NOTE: The filter_groups option doesn't affect
```
I'm sorry that I did not notice that earlier.
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367459699
2:25 p.m.
New subject: [sssd PR#516][+Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: +Changes requested
2:35 p.m.
New subject: [sssd PR#516][synchronized] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Author: fidencio
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/516/head:pr516
git checkout pr516
2:37 p.m.
New subject: [sssd PR#516][synchronized] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Author: fidencio
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/516/head:pr516
git checkout pr516
2:37 p.m.
New subject: [sssd PR#516][-Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: -Changes requested
6:05 a.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
jhrozek commented:
"""
I think it's OK to add the Accepted label since the centos CI is passing now.
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367660685
6:06 a.m.
New subject: [sssd PR#516][+Accepted] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: +Accepted
7:19 a.m.
New subject: [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
lslebodn commented:
"""
master:
* 5150fbdc429ee9ed52e80e5f133ddb48c5b79914
"""
See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367678121
7:19 a.m.
New subject: [sssd PR#516][closed] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Author: fidencio
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/516/head:pr516
git checkout pr516
7:19 a.m.
New subject: [sssd PR#516][+Pushed] DESKPROFILE: Document it doesn't work when run as unprivileged user
URL: https://github.com/SSSD/sssd/pull/516
Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user
Label: +Pushed
2254
days inactive
2260
days old
sssd-devel@lists.fedorahosted.org
21 comments
4 participants
participants (4)
-
fidencio -
jhrozek
-
justin-stephenson
-
lslebodn