[PATCH] config API: prepend source dir search path for tests

[Sumit Bose]

Hi,

I came across this while testing some changes to the config API.

Additionally I realized that the config API opens every file in
schemaplugindir (.../sssd.api.d) including hidden ones starting with a
'.'. This might lead to test failures if backup copies or swap file of
running editors are read. Since this is primarily an issue on developers
systems I wonder if this should be fixed or not?

bye,
Sumit

[Jakub Hrozek]

On Wed, Feb 26, 2014 at 11:45:58AM +0100, Sumit Bose wrote:
>  Additionally I realized that the config API opens every file in
>  schemaplugindir (.../sssd.api.d) including hidden ones starting with a
>  '.'. This might lead to test failures if backup copies or swap file of
>  running editors are read. Since this is primarily an issue on developers
>  systems I wonder if this should be fixed or not? 
I haven't reviwed the patch yet, but I've been bitten by this issue many
times in the past and each time it confuses the hell out of me (one time
I even spent time inserting test print statements until I realized that
the API is loading a vim swap file..)

So if there's a way to fix this issue, I'm all for a fix.

[Sumit Bose]

On Wed, Feb 26, 2014 at 11:45:58AM +0100, Sumit Bose wrote:
>  Hi,
>  
>  I came across this while testing some changes to the config API.
>  
>  Additionally I realized that the config API opens every file in
>  schemaplugindir (.../sssd.api.d) including hidden ones starting with a
>  '.'. This might lead to test failures if backup copies or swap file of
>  running editors are read. Since this is primarily an issue on developers
>  systems I wonder if this should be fixed or not?
>  
>  bye,
>  Sumit 
I found that this patch break 'make distcheck' because now 'make check'
really uses the files in the build directory and as a result *.pyc files
are created in the build directory which are currently not remove by
'make clean'.

This new version should fix this.

bye,
Sumit

[Jakub Hrozek]

On Fri, Feb 28, 2014 at 10:25:25AM +0100, Sumit Bose wrote:
>  On Wed, Feb 26, 2014 at 11:45:58AM +0100, Sumit Bose wrote:
>  > Hi,
>  > 
>  > I came across this while testing some changes to the config API.
>  > 
>  > Additionally I realized that the config API opens every file in
>  > schemaplugindir (.../sssd.api.d) including hidden ones starting with a
>  > '.'. This might lead to test failures if backup copies or swap file of
>  > running editors are read. Since this is primarily an issue on developers
>  > systems I wonder if this should be fixed or not?
>  > 
>  > bye,
>  > Sumit
>  
>  I found that this patch break 'make distcheck' because now 'make check'
>  really uses the files in the build directory and as a result *.pyc files
>  are created in the build directory which are currently not remove by
>  'make clean'.
>  
>  This new version should fix this.
>  
>  bye,
>  Sumit 
ACK.

make, make check and make distcheck all pass.

[Jakub Hrozek]

On Sun, Mar 02, 2014 at 09:46:12PM +0100, Jakub Hrozek wrote:
>  On Fri, Feb 28, 2014 at 10:25:25AM +0100, Sumit Bose wrote:
>  > On Wed, Feb 26, 2014 at 11:45:58AM +0100, Sumit Bose wrote:
>  > > Hi,
>  > > 
>  > > I came across this while testing some changes to the config API.
>  > > 
>  > > Additionally I realized that the config API opens every file in
>  > > schemaplugindir (.../sssd.api.d) including hidden ones starting with a
>  > > '.'. This might lead to test failures if backup copies or swap file of
>  > > running editors are read. Since this is primarily an issue on developers
>  > > systems I wonder if this should be fixed or not?
>  > > 
>  > > bye,
>  > > Sumit
>  > 
>  > I found that this patch break 'make distcheck' because now 'make
> check'
>  > really uses the files in the build directory and as a result *.pyc files
>  > are created in the build directory which are currently not remove by
>  > 'make clean'.
>  > 
>  > This new version should fix this.
>  > 
>  > bye,
>  > Sumit
>  
>  ACK.
>  
>  make, make check and make distcheck all pass. 
Pushed to master.