[PATCH] Remove renewal item if it is not re-added

[Sumit Bose]

Hi,

this patch should fix trac ticket #800 aka
https://bugzilla.redhat.com/show_bug.cgi?id=677588 .

I think this issue was introduce by some changes during the review of
the renewal feature.

bye,
Sumit

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/15/2011 07:04 AM, Sumit Bose wrote:
> Hi,
>
> this patch should fix trac ticket #800 aka
> https://bugzilla.redhat.com/show_bug.cgi?id=677588 .
>
> I think this issue was introduce by some changes during the review of
> the renewal feature.

Nack. Please add comments to explain the hash removal in
renew_tgt_done(), as well as the steal in renew_tgt().

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk1ag4MACgkQeiVVYja6o6M5JQCeI9Hkl4cQlZG50xQH1/AUB/jh
> ekQAn1afg6IpQ7alOiougDqn+VydfR2g
> =ZgkW
> -----END PGP SIGNATURE-----

[Simo Sorce]

On Tue, 15 Feb 2011 13:04:38 +0100
Sumit Bose  wrote:
> Hi,
>
> this patch should fix trac ticket #800 aka
> https://bugzilla.redhat.com/show_bug.cgi?id=677588 .
>
> I think this issue was introduce by some changes during the review of
> the renewal feature.

Can you use talloc_move if the original pointer is not going to be used
anymore ?

Simo.

[Sumit Bose]

On Tue, Feb 15, 2011 at 08:52:55AM -0500, Simo Sorce wrote:
> On Tue, 15 Feb 2011 13:04:38 +0100
> Sumit Bose  wrote:
> > Hi,
> >
> > this patch should fix trac ticket #800 aka
> > https://bugzilla.redhat.com/show_bug.cgi?id=677588 .
> >
> > I think this issue was introduce by some changes during the review of
> > the renewal feature.
>
> Can you use talloc_move if the original pointer is not going to be used
> anymore ?

sure, added talloc_move and some more comments. New patch attached.

bye,
Sumit
> Simo.
>
> -- 
> Simo Sorce * Red Hat, Inc * New York
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/17/2011 07:11 AM, Sumit Bose wrote:
> On Tue, Feb 15, 2011 at 08:52:55AM -0500, Simo Sorce wrote:
> > On Tue, 15 Feb 2011 13:04:38 +0100
> > Sumit Bose  wrote:
> > > Hi,
> > >
> > > this patch should fix trac ticket #800 aka
> > > https://bugzilla.redhat.com/show_bug.cgi?id=677588 .
> > >
> > > I think this issue was introduce by some changes during the review of
> > > the renewal feature.
> >
> > Can you use talloc_move if the original pointer is not going to be used
> > anymore ?
>
> sure, added talloc_move and some more comments. New patch attached.

Ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk1enxYACgkQeiVVYja6o6Ma1gCgiMZmgkLcuzV4lKDrxcTeyrlG
> n68An05TIJ3bMT/MaLPNjetxmFjhmLNN
> =7KkR
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/18/2011 11:32 AM, Stephen Gallagher wrote:
> On 02/17/2011 07:11 AM, Sumit Bose wrote:
> > On Tue, Feb 15, 2011 at 08:52:55AM -0500, Simo Sorce wrote:
> > > On Tue, 15 Feb 2011 13:04:38 +0100
> > > Sumit Bose  wrote:
> > > > Hi,
> > > >
> > > > this patch should fix trac ticket #800 aka
> > > > https://bugzilla.redhat.com/show_bug.cgi?id=677588 .
> > > >
> > > > I think this issue was introduce by some changes during the review of
> > > > the renewal feature.
> > >
> > > Can you use talloc_move if the original pointer is not going to be used
> > > anymore ?
> > sure, added talloc_move and some more comments. New patch attached.
>
> Ack.

Pushed to master and sssd-1-5.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk1e5XQACgkQeiVVYja6o6NWWACgjD+8Dl/cqv2bf0KWMQprgfAf
> rQgAn0styO5lLHTZ5KZI6v/BQYkZrQ1Y
> =l9OJ
> -----END PGP SIGNATURE-----