[PATCH] Fixed typo

[Sumit Bose]

On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
>   
Hi Thorsten,

thank you for the patch and bringing the attention to the *.doxy.in
files. Those files are autogenerated by doxygen where this typo and
others are already fixed upstream. Instead of fixing the typos
individually I wonder if it would be better to run doxygen -u on all
*.doxy.in files? But I'm not sure if files created by a newer version
can be handled by older versions as well. E.g. make docs is used in the
RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know if it
will just ignore new options or will it fail?

bye,
Sumit

> From a42c58bd867d99c2305475811c7380ad17ea67a4 Mon Sep 17 00:00:00 2001
> From: Thorsten Scherf <tscherf(a)redhat.com&gt;
> Date: Wed, 27 Feb 2013 21:39:42 +0100
> Subject: [PATCH] Fixed typo
>   
> ---
>  src/lib/idmap/sss_idmap.doxy.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>   
> diff --git a/src/lib/idmap/sss_idmap.doxy.in
b/src/lib/idmap/sss_idmap.doxy.in
> index
22827168b3025cf2fdde198047e31ebc26805812..7b46c28d7e0323c91ceb1314c78f816bf686f478 100644
> --- a/src/lib/idmap/sss_idmap.doxy.in
> +++ b/src/lib/idmap/sss_idmap.doxy.in
> @@ -291,7 +291,7 @@ TYPEDEF_HIDES_STRUCT   = NO
>  # causing a significant performance penality.
>  # If the system has enough physical memory increasing the cache will improve the
>  # performance by keeping more symbols in memory. Note that the value works on
> -# a logarithmic scale so increasing the size by one will rougly double the
> +# a logarithmic scale so increasing the size by one will roughly double the
>  # memory usage. The cache size is given by this formula:
>  # 2^(16+SYMBOL_CACHE_SIZE). The valid range is 0..9, the default is 0,
>  # corresponding to a cache size of 2^16 = 65536 symbols
> -- 
> 1.7.1
>   
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
>  On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
>  > 
>  
>  Hi Thorsten,
>  
>  thank you for the patch and bringing the attention to the *.doxy.in
>  files. Those files are autogenerated by doxygen where this typo and
>  others are already fixed upstream. Instead of fixing the typos
>  individually I wonder if it would be better to run doxygen -u on all
>  *.doxy.in files? But I'm not sure if files created by a newer version
>  can be handled by older versions as well. E.g. make docs is used in the
>  RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know if it
>  will just ignore new options or will it fail?
>  
>  bye,
>  Sumit 
I remember from fixing another related issue that old doxygen releases
would complain about an unknown option but would not fail.

So I think we can refresh the files, yes. Can you open a ticket?

[Sumit Bose]

On Thu, Feb 28, 2013 at 10:46:10AM +0100, Jakub Hrozek wrote:
>  On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
>  > On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
>  > > 
>  > 
>  > Hi Thorsten,
>  > 
>  > thank you for the patch and bringing the attention to the *.doxy.in
>  > files. Those files are autogenerated by doxygen where this typo and
>  > others are already fixed upstream. Instead of fixing the typos
>  > individually I wonder if it would be better to run doxygen -u on all
>  > *.doxy.in files? But I'm not sure if files created by a newer version
>  > can be handled by older versions as well. E.g. make docs is used in the
>  > RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know if it
>  > will just ignore new options or will it fail?
>  > 
>  > bye,
>  > Sumit
>  
>  I remember from fixing another related issue that old doxygen releases
>  would complain about an unknown option but would not fail.
>  
>  So I think we can refresh the files, yes. Can you open a ticket? 
I've created https://fedorahosted.org/sssd/ticket/1819 .

Thorsten, are you interested in providing a new patch here?

bye,
Sumit
>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Fixed typo

[Thorsten Scherf]

On [Thu, 28.02.2013 11:25], Sumit Bose wrote:
> On Thu, Feb 28, 2013 at 10:46:10AM +0100, Jakub Hrozek wrote:
> > On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
> > > On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
> > > >
> > >
> > > Hi Thorsten,
> > >
> > > thank you for the patch and bringing the attention to the *.doxy.in
> > > files. Those files are autogenerated by doxygen where this typo and
> > > others are already fixed upstream. Instead of fixing the typos
> > > individually I wonder if it would be better to run doxygen -u on all
> > > *.doxy.in files? But I'm not sure if files created by a newer version
> > > can be handled by older versions as well. E.g. make docs is used in the
> > > RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know if it
> > > will just ignore new options or will it fail?
> > >
> > > bye,
> > > Sumit
> >
> > I remember from fixing another related issue that old doxygen releases
> > would complain about an unknown option but would not fail.
> >
> > So I think we can refresh the files, yes. Can you open a ticket?
>
> I've created https://fedorahosted.org/sssd/ticket/1819 .
>
> Thorsten, are you interested in providing a new patch here? 
Patch attached.

The configs have been update based on doxygen-1.8.3.

Cheers,
Thorsten

Fixed typo

[Ondrej Kos]

On 02/28/2013 02:01 PM, Thorsten Scherf wrote:
>  On [Thu, 28.02.2013 11:25], Sumit Bose wrote:
> > On Thu, Feb 28, 2013 at 10:46:10AM +0100, Jakub Hrozek wrote:
> >> On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
> >> > On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
> >> > >
> >> >
> >> > Hi Thorsten,
> >> >
> >> > thank you for the patch and bringing the attention to the *.doxy.in
> >> > files. Those files are autogenerated by doxygen where this typo and
> >> > others are already fixed upstream. Instead of fixing the typos
> >> > individually I wonder if it would be better to run doxygen -u on all
> >> > *.doxy.in files? But I'm not sure if files created by a newer version
> >> > can be handled by older versions as well. E.g. make docs is used in
> >> the
> >> > RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know
> >> if it
> >> > will just ignore new options or will it fail?
> >> >
> >> > bye,
> >> > Sumit
> >>
> >> I remember from fixing another related issue that old doxygen releases
> >> would complain about an unknown option but would not fail.
> >>
> >> So I think we can refresh the files, yes. Can you open a ticket?
> >
> > I've created https://fedorahosted.org/sssd/ticket/1819 .
> >
> > Thorsten, are you interested in providing a new patch here?
>
>  Patch attached.
>
>  The configs have been update based on doxygen-1.8.3.
>
>  Cheers,
>  Thorsten
>  
Hi Thorsten,

I tested the documentation build with few versions of doxygen, and 
everything works fine. Could you please just add the trac link to the 
patch commit message?

Thanks
Ondra


-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

phone: [phone]
cell:  [phone]
ext:   82-62558
loc:   1013 Brno 1 office
irc:   okos @ #sssd #brno

Fixed typo

[Thorsten Scherf]

On [Mon, 04.03.2013 11:28], Ondrej Kos wrote:
> On 02/28/2013 02:01 PM, Thorsten Scherf wrote:
> >On [Thu, 28.02.2013 11:25], Sumit Bose wrote:
> >>On Thu, Feb 28, 2013 at 10:46:10AM +0100, Jakub Hrozek wrote:
> >>>On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
> >>>> On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
> >>>> >
> >>>>
> >>>> Hi Thorsten,
> >>>>
> >>>> thank you for the patch and bringing the attention to the *.doxy.in
> >>>> files. Those files are autogenerated by doxygen where this typo and
> >>>> others are already fixed upstream. Instead of fixing the typos
> >>>> individually I wonder if it would be better to run doxygen -u on all
> >>>> *.doxy.in files? But I'm not sure if files created by a newer
> version
> >>>> can be handled by older versions as well. E.g. make docs is used in
> >>>the
> >>>> RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know
> >>>if it
> >>>> will just ignore new options or will it fail?
> >>>>
> >>>> bye,
> >>>> Sumit
> >>>
> >>>I remember from fixing another related issue that old doxygen releases
> >>>would complain about an unknown option but would not fail.
> >>>
> >>>So I think we can refresh the files, yes. Can you open a ticket?
> >>
> >>I've created https://fedorahosted.org/sssd/ticket/1819 .
> >>
> >>Thorsten, are you interested in providing a new patch here?
> >
> >Patch attached.
> >
> >The configs have been update based on doxygen-1.8.3.
> >
> >Cheers,
> >Thorsten
> >
> Hi Thorsten,
>
> I tested the documentation build with few versions of doxygen, and 
> everything works fine. Could you please just add the trac link to the 
> patch commit message? 
Patch with changed commit message attached.

Cheers,
Thorsten

> Thanks
> Ondra
>
>
> -- 
> Ondrej Kos
> Associate Software Engineer
> Identity Management
> Red Hat Czech
>
> phone: [phone]
> cell:  [phone]
> ext:   82-62558
> loc:   1013 Brno 1 office
> irc:   okos @ #sssd #brno
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Fixed typo

[Thorsten Scherf]

Sorry, please ignore last mail. It contains a wrong patch. Will send in
the new one later on.


Cheers,
Thorsten

Fixed typo

[Thorsten Scherf]

On [Mon, 04.03.2013 11:28], Ondrej Kos wrote:
> On 02/28/2013 02:01 PM, Thorsten Scherf wrote:
> >On [Thu, 28.02.2013 11:25], Sumit Bose wrote:
> >>On Thu, Feb 28, 2013 at 10:46:10AM +0100, Jakub Hrozek wrote:
> >>>On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
> >>>> On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
> >>>> >
> >>>>
> >>>> Hi Thorsten,
> >>>>
> >>>> thank you for the patch and bringing the attention to the *.doxy.in
> >>>> files. Those files are autogenerated by doxygen where this typo and
> >>>> others are already fixed upstream. Instead of fixing the typos
> >>>> individually I wonder if it would be better to run doxygen -u on all
> >>>> *.doxy.in files? But I'm not sure if files created by a newer
> version
> >>>> can be handled by older versions as well. E.g. make docs is used in
> >>>the
> >>>> RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know
> >>>if it
> >>>> will just ignore new options or will it fail?
> >>>>
> >>>> bye,
> >>>> Sumit
> >>>
> >>>I remember from fixing another related issue that old doxygen releases
> >>>would complain about an unknown option but would not fail.
> >>>
> >>>So I think we can refresh the files, yes. Can you open a ticket?
> >>
> >>I've created https://fedorahosted.org/sssd/ticket/1819 .
> >>
> >>Thorsten, are you interested in providing a new patch here?
> >
> >Patch attached.
> >
> >The configs have been update based on doxygen-1.8.3.
> >
> >Cheers,
> >Thorsten
> >
> Hi Thorsten,
>
> I tested the documentation build with few versions of doxygen, and 
> everything works fine. Could you please just add the trac link to the 
> patch commit message? 
Correct patch attached this time.

Cheers,
Thorsten

Fixed typo

[Ondrej Kos]

On 03/04/2013 04:55 PM, Thorsten Scherf wrote:
>  On [Mon, 04.03.2013 11:28], Ondrej Kos wrote:
> > On 02/28/2013 02:01 PM, Thorsten Scherf wrote:
> >> On [Thu, 28.02.2013 11:25], Sumit Bose wrote:
> >>> On Thu, Feb 28, 2013 at 10:46:10AM +0100, Jakub Hrozek wrote:
> >>>> On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
> >>>>> On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
> >>>>> >
> >>>>>
> >>>>> Hi Thorsten,
> >>>>>
> >>>>> thank you for the patch and bringing the attention to the *.doxy.in
> >>>>> files. Those files are autogenerated by doxygen where this typo and
> >>>>> others are already fixed upstream. Instead of fixing the typos
> >>>>> individually I wonder if it would be better to run doxygen -u on all
> >>>>> *.doxy.in files? But I'm not sure if files created by a newer
> version
> >>>>> can be handled by older versions as well. E.g. make docs is used in
> >>>> the
> >>>>> RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone know
> >>>> if it
> >>>>> will just ignore new options or will it fail?
> >>>>>
> >>>>> bye,
> >>>>> Sumit
> >>>>
> >>>> I remember from fixing another related issue that old doxygen releases
> >>>> would complain about an unknown option but would not fail.
> >>>>
> >>>> So I think we can refresh the files, yes. Can you open a ticket?
> >>>
> >>> I've created https://fedorahosted.org/sssd/ticket/1819 .
> >>>
> >>> Thorsten, are you interested in providing a new patch here?
> >>
> >> Patch attached.
> >>
> >> The configs have been update based on doxygen-1.8.3.
> >>
> >> Cheers,
> >> Thorsten
> >>
> > Hi Thorsten,
> >
> > I tested the documentation build with few versions of doxygen, and
> > everything works fine. Could you please just add the trac link to the
> > patch commit message?
>
>  Correct patch attached this time.
>
>  Cheers,
>  Thorsten 
Thanks for the patch, Thorsten

Ack


Ondra


-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

phone: [phone]
cell:  [phone]
ext:   82-62558
loc:   1013 Brno 1 office
irc:   okos @ #sssd #brno

Fixed typo

[Jakub Hrozek]

On Mon, Mar 04, 2013 at 05:07:37PM +0100, Ondrej Kos wrote:
>  On 03/04/2013 04:55 PM, Thorsten Scherf wrote:
>  >On [Mon, 04.03.2013 11:28], Ondrej Kos wrote:
>  >>On 02/28/2013 02:01 PM, Thorsten Scherf wrote:
>  >>>On [Thu, 28.02.2013 11:25], Sumit Bose wrote:
>  >>>>On Thu, Feb 28, 2013 at 10:46:10AM +0100, Jakub Hrozek wrote:
>  >>>>>On Thu, Feb 28, 2013 at 09:36:13AM +0100, Sumit Bose wrote:
>  >>>>>>On Wed, Feb 27, 2013 at 09:51:16PM +0100, Thorsten Scherf wrote:
>  >>>>>>>
>  >>>>>>
>  >>>>>>Hi Thorsten,
>  >>>>>>
>  >>>>>>thank you for the patch and bringing the attention to the
> *.doxy.in
>  >>>>>>files. Those files are autogenerated by doxygen where this typo
> and
>  >>>>>>others are already fixed upstream. Instead of fixing the typos
>  >>>>>>individually I wonder if it would be better to run doxygen -u on
> all
>  >>>>>>*.doxy.in files? But I'm not sure if files created by a newer
> version
>  >>>>>>can be handled by older versions as well. E.g. make docs is used
> in
>  >>>>>the
>  >>>>>>RHEL-6 spec file which still uses doxygen-1.6.1. Does anyone
> know
>  >>>>>if it
>  >>>>>>will just ignore new options or will it fail?
>  >>>>>>
>  >>>>>>bye,
>  >>>>>>Sumit
>  >>>>>
>  >>>>>I remember from fixing another related issue that old doxygen
> releases
>  >>>>>would complain about an unknown option but would not fail.
>  >>>>>
>  >>>>>So I think we can refresh the files, yes. Can you open a ticket?
>  >>>>
>  >>>>I've created https://fedorahosted.org/sssd/ticket/1819 .
>  >>>>
>  >>>>Thorsten, are you interested in providing a new patch here?
>  >>>
>  >>>Patch attached.
>  >>>
>  >>>The configs have been update based on doxygen-1.8.3.
>  >>>
>  >>>Cheers,
>  >>>Thorsten
>  >>>
>  >>Hi Thorsten,
>  >>
>  >>I tested the documentation build with few versions of doxygen, and
>  >>everything works fine. Could you please just add the trac link to the
>  >>patch commit message?
>  >
>  >Correct patch attached this time.
>  >
>  >Cheers,
>  >Thorsten
>  
>  Thanks for the patch, Thorsten
>  
>  Ack 
Works for me on F18, el6 and el5, too.

Ack++ and pushed to master.