[PATCH] Minor bugs found by clang

[Jakub Hrozek]

I ran the new version of scan-build and checked the SSSD. There's a big
number of false positives, anything that follows this construct:

struct foostruct *f = NULL;

get_foo_vals(mem_ctxm &f);

process(f->foomember);

Triggers a warning that f->foomember is dereferencing NULL.

That said, clang also uncovered some real bugs. Attached are fixes for
bugs that are obvious, I will follow up with some others with people who
have more knowledge about the code in question.

[Michal Židek]

On 12/10/2012 08:43 AM, Jakub Hrozek wrote:
> I ran the new version of scan-build and checked the SSSD. There's a big
> number of false positives, anything that follows this construct:
>
> struct foostruct *f = NULL;
>
> get_foo_vals(mem_ctxm &f);
>
> process(f->foomember);
>
> Triggers a warning that f->foomember is dereferencing NULL.
>
> That said, clang also uncovered some real bugs. Attached are fixes for
> bugs that are obvious, I will follow up with some others with people who
> have more knowledge about the code in question.
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Ack to all 3 patches.

Michal

[Jakub Hrozek]

On Mon, Dec 10, 2012 at 03:42:26PM +0100, Michal Židek wrote:
> On 12/10/2012 08:43 AM, Jakub Hrozek wrote:
> > I ran the new version of scan-build and checked the SSSD. There's a big
> > number of false positives, anything that follows this construct:
> >
> > struct foostruct *f = NULL;
> >
> > get_foo_vals(mem_ctxm &f);
> >
> > process(f->foomember);
> >
> > Triggers a warning that f->foomember is dereferencing NULL.
> >
> > That said, clang also uncovered some real bugs. Attached are fixes for
> > bugs that are obvious, I will follow up with some others with people who
> > have more knowledge about the code in question.
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
> Ack to all 3 patches.
>
> Michal

Pushed to master and sssd-1-9