9:16 p.m.
New subject: [PATCH] Fix up header file names in util.h and add sssd-i18n.h
Why did you move config.h below talloc.h etc.. ?
Simo.
1:21 p.m.
On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote:
Why did you move config.h below talloc.h etc.. ?
Simo.
No functional reason, I think it's better if <> headers are first and
""
headers are last so since I was changing those lines anyway I decided to
move them up as well. This shouldn't have any impact, I wouldn't expect
that those headers would need config.h.
Martin
10:36 p.m.
New subject: [PATCH] Fix up header file names in util.h and add sssd-i18n.h
On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote:
On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote:
> Why did you move config.h below talloc.h etc.. ?
>
> Simo.
No functional reason, I think it's better if <> headers are first and
""
headers are last so since I was changing those lines anyway I decided to
move them up as well. This shouldn't have any impact, I wouldn't expect
that those headers would need config.h.
They might if libreplace kicks in on some platforms, I'd rather not move
it please.
Simo.
2:17 p.m.
On Tue, 2009-10-20 at 23:36 -0400, Simo Sorce wrote:
On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote:
> On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote:
> > Why did you move config.h below talloc.h etc.. ?
> >
> > Simo.
>
> No functional reason, I think it's better if <> headers are first and
""
> headers are last so since I was changing those lines anyway I decided to
> move them up as well. This shouldn't have any impact, I wouldn't expect
> that those headers would need config.h.
They might if libreplace kicks in on some platforms, I'd rather not move
it please.
Simo.
Ok, moved them back, new patch attached.
Martin
3:26 p.m.
Martin Nagy wrote:
On Tue, 2009-10-20 at 23:36 -0400, Simo Sorce wrote:
> On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote:
> > On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote:
> > > Why did you move config.h below talloc.h etc.. ?
> > >
> > > Simo.
> >
> > No functional reason, I think it's better if <> headers are first and
""
> > headers are last so since I was changing those lines anyway I decided to
> > move them up as well. This shouldn't have any impact, I wouldn't
expect
> > that those headers would need config.h.
>
> They might if libreplace kicks in on some platforms, I'd rather not move
> it please.
>
> Simo.
Ok, moved them back, new patch attached.
Martin
Self nack. After discussion on IRC with Stephen, we decided to
eliminate sssd-i18n.h altogether. New patch attached.
Martin
3:59 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/21/2009 04:26 PM, Martin Nagy wrote:
Martin Nagy wrote:
> On Tue, 2009-10-20 at 23:36 -0400, Simo Sorce wrote:
>> On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote:
>>> On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote:
>>>> Why did you move config.h below talloc.h etc.. ?
>>>>
>>>> Simo.
>>>
>>> No functional reason, I think it's better if <> headers are first
and ""
>>> headers are last so since I was changing those lines anyway I decided to
>>> move them up as well. This shouldn't have any impact, I wouldn't
expect
>>> that those headers would need config.h.
>>
>> They might if libreplace kicks in on some platforms, I'd rather not move
>> it please.
>>
>> Simo.
>
> Ok, moved them back, new patch attached.
>
> Martin
Self nack. After discussion on IRC with Stephen, we decided to
eliminate sssd-i18n.h altogether. New patch attached.
Martin
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
Ack.
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrfdisACgkQeiVVYja6o6MqZgCfW51q2pVaopPC+czAozaWBOiv
sKwAn3gvILpWzMkLuuVH3xJX1jXklhCy
=u9dG
-----END PGP SIGNATURE-----
1:01 p.m.
New subject: [PATCH] Fix up header file names in util.h and add sssd-i18n.h
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/21/2009 04:59 PM, Stephen Gallagher wrote:
On 10/21/2009 04:26 PM, Martin Nagy wrote:
> Martin Nagy wrote:
>> On Tue, 2009-10-20 at 23:36 -0400, Simo Sorce wrote:
>>> On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote:
>>>> On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote:
>>>>> Why did you move config.h below talloc.h etc.. ?
>>>>>
>>>>> Simo.
>>>>
>>>> No functional reason, I think it's better if <> headers are
first and ""
>>>> headers are last so since I was changing those lines anyway I decided to
>>>> move them up as well. This shouldn't have any impact, I wouldn't
expect
>>>> that those headers would need config.h.
>>>
>>> They might if libreplace kicks in on some platforms, I'd rather not move
>>> it please.
>>>
>>> Simo.
>>
>> Ok, moved them back, new patch attached.
>>
>> Martin
> Self nack. After discussion on IRC with Stephen, we decided to
> eliminate sssd-i18n.h altogether. New patch attached.
> Martin
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
Ack.
Pushed to master.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrgnfkACgkQeiVVYja6o6PJCgCfcAMxkVvzyEYT86bvGqxuG65g
U5AAoI4SH0HMv50rmLqWI24GbarF6iGN
=6RSl
-----END PGP SIGNATURE-----
11:50 a.m.
New subject: [PATCH] Fix up header file names in util.h and add sssd-i18n.h
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/21/2009 12:19 PM, Martin Nagy wrote:
Martin
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
Ack
- --
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkrfO88ACgkQeiVVYja6o6NkvwCdFNOaK6+bFTNBFchlp5LghsiK
rlsAoK+wrQ9yRA2U10u0cY8NpB+PAoCu
=31Je
-----END PGP SIGNATURE-----
5299
days inactive
5300
days old
sssd-devel@lists.fedorahosted.org
8 comments
3 participants
participants (3)
-
Martin Nagy -
Simo Sorce -
Stephen Gallagher