[PATCH] SYSDB: Commit transaction in sysdb_store_user

[Jakub Hrozek]

The recent sysdb patch broke sysdb_store_user and by extension the unit
tests. Neither me nor Michal have noticed most probably due to a bug
either in our Makefile.am or perhaps even the autotools -- the tests
binary doesn't get rebuild on issuing a simple make tests.

Anyway, a fix for the sysdb_store_user() function is attached. When
testing, please make sure to make clean before building the tests.

I renamed the previous done label into fail label as it was only
reachable on error condition and used a new done label to shortcut to
the transaction commit.

[Michal Židek]

On 09/04/2012 11:34 PM, Jakub Hrozek wrote:
> The recent sysdb patch broke sysdb_store_user and by extension the unit
> tests. Neither me nor Michal have noticed most probably due to a bug
> either in our Makefile.am or perhaps even the autotools -- the tests
> binary doesn't get rebuild on issuing a simple make tests.
>
> Anyway, a fix for the sysdb_store_user() function is attached. When
> testing, please make sure to make clean before building the tests.
>
> I renamed the previous done label into fail label as it was only
> reachable on error condition and used a new done label to shortcut to
> the transaction commit.
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Ack.

[Jakub Hrozek]

On Wed, Sep 05, 2012 at 10:40:59AM +0200, Michal Židek wrote:
> On 09/04/2012 11:34 PM, Jakub Hrozek wrote:
> > The recent sysdb patch broke sysdb_store_user and by extension the unit
> > tests. Neither me nor Michal have noticed most probably due to a bug
> > either in our Makefile.am or perhaps even the autotools -- the tests
> > binary doesn't get rebuild on issuing a simple make tests.
> >
> > Anyway, a fix for the sysdb_store_user() function is attached. When
> > testing, please make sure to make clean before building the tests.
> >
> > I renamed the previous done label into fail label as it was only
> > reachable on error condition and used a new done label to shortcut to
> > the transaction commit.
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
> Ack.

Pushed to master.