I was wondering for a while whether to remove the code only because it's unused when it's obviously correct. The code was added along with the InfoPipe interface btw (2008-ish).
On (11/09/13 20:06), Jakub Hrozek wrote:
I was wondering for a while whether to remove the code only because it's unused when it's obviously correct. The code was added along with the InfoPipe interface btw (2008-ish).
and last usage of these functions was removed in commit: commit bb4570d2f3ed0c9b780010623de82c4c76d15a2c Author: Stephen Gallagher sgallagh@redhat.com Date: Mon Jul 20 13:57:04 2009 -0400
Remove unused InfoPipe and PolicyKit code
Dead code is untested code; we don't want to have untested code. ACK
LS
On Thu, Sep 12, 2013 at 10:53:47AM +0200, Lukas Slebodnik wrote:
On (11/09/13 20:06), Jakub Hrozek wrote:
I was wondering for a while whether to remove the code only because it's unused when it's obviously correct. The code was added along with the InfoPipe interface btw (2008-ish).
and last usage of these functions was removed in commit: commit bb4570d2f3ed0c9b780010623de82c4c76d15a2c Author: Stephen Gallagher sgallagh@redhat.com Date: Mon Jul 20 13:57:04 2009 -0400
Remove unused InfoPipe and PolicyKit codeDead code is untested code; we don't want to have untested code. ACK
LS
OK, thank you for the review.
Pushed to master.
sssd-devel@lists.fedorahosted.org