[sssd PR#766][opened] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Author: mrniranjan
 Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
Action: opened

PR body:
"""
Multihost tests for: https://pagure.io/SSSD/sssd/issue/3757.

Signed-off-by: Niranjan M.R 
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/766/head:pr766
git checkout pr766

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

mrniranjan commented:
"""
Ran Below tests on s390x . (Linux ibm-z-130.rhts.eng.bos.redhat.com 4.18.0-74.el8.s390x #1 SMP Wed Feb 27 17:18:28 UTC 2019 s390x s390x s390x GNU/Linux)
```
test_kcm.py::TestSanityKCM::test_kinit_kcm
test_kcm.py::TestSanityKCM::Run kinit with KRB5CCNAME=KCM: PASSED
test_kcm.py::TestSanityKCM::test_ssh_login_kcm
test_kcm.py::TestSanityKCM::Verify ssh logins are successuful with kcm as default PASSED
test_kcm.py::TestSanityKCM::test_kcm_debug_level_set
test_kcm.py::TestSanityKCM::Test that just adding a [kcm] section and restarting the kcm PASSED
test_kcm.py::TestSanityKCM::test_kdestroy_retval
test_kcm.py::TestSanityKCM::Test that destroying an empty cache does not return a non-zero PASSED
test_kcm.py::TestSanityKCM::test_ssh_forward_creds
test_kcm.py::TestSanityKCM::Test that SSH can forward credentials with KCM PASSED
test_kcm.py::TestSanityKCM::test_kvno_display
test_kcm.py::TestSanityKCM::Test kvno correctly displays vesion numbers of principals PASSED
```
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-469159827

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[centos-ci]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

centos-ci commented:
"""
Can one of the admins verify this patch?
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-469169150

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

sumit-bose commented:
"""
ok to test
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-469171602

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

jhrozek commented:
"""
I don't understand this commit, sorry. How does it relate to the bug that was fixed? I mean, the commit is OK, but I don't understand how would it test the bug. Do you know if this test would fail with the broken version? (I can prepare one by reverting the fix..)
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-479493532

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

mrniranjan commented:
"""
@jhrozek i could run the tests against a build which doesn't contain the fix. I have only checked this against latest build. 
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-479783652

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

mrniranjan commented:
"""
@jhrozek this patch is to address bz-[1585313 ](https://bugzilla.redhat.com/show_bug.cgi?id=1585313)
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-479796895

[sssd PR#766][synchronized] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Author: mrniranjan
 Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/766/head:pr766
git checkout pr766

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

mrniranjan commented:
"""
@sumit-bose  the latest patch addresses the version number being checked against integer instead of hardcoded number . 
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-498017131

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

mrniranjan commented:
"""
Ran the kcm tests on (unpatched version) sssd-1.16.0-4.el8+5.s390x .

```
test_kcm.py::TestSanityKCM::test_kinit_kcm
test_kcm.py::TestSanityKCM::Run kinit with KRB5CCNAME=KCM: FAILED                                                                                                                                                                      [ 16%]
test_kcm.py::TestSanityKCM::test_ssh_login_kcm
test_kcm.py::TestSanityKCM::Verify ssh logins are successuful with kcm as default PASSED                                                                                                                                               [ 33%]
test_kcm.py::TestSanityKCM::test_kcm_debug_level_set
test_kcm.py::TestSanityKCM::Test that just adding a [kcm] section and restarting the kcm FAILED                                                                                                                                        [ 50%]
test_kcm.py::TestSanityKCM::test_kdestroy_retval
test_kcm.py::TestSanityKCM::Test that destroying an empty cache does not return a non-zero FAILED                                                                                                                                      [ 66%]
test_kcm.py::TestSanityKCM::test_ssh_forward_creds
test_kcm.py::TestSanityKCM::Test that SSH can forward credentials with KCM FAILED                                                                                                                                                      [ 83%]
test_kcm.py::TestSanityKCM::test_kvno_display
test_kcm.py::TestSanityKCM::Test kvno correctly displays vesion numbers of principals FAILED                       
```
kvno command failed on s390x with below errors:

```
[root@ibm-z-127 db]# kvno host/[e-mail]
kvno: Matching credential not found while getting credentials for host/[e-mail]
``````

[root@ibm-z-127 db]# KRB5_TRACE=/dev/stderr kvno host/[e-mail]
[29908] 1559635067.105027: Getting credentials @EXAMPLE.TEST -> host/[e-mail] using ccache KCM:0
[29908] 1559635067.105028: Retrieving @EXAMPLE.TEST -> host/[e-mail] from KCM:0 with result: -1765328243/Matching credential not found
[29908] 1559635067.105029: Retrieving @EXAMPLE.TEST -> krbtgt/[e-mail] from KCM:0 with result: -1765328243/Matching credential not found
kvno: Matching credential not found while getting credentials for host/[e-mail]
```

"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-498603837

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

mrniranjan commented:
"""
Ran the kcm tests on (unpatched version) sssd-1.16.0-4.el8+5.s390x .

```
test_kcm.py::TestSanityKCM::test_kinit_kcm
test_kcm.py::TestSanityKCM::Run kinit with KRB5CCNAME=KCM: FAILED                                                                                                                                                                      [ 16%]
test_kcm.py::TestSanityKCM::test_ssh_login_kcm
test_kcm.py::TestSanityKCM::Verify ssh logins are successuful with kcm as default PASSED                                                                                                                                               [ 33%]
test_kcm.py::TestSanityKCM::test_kcm_debug_level_set
test_kcm.py::TestSanityKCM::Test that just adding a [kcm] section and restarting the kcm FAILED                                                                                                                                        [ 50%]
test_kcm.py::TestSanityKCM::test_kdestroy_retval
test_kcm.py::TestSanityKCM::Test that destroying an empty cache does not return a non-zero FAILED                                                                                                                                      [ 66%]
test_kcm.py::TestSanityKCM::test_ssh_forward_creds
test_kcm.py::TestSanityKCM::Test that SSH can forward credentials with KCM FAILED                                                                                                                                                      [ 83%]
test_kcm.py::TestSanityKCM::test_kvno_display
test_kcm.py::TestSanityKCM::Test kvno correctly displays vesion numbers of principals FAILED                       
```
kvno command failed on s390x with below errors:

```
[root@ibm-z-127 db]# kvno host/[e-mail]
kvno: Matching credential not found while getting credentials for host/[e-mail]
```
```
[root@ibm-z-127 db]# KRB5_TRACE=/dev/stderr kvno host/[e-mail]
[29908] 1559635067.105027: Getting credentials @EXAMPLE.TEST -> host/[e-mail] using ccache KCM:0
[29908] 1559635067.105028: Retrieving @EXAMPLE.TEST -> host/[e-mail] from KCM:0 with result: -1765328243/Matching credential not found
[29908] 1559635067.105029: Retrieving @EXAMPLE.TEST -> krbtgt/[e-mail] from KCM:0 with result: -1765328243/Matching credential not found
kvno: Matching credential not found while getting credentials for host/[e-mail]
```

"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-498603837

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

mrniranjan commented:
"""
@jhrozek  @sumit-bose  can you review the latest changes. 
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-502770926

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

jhrozek commented:
"""
LGTM and the test passes with a recent sssd build (I didn't try with the old one, but I trust @mrniranjan when he says he did)
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-502801260

[sssd PR#766][+Accepted] TESTS: Test kvno correctly displays vesion numbers of principals

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

Label: +Accepted

[sssd PR#766][comment] TESTS: Test kvno correctly displays vesion numbers of principals

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

jhrozek commented:
"""
* master: 0b210838e46302493e920fab080101b7f54c8b94
"""

See the full comment at https://github.com/SSSD/sssd/pull/766#issuecomment-502801874

[sssd PR#766][closed] TESTS: Test kvno correctly displays vesion numbers of principals

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/766
Author: mrniranjan
 Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/766/head:pr766
git checkout pr766

[sssd PR#766][+Pushed] TESTS: Test kvno correctly displays vesion numbers of principals

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/766
Title: #766: TESTS: Test kvno correctly displays vesion numbers of principals

Label: +Pushed