[PATCH] IPA server mode: properly initialize ext_groups

[Sumit Bose]

Hi,

when writing the code to read IPA memberships for trusted AD users I
didn't carefully check how struct ipa_server_mode_ctx is initialized.
Hence the new member I have added was not properly initialized. This patch
should fix it.

bye,
Sumit

[Jakub Hrozek]

On Wed, Oct 16, 2013 at 10:49:44AM +0200, Sumit Bose wrote:
> Hi,
>
> when writing the code to read IPA memberships for trusted AD users I
> didn't carefully check how struct ipa_server_mode_ctx is initialized.
> Hence the new member I have added was not properly initialized. This patch
> should fix it.
>
> bye,
> Sumit
> From 3d6fb8fcaa650d1da60a2e575847bd6fcfa08c72 Mon Sep 17 00:00:00 2001
> From: Sumit Bose 
> Date: Wed, 16 Oct 2013 10:45:52 +0200
> Subject: [PATCH] IPA server mode: properly initialize ext_groups
>
> src/providers/ipa/ipa_subdomains.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
> index bfbdabf..ea55f70 100644
> --- a/src/providers/ipa/ipa_subdomains.c
> +++ b/src/providers/ipa/ipa_subdomains.c
> @@ -1305,13 +1305,14 @@ int ipa_ad_subdom_init(struct be_ctx *be_ctx,
>          return EINVAL;
>      }
> id_ctx->server_mode = talloc(id_ctx, struct ipa_server_mode_ctx);
>
> id_ctx->server_mode = talloc_zero(id_ctx, struct ipa_server_mode_ctx);
> if (id_ctx->server_mode == NULL) {
>     return ENOMEM;
> }
> id_ctx->server_mode->realm = realm;
> id_ctx->server_mode->hostname = hostname;
> id_ctx->server_mode->trusts = NULL;
>
> id_ctx->server_mode->ext_groups = NULL;
>
> return EOK;
> }
>
> 1.8.3.1

I see you made really sure the structure members will be zeroed :-)

ACK

[Jakub Hrozek]

On Wed, Oct 16, 2013 at 12:08:37PM +0200, Jakub Hrozek wrote:
> On Wed, Oct 16, 2013 at 10:49:44AM +0200, Sumit Bose wrote:
> > Hi,
> >
> > when writing the code to read IPA memberships for trusted AD users I
> > didn't carefully check how struct ipa_server_mode_ctx is initialized.
> > Hence the new member I have added was not properly initialized. This patch
> > should fix it.
> >
> > bye,
> > Sumit
> > From 3d6fb8fcaa650d1da60a2e575847bd6fcfa08c72 Mon Sep 17 00:00:00 2001
> > From: Sumit Bose 
> > Date: Wed, 16 Oct 2013 10:45:52 +0200
> > Subject: [PATCH] IPA server mode: properly initialize ext_groups
> >
> > src/providers/ipa/ipa_subdomains.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
> > index bfbdabf..ea55f70 100644
> > --- a/src/providers/ipa/ipa_subdomains.c
> > +++ b/src/providers/ipa/ipa_subdomains.c
> > @@ -1305,13 +1305,14 @@ int ipa_ad_subdom_init(struct be_ctx *be_ctx,
> >          return EINVAL;
> >      }
> > id_ctx->server_mode = talloc(id_ctx, struct ipa_server_mode_ctx);
> >
> > id_ctx->server_mode = talloc_zero(id_ctx, struct ipa_server_mode_ctx);
> > if (id_ctx->server_mode == NULL) {
> >     return ENOMEM;
> > }
> > id_ctx->server_mode->realm = realm;
> > id_ctx->server_mode->hostname = hostname;
> > id_ctx->server_mode->trusts = NULL;
> >
> > id_ctx->server_mode->ext_groups = NULL;
> >
> > return EOK;
> > }
> >
> > 1.8.3.1
>
> I see you made really sure the structure members will be zeroed :-)
>
> ACK

Pushed to master and sssd-1-11

[Alexander Bokovoy]

On Wed, 16 Oct 2013, Sumit Bose wrote:
> Hi,
>
> when writing the code to read IPA memberships for trusted AD users I
> didn't carefully check how struct ipa_server_mode_ctx is initialized.
> Hence the new member I have added was not properly initialized. This patch
> should fix it.

ACK. Can we get this into released versions in Fedora 19 and Fedora 20
ASAP since this crash bug is important to fix before release and we are in
Beta release now with F20?

[Jakub Hrozek]

On Wed, Oct 16, 2013 at 01:27:44PM +0300, Alexander Bokovoy wrote:
> On Wed, 16 Oct 2013, Sumit Bose wrote:
> > Hi,
> >
> > when writing the code to read IPA memberships for trusted AD users I
> > didn't carefully check how struct ipa_server_mode_ctx is initialized.
> > Hence the new member I have added was not properly initialized. This patch
> > should fix it.
>
> ACK. Can we get this into released versions in Fedora 19 and Fedora 20
> ASAP since this crash bug is important to fix before release and we are in
> Beta release now with F20?

Feel free to add Karma:
https://admin.fedoraproject.org/updates/sssd-1.11.1-5.fc20
https://admin.fedoraproject.org/updates/sssd-1.11.1-4.fc19