[sssd PR#442][opened] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/442
Author: fidencio
 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth
Action: opened

PR body:
"""
Because we weren't treating the errors coming from
sdap_cli_connect_recv() properly we ended up introducing a regression in
the commit add72860c7, related to offline authentication.

From now on, let's properly treat errors coming from auth_connect_send(),
which were treated before by going offline when be_resolve_server_recv()
failed, and propagate ETIMEDOUT to the request, thus going offline and
allowing offline authentication on those cases.

This patch fixes the regression reported by Lukáš on
https://bugzilla.redhat.com/show_bug.cgi?id=1459609#c9. (And I have to say a big thanks
for finding this out!)

Related:
https://pagure.io/SSSD/sssd/issue/3451

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/442/head:pr442
git checkout pr442

[sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

fidencio commented:
"""
I've ran two downstream tests and both passed successfully:
- 2131430 (the one that found this regression)
- 2131429 (the one recommended by Jakub when the first patch was pushed)

If you guys have some idea about a better set of downstream tests to run, please, ping me
in private with the link that I could clone.
"""

See the full comment at https://github.com/SSSD/sssd/pull/442#issuecomment-342749395

[sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

sumit-bose commented:
"""
The patch makes sense and passes the CI (with the current exception on F27 and rawhide
caused by the newer libldb). ACK

@fidencio, please let me know when you have the results of the regression test.
"""

See the full comment at https://github.com/SSSD/sssd/pull/442#issuecomment-343213441

[sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

lslebodn commented:
"""
@sumit-bose  I'm waiting for results of tests.

I'll push the patch after good results with your ACK

"""

See the full comment at https://github.com/SSSD/sssd/pull/442#issuecomment-343483473

[sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

sumit-bose commented:
"""
@lslebodn, thanks, shall I set the Accepted flag or will you do it?
"""

See the full comment at https://github.com/SSSD/sssd/pull/442#issuecomment-343489393

[sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

lslebodn commented:
"""
There were some random failures which I did not see before. But it worked well after
re-executing problematic jobs 5 times. I hope it was not related :-)
"""

See the full comment at https://github.com/SSSD/sssd/pull/442#issuecomment-343581633

[sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

lslebodn commented:
"""
master:
* 20d18db36096e3fa2636143a83a12a2e3a7f26d6
"""

See the full comment at https://github.com/SSSD/sssd/pull/442#issuecomment-343581840

[sssd PR#442][closed] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/442
Author: fidencio
 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/442/head:pr442
git checkout pr442

[sssd PR#442][+Pushed] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

Label: +Pushed