Remove https://github.com/SSSD/gh-mailinglist-notifications, add https://github.com/SSSD/docs
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
Anyone against?
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
LS
On Fri, Mar 31, 2017 at 10:35:20AM +0200, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
I wonder if there might be benefits to allow/accept pull-request for code on pagure as well and use github as an alternative way to submit pull-requests?
bye, Sumit
LS _______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-leave@lists.fedorahosted.org
On Fri, Mar 31, 2017 at 10:55:29AM +0200, Sumit Bose wrote:
On Fri, Mar 31, 2017 at 10:35:20AM +0200, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
I wonder if there might be benefits to allow/accept pull-request for code on pagure as well and use github as an alternative way to submit pull-requests?
We already do receive pagure pull requests: https://pagure.io/SSSD/sssd/pull-request/3320
But it's just nicer to have everything in one place for a lazy person like me, otherwise it's easy to forget about some PR, especially from an occasional contributor who wouldn't remind about the stalled PR on IRC or a meeting.
(of course I'm not going to say no, go file the PR somewhere else to a person who already contributed code to us..)
On (31/03/17 15:16), Jakub Hrozek wrote:
On Fri, Mar 31, 2017 at 10:55:29AM +0200, Sumit Bose wrote:
On Fri, Mar 31, 2017 at 10:35:20AM +0200, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
I wonder if there might be benefits to allow/accept pull-request for code on pagure as well and use github as an alternative way to submit pull-requests?
We already do receive pagure pull requests: https://pagure.io/SSSD/sssd/pull-request/3320
But it's just nicer to have everything in one place for a lazy person like me, otherwise it's easy to forget about some PR, especially from an occasional contributor who wouldn't remind about the stalled PR on IRC or a meeting.
I redirected all notifications from GH/SSSD/sssd to the same mailbox as sssd-devel. And the same for pull request notification from pagure/SSSD/sssd.
LS
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
LS
On (31/03/17 11:50), Lukas Slebodnik wrote:
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
And another benefit of PRs for docs on pagure is that it would be much simpler to use automation (git hooks/or other automated way). So we can see even rendered output from sphinx and not just rendered rst.
LS
On 03/31/2017 11:50 AM, Lukas Slebodnik wrote:
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
And I say allow PR on both and let the writer choose service to file PR. We switched to github to encourage contributors to patch sssd, we should do the same also for documentation.
On (31/03/17 12:05), Pavel Březina wrote:
On 03/31/2017 11:50 AM, Lukas Slebodnik wrote:
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
And I say allow PR on both and let the writer choose service to file PR. We switched to github to encourage contributors to patch sssd, we should do the same also for documentation.
Not sure whether you noticed my other mail before this reply. https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.o...
If you are a volunteer to prepare something similar also for GH then we can have also mirror there.
LS
On 03/31/2017 12:16 PM, Lukas Slebodnik wrote:
On (31/03/17 12:05), Pavel Březina wrote:
On 03/31/2017 11:50 AM, Lukas Slebodnik wrote:
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
And I say allow PR on both and let the writer choose service to file PR. We switched to github to encourage contributors to patch sssd, we should do the same also for documentation.
Not sure whether you noticed my other mail before this reply. https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.o...
Nope.
If you are a volunteer to prepare something similar also for GH then we can have also mirror there.
Sure, I can look into it when pagure docs are ready.
LS _______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-leave@lists.fedorahosted.org
On Fri, Mar 31, 2017 at 11:50:15AM +0200, Lukas Slebodnik wrote:
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
I don't insist on the PRs for our docs submissions for docs and the rendering is a good point. But I still think it would be nice to have the docs repo mirrored as well at least to make it better discoverable.
Also github has a almost-wysiwyg editor which might be an easy way for non-developers to submit PRs for docs. Because my main gripe with the docs in RST is that they are not as easy to write as the fedorahosted wiki pages used to be.
On (31/03/17 15:23), Jakub Hrozek wrote:
On Fri, Mar 31, 2017 at 11:50:15AM +0200, Lukas Slebodnik wrote:
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
I don't insist on the PRs for our docs submissions for docs and the rendering is a good point. But I still think it would be nice to have the docs repo mirrored as well at least to make it better discoverable.
Also github has a almost-wysiwyg editor which might be an easy way for non-developers to submit PRs for docs. Because my main gripe with the docs in RST is that they are not as easy to write as the fedorahosted wiki pages used to be.
Pagure has button "Fork and edit" as well https://pagure.io/SSSD/docs/blob/master/f/index.rst
The main point is that rendered rst by pagure/github is just a sanity check. No reason to use github.
And if somebody prepare POC with rendering htmls with PR on github then we can mirror repo there.
LS
On Fri, Mar 31, 2017 at 03:43:23PM +0200, Lukas Slebodnik wrote:
And if somebody prepare POC with rendering htmls with PR on github then we can mirror repo there.
This is not a blocker to mirroring.
On (31/03/17 16:17), Jakub Hrozek wrote:
On Fri, Mar 31, 2017 at 03:43:23PM +0200, Lukas Slebodnik wrote:
And if somebody prepare POC with rendering htmls with PR on github then we can mirror repo there.
This is not a blocker to mirroring.
Why?
My experience is that if something is not required then it will not be done. e.g. writing test together with bug fix https://pagure.io/SSSD/sssd/issue/3045#comment-221497
This is a reason why I would prefer to have it as a blocker. Kind of a motivation to do it now.
LS
On 03/31/2017 03:23 PM, Jakub Hrozek wrote:
On Fri, Mar 31, 2017 at 11:50:15AM +0200, Lukas Slebodnik wrote:
On (31/03/17 11:00), Pavel Březina wrote:
On 03/31/2017 10:35 AM, Lukas Slebodnik wrote:
On (30/03/17 21:18), Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
+1
At the same time, I'd like to add a mirror of https://pagure.io/SSSD/docs to github in order to follow the same process for both docs and code. Right now it's quite confusing to have PRs for code on one place and PRs for docs on another.
-1
Pagure has pull requests as well.
We are used to github, I have scripts built around it, let's stick with one service.
<joking> OK move everything to pagure </joking>
It is totally different repo. And we need to be sure that it works well (renders properly) in pagure. So the benefit of SSSD/docs on github is minimal. And I do not expect very high traffic(many PRs) in docs repo.
I don't insist on the PRs for our docs submissions for docs and the rendering is a good point. But I still think it would be nice to have the docs repo mirrored as well at least to make it better discoverable.
Also github has a almost-wysiwyg editor which might be an easy way for non-developers to submit PRs for docs. Because my main gripe with the docs in RST is that they are not as easy to write as the fedorahosted wiki pages used to be.
We can also allow markdown in favor of rst, I find it easier to write (though mainly because I'm more familiar with it through github).
http://www.sphinx-doc.org/en/stable/markdown.html
I already had a patch available, then I converted the document to rest since this version of markdown does not contain diagrams.
On Thu, Mar 30, 2017 at 09:18:39PM +0200, Jakub Hrozek wrote:
Hi,
I'd like to remove https://github.com/SSSD/gh-mailinglist-notifications -- we're not currently using it, but we're rather using Martin Basti's mail notifier.
Deleted
sssd-devel@lists.fedorahosted.org
-
Jakub Hrozek -
Lukas Slebodnik -
Pavel Březina -
Sumit Bose