[PATCH] MAN: Remove indentation in element programlistening

[Lukas Slebodnik]

ehlo,

I noticed that indentation of examples for ad_gpo_map_* is realy weird.
attached is a simple patch which just remove whitespaces.

How it looked on terminal (80x25):
       ad_gpo_map_network (string)
           A comma-separated list of PAM service names for which GPO-based
           access control is evaluated based on the NetworkLogonRight and
           DenyNetworkLogonRight policy settings.

It is possible to add another PAM service name to the default set
           by using “+service_name” or to explicitly remove a PAM service name
           from the default set by using “-service_name”. For example, in
           order to replace a default PAM service name for this logon right
           (e.g.  “ftp”) with a custom pam service name (e.g.
           “my_pam_service”), you would use the following configuration:

ad_gpo_map_network = +my_pam_service, -ftp

Default: the default set of PAM service names includes:

LS

[Roland Mainz]

----- Original Message -----
> From: "Lukas Slebodnik" 
> To: [e-mail]
> Sent: Wednesday, January 14, 2015 2:11:22 PM
> Subject: [SSSD] [PATCH] MAN: Remove indentation in element programlistening
>
> ehlo,
>
> I noticed that indentation of examples for ad_gpo_map_* is realy weird.

That's the expected behaviour with <programlisting> vs. space/tab/etc characters - leading spaces/tabs/etc. are part of the formatting.
> attached is a simple patch which just remove whitespaces.

[snip]

Patch looks good to me, r=[e-mail]

----

Bye,
Roland

[Jakub Hrozek]

On Wed, Jan 14, 2015 at 09:10:29AM -0500, Roland Mainz wrote:
> ----- Original Message -----
> > From: "Lukas Slebodnik" 
> > To: [e-mail]
> > Sent: Wednesday, January 14, 2015 2:11:22 PM
> > Subject: [SSSD] [PATCH] MAN: Remove indentation in element programlistening
> >
> > ehlo,
> >
> > I noticed that indentation of examples for ad_gpo_map_* is realy weird.
>
> That's the expected behaviour with <programlisting> vs. space/tab/etc characters - leading spaces/tabs/etc. are part of the formatting.
> > attached is a simple patch which just remove whitespaces.
>
> [snip]
>
> Patch looks good to me, r=[e-mail]

Thank you for the review, pushed to master as
ecf9e7a870945ecfba8eb751d344de3601de9424

Using XIncludes for longer <programlisting> chunks ? / was: Re: [PATCH] MAN: Remove indentation in element programlistening

[Roland Mainz]

----- Original Message -----
> From: "Jakub Hrozek" 
> To: [e-mail]
> Sent: Wednesday, January 14, 2015 4:19:15 PM
> Subject: Re: [SSSD] [PATCH] MAN: Remove indentation in element programlistening
>
> On Wed, Jan 14, 2015 at 09:10:29AM -0500, Roland Mainz wrote:
> > ----- Original Message -----
> > > From: "Lukas Slebodnik" 
> > > To: [e-mail]
> > > Sent: Wednesday, January 14, 2015 2:11:22 PM
> > > Subject: [SSSD] [PATCH] MAN: Remove indentation in element
> > > programlistening
> > >
> > > ehlo,
> > >
> > > I noticed that indentation of examples for ad_gpo_map_* is realy weird.
> >
> > That's the expected behaviour with <programlisting> vs. space/tab/etc
> > characters - leading spaces/tabs/etc. are part of the formatting.
> > > attached is a simple patch which just remove whitespaces.
> >
> > [snip]
> >
> > Patch looks good to me, r=[e-mail]
>
> Thank you for the review, pushed to master as
> ecf9e7a870945ecfba8eb751d344de3601de9424

BTW: In the future it may be interesting to use XInclude for longer <programlisting> chunks to prevent the quoting (and layout) hell - see https://lists.fedorahosted.org/pipermail/sssd-devel/2015-January/022352.html ("[SSSD] Using XInclude for DocBook/XML manpages ... / was: Re: xml schema used for generating man pages") for examples...

----

Bye,
Roland