[PATCH]-Quiet down the startup of sssd

[Ariel Barria]

https://fedorahosted.org/sssd/ticket/1294

[Jan Zelený]

> https://fedorahosted.org/sssd/ticket/1294

Nack,
in general we don't like using the exit() function.

Also as I understand it, the intended solution was to change debug levels of 
some DEBUG calls to the new format. See the bugzilla linked with the ticket.

Thanks
Jan

[Jakub Hrozek]

On Tue, Jun 12, 2012 at 11:10:46AM +0200, Jan Zelený wrote:
> > https://fedorahosted.org/sssd/ticket/1294
>
> Nack,
> in general we don't like using the exit() function.

Jan meant that it's bad manners to use exit() inside a function that you
have no idea how exactly will be used. Please only use exit when
terminating program from main(), or if you really need to quit because
of some very severe erorr.
> Also as I understand it, the intended solution was to change debug levels of 
> some DEBUG calls to the new format. See the bugzilla linked with the ticket.

Yes

[Ariel Barria]

thanks for comments
> Date: Tue, 12 Jun 2012 11:54:02 +0200
> From: [e-mail]
> To: [e-mail]
> Subject: Re: [SSSD] [PATCH]-Quiet down the startup of sssd
>
> On Tue, Jun 12, 2012 at 11:10:46AM +0200, Jan Zelený wrote:
> > > https://fedorahosted.org/sssd/ticket/1294
> >
> > Nack,
> > in general we don't like using the exit() function.
>
> Jan meant that it's bad manners to use exit() inside a function that you
> have no idea how exactly will be used. Please only use exit when
> terminating program from main(), or if you really need to quit because
> of some very severe erorr.
> > Also as I understand it, the intended solution was to change debug levels of 
> > some DEBUG calls to the new format. See the bugzilla linked with the ticket.
>
> Yes
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

[Stephen Gallagher]

On Tue, 2012-06-12 at 23:22 -0500, Ariel Barria wrote:
> thanks for comments
> > Date: Tue, 12 Jun 2012 11:54:02 +0200
> > From: [e-mail]
> > To: [e-mail]
> > Subject: Re: [SSSD] [PATCH]-Quiet down the startup of sssd
> >
> > On Tue, Jun 12, 2012 at 11:10:46AM +0200, Jan Zelený wrote:
> > > > https://fedorahosted.org/sssd/ticket/1294
> > >
> > > Nack,
> > > in general we don't like using the exit() function.
> >
> > Jan meant that it's bad manners to use exit() inside a function that
>
> you
> > have no idea how exactly will be used. Please only use exit when
> > terminating program from main(), or if you really need to quit
>
> because
> > of some very severe erorr.
> > > Also as I understand it, the intended solution was to change debug
>
> levels of
> > > some DEBUG calls to the new format. See the bugzilla linked with
>
> the ticket.
> > Yes

Nack, for several reasons.

First, this patch is incomplete. There are far more places that need
adjusting than this single message.

Secondly, I didn't realize it until yesterday, but the original reporter
of this bug also submitted a proposed patch to fix it, which I'm
including here. I will review this patch today.

Thank you very much for your interest Ariel, sorry that this one didn't
really work out.

[Stephen Gallagher]

On Thu, 2012-06-14 at 08:10 -0400, Stephen Gallagher wrote:
> On Tue, 2012-06-12 at 23:22 -0500, Ariel Barria wrote:
> > thanks for comments
> > > Date: Tue, 12 Jun 2012 11:54:02 +0200
> > > From: [e-mail]
> > > To: [e-mail]
> > > Subject: Re: [SSSD] [PATCH]-Quiet down the startup of sssd
> > >
> > > On Tue, Jun 12, 2012 at 11:10:46AM +0200, Jan Zelený wrote:
> > > > > https://fedorahosted.org/sssd/ticket/1294
> > > >
> > > > Nack,
> > > > in general we don't like using the exit() function.
> > >
> > > Jan meant that it's bad manners to use exit() inside a function that
> >
> > you
> > > have no idea how exactly will be used. Please only use exit when
> > > terminating program from main(), or if you really need to quit
> >
> > because
> > > of some very severe erorr.
> > > > Also as I understand it, the intended solution was to change debug
> >
> > levels of
> > > > some DEBUG calls to the new format. See the bugzilla linked with
> >
> > the ticket.
> > > Yes
>
> Nack, for several reasons.
>
> First, this patch is incomplete. There are far more places that need
> adjusting than this single message.
>
> Secondly, I didn't realize it until yesterday, but the original reporter
> of this bug also submitted a proposed patch to fix it, which I'm
> including here. I will review this patch today.
>
> Thank you very much for your interest Ariel, sorry that this one didn't
> really work out.

Ack.

[Stephen Gallagher]

On Tue, 2012-06-19 at 08:55 -0400, Stephen Gallagher wrote:
> On Thu, 2012-06-14 at 08:10 -0400, Stephen Gallagher wrote:
> > On Tue, 2012-06-12 at 23:22 -0500, Ariel Barria wrote:
> > > thanks for comments
> > > > Date: Tue, 12 Jun 2012 11:54:02 +0200
> > > > From: [e-mail]
> > > > To: [e-mail]
> > > > Subject: Re: [SSSD] [PATCH]-Quiet down the startup of sssd
> > > >
> > > > On Tue, Jun 12, 2012 at 11:10:46AM +0200, Jan Zelený wrote:
> > > > > > https://fedorahosted.org/sssd/ticket/1294
> > > > >
> > > > > Nack,
> > > > > in general we don't like using the exit() function.
> > > >
> > > > Jan meant that it's bad manners to use exit() inside a function that
> > >
> > > you
> > > > have no idea how exactly will be used. Please only use exit when
> > > > terminating program from main(), or if you really need to quit
> > >
> > > because
> > > > of some very severe erorr.
> > > > > Also as I understand it, the intended solution was to change debug
> > >
> > > levels of
> > > > > some DEBUG calls to the new format. See the bugzilla linked with
> > >
> > > the ticket.
> > > > Yes
> >
> > Nack, for several reasons.
> >
> > First, this patch is incomplete. There are far more places that need
> > adjusting than this single message.
> >
> > Secondly, I didn't realize it until yesterday, but the original reporter
> > of this bug also submitted a proposed patch to fix it, which I'm
> > including here. I will review this patch today.
> >
> > Thank you very much for your interest Ariel, sorry that this one didn't
> > really work out.
>
> Ack.

Pushed to master.