When we replace the member attribute on an entry we calculate the list of total addition vs deletions and then make sure a dn does not appear in both at the same time.
The code was wrong and was skipping the next comparison each time a match was found due to an array counter error.
This was causing unnecessary work to add entries that were already present.
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/13/2011 05:31 PM, Simo Sorce wrote:
When we replace the member attribute on an entry we calculate the list of total addition vs deletions and then make sure a dn does not appear in both at the same time.
The code was wrong and was skipping the next comparison each time a match was found due to an array counter error.
This was causing unnecessary work to add entries that were already present.
Ack.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 04/14/2011 11:20 AM, Stephen Gallagher wrote:
On 04/13/2011 05:31 PM, Simo Sorce wrote:
When we replace the member attribute on an entry we calculate the list of total addition vs deletions and then make sure a dn does not appear in both at the same time.
The code was wrong and was skipping the next comparison each time a match was found due to an array counter error.
This was causing unnecessary work to add entries that were already present.
Ack.
Pushed to master and sssd-1-5.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Simo Sorce -
Stephen Gallagher