[sssd PR#556][opened] COVERITY: Add coverity support

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/556
Author: fidencio
 Title: #556: COVERITY: Add coverity support
Action: opened

PR body:
"""
Using travis-ci we can start doing coverity scans on every pushed code.
This is not something new as so far we have been relying on sgallagh's
internal infra to do so, unfortunatelly the infra is about to be
retired ... thus, start to use public coverity's instance is a hard
requirement for us.

Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com&gt;
Signed-off-by: Edjunior Machado <emachado(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/556/head:pr556
git checkout pr556

[sssd PR#556][comment] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
https://travis-ci.org/SSSD/sssd/builds/368726074
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-382811859

[sssd PR#556][comment] COVERITY: Add coverity support

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
We talked about this with Jakub few weeks ago. Your patches looks nice, thank you for this
initiation. There is just one thing we must keep in mind, as you can see at
https://scan.coverity.com there are limits for free scans:
>  **Updated Build Limits**
>  Effective immediately, the build limits have been increased across all project sizes.
>  The number of weekly builds per project are as follows:
>  * Up to 28 builds per week, with a maximum of 4 builds per day, for projects with fewer
> than 100K lines of code
>  * Up to 21 builds per week, with a maximum of 3 builds per day, for projects with 100K to
> 500K lines of code
>  * Up to 14 builds per week, with a maximum of 2 build per day, for projects with 500K to
> 1 million lines of code
>  * Up to 7 builds per week, with a maximum of 1 build per day, for projects with more than
> 1 million lines of code
>
>  As before, once a project reaches the maximum builds per week, additional build requests
> will be rejected. 
>  
Therefore, we should not run it per pull request, but rather run it daily on master and
manually per-pr when needed urgently.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-384948464

[sssd PR#556][comment] COVERITY: Add coverity support

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
Also I  see failure at https://travis-ci.org/SSSD/sssd/builds/368726074#L7056 what does it
mean?
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-384948776

[sssd PR#556][comment] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
Yep, we don't push more than once a day anyways.

About the error, I didn't notice it before. Not sure what it means.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-384952672

[sssd PR#556][comment] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
I have rebased my branch and fired a new build, let's see what happens.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-384955545

[sssd PR#556][comment] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
https://travis-ci.org/SSSD/sssd/builds/372008660

The error may happen if you're updating the very same build twice (which was the
case).
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-384962016

[sssd PR#556][comment] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
Actually no: Coverity Scan upload failed: Build successfully submitted ... same error.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-384962889

[sssd PR#556][comment] COVERITY: Add coverity support

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
How can we access coverity result? I don't see any link.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-384975200

[sssd PR#556][comment] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
@pbrezina, I have double checked it and it does **not** seem to be an issue.
Take a look at: https://scan.coverity.com/projects/sssd-sssd (and, please, ask to be added
to the project ... all SSSD developers should do the same) ... last build was uploaded
Yesterday (when I did the test).

So, the patches are working without any issue.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-385157752

[sssd PR#556][comment] COVERITY: Add coverity support

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
Ok, I requested access.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-385371607

[sssd PR#556][comment] COVERITY: Add coverity support

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

jhrozek commented:
"""
Thank you for the answers, ack.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-389140309

[sssd PR#556][+Accepted] COVERITY: Add coverity support

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

Label: +Accepted

[sssd PR#556][comment] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
master:
 28436b5

I'd also backport this patch to the stable branches, but I'd do that after we do
the releases we need.
Does that sound okay, @jhrozek?
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-389379825

[sssd PR#556][closed] COVERITY: Add coverity support

[fidencio]

   URL: https://github.com/SSSD/sssd/pull/556
Author: fidencio
 Title: #556: COVERITY: Add coverity support
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/556/head:pr556
git checkout pr556

[sssd PR#556][-Accepted] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

Label: -Accepted

[sssd PR#556][+Pushed] COVERITY: Add coverity support

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

Label: +Pushed

[sssd PR#556][comment] COVERITY: Add coverity support

[pbrezina]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
I'm missing some readme/link to documentation on how to use this. Fabiano, can you
write some doc please? Maybe just as a simple comment to the travis yml.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-389469553

[sssd PR#556][comment] COVERITY: Add coverity support

[sgallagher]

  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

sgallagher commented:
"""
@pbrezina It's automatic after a push to the master branch. Since the
scan.coverity.com instance is somewhat simplified, it really needs to be just a view of
what the public master looks like, not work in progress or PRs (because it will throw off
the visible metrics). Also, it's limited to only a few scans per-day, so allowing it
on PRs would quickly use that up.
"""

See the full comment at https://github.com/SSSD/sssd/pull/556#issuecomment-389524960