[PATCH] ELAPI: fix varargs call, update unit tests

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Fix another crash I noticed while integrating ELAPI..the
set_default_template functions has variable number of arguments and uses
E_EOARGS as sentinel. The call of set_default_template used in
get_default_template did not use any variable arguments, resulting in crash.

Also notes that the sentinel is a must instead of should in header file
(looking at process_arg_list() there is no other way to quit the
while(1) loop)

Update unit tests with two tests that stress this bug and the one in
elapi_init() fixed yesterday.

Jakub
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqySmYACgkQHsardTLnvCUnTACePgtJI97BGf2bPw6yMcoxBgdP
> cU4AoMzgSVoJd6BteJ6m3rammQAF/ycI
> =w2Lj
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/17/2009 10:40 AM, Jakub Hrozek wrote:
> Fix another crash I noticed while integrating ELAPI..the
> set_default_template functions has variable number of arguments and uses
> E_EOARGS as sentinel. The call of set_default_template used in
> get_default_template did not use any variable arguments, resulting in crash.
>
> Also notes that the sentinel is a must instead of should in header file
> (looking at process_arg_list() there is no other way to quit the
> while(1) loop)
>
> Update unit tests with two tests that stress this bug and the one in
> elapi_init() fixed yesterday.
>
> Jakub

Ack, but not pushing without a secondary Ack from Dmitri.

- ------------------------------------------------------------------------

_______________________________________________
sssd-devel mailing list
[e-mail]
https://fedorahosted.org/mailman/listinfo/sssd-devel

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkqyd30ACgkQeiVVYja6o6N23ACeItg7GYNzeobI6GccFuDVnSx3
> LvwAn10jE4TmEBJsvZzwNQha9qjHceCc
> =Gf81
> -----END PGP SIGNATURE-----

[Dmitri Pal]

Stephen Gallagher wrote:
> On 09/17/2009 10:40 AM, Jakub Hrozek wrote:
> > Fix another crash I noticed while integrating ELAPI..the
> > set_default_template functions has variable number of arguments and uses
> > E_EOARGS as sentinel. The call of set_default_template used in
> > get_default_template did not use any variable arguments, resulting
>
> in crash.
> > Also notes that the sentinel is a must instead of should in header file
> > (looking at process_arg_list() there is no other way to quit the
> > while(1) loop)
> > Update unit tests with two tests that stress this bug and the one in
> > elapi_init() fixed yesterday.
> > Jakub
>
> Ack, but not pushing without a secondary Ack from Dmitri.

Great catch!
Ack.
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

_______________________________________________
sssd-devel mailing list
[e-mail]
https://fedorahosted.org/mailman/listinfo/sssd-devel

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/18/2009 01:52 PM, Dmitri Pal wrote:
> Stephen Gallagher wrote:
> > On 09/17/2009 10:40 AM, Jakub Hrozek wrote:
> > > Fix another crash I noticed while integrating ELAPI..the
> > > set_default_template functions has variable number of arguments and uses
> > > E_EOARGS as sentinel. The call of set_default_template used in
> > > get_default_template did not use any variable arguments, resulting
> >
> > in crash.
> > > Also notes that the sentinel is a must instead of should in header file
> > > (looking at process_arg_list() there is no other way to quit the
> > > while(1) loop)
> > > Update unit tests with two tests that stress this bug and the one in
> > > elapi_init() fixed yesterday.
> > > Jakub
> >
> > Ack, but not pushing without a secondary Ack from Dmitri.
>
> Great catch!
> Ack.
> > sssd-devel mailing list
> > [e-mail]
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
>
> sssd-devel mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkq3j3cACgkQeiVVYja6o6PJ3wCfQJ/BEdMTWszBGfbykWHzGer7
> HFUAn2B1GnmWj4axh1gsPNNHCiTbw05s
> =oWcA
> -----END PGP SIGNATURE-----