[sssd PR#286][opened] I found two Coverity warnings in the current master while looking for another issue.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/286
Author: jhrozek
 Title: #286: I found two Coverity warnings in the current master while looking for another issue.
Action: opened

PR body:
"""
IPA: Return from function after marking a request as finished

Fixes:
    Error: UNINIT (CWE-457):
    sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:782: var_decl: Declaring variable "ret" without initializer.
    sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:1001: uninit_use: Using uninitialized value "ret".
    #  999|                   name = NULL;
    # 1000|                   fq_name = NULL;
    # 1001|->                 if (ret != EOK) {
    # 1002|                       DEBUG(SSSDBG_OP_FAILURE, "add_to_name_list failed.\n");
    # 1003|                       goto done;

IPA: Avoid using uninitialized ret value when skipping entries from the joined domain

Fixes:
   Error: FORWARD_NULL (CWE-476):
   sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:2659: var_compare_op: Comparing "state->attrs" to null implies that "state->attrs" might be null.
   sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:2668: var_deref_op: Dereferencing null pointer "state->attrs".
   # 2666|       }
   # 2667|   
   # 2668|->     ret = sysdb_attrs_get_string(state->attrs->sysdb_attrs, SYSDB_SID_STR,
   # 2669|                                    &sid_str);
   # 2670|       if (ret == ENOENT) {
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/286/head:pr286
git checkout pr286

[sssd PR#286][comment] I found two Coverity warnings in the current master while looking for another issue.

[fidencio]

URL: https://github.com/SSSD/sssd/pull/286
Title: #286: I found two Coverity warnings in the current master while looking for another issue.

fidencio commented:
"""
Both patches look fine.
Please, feel free to push them after you have the CI results.
"""

See the full comment at https://github.com/SSSD/sssd/pull/286#issuecomment-303848545

[sssd PR#286][+Accepted] I found two Coverity warnings in the current master while looking for another issue.

[fidencio]

URL: https://github.com/SSSD/sssd/pull/286
Title: #286: I found two Coverity warnings in the current master while looking for another issue.

Label: +Accepted

[sssd PR#286][comment] I found two Coverity warnings in the current master while looking for another issue.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/286
Title: #286: I found two Coverity warnings in the current master while looking for another issue.

jhrozek commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/70/02/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/286#issuecomment-303941279

[sssd PR#286][edited] I found two Coverity warnings in the current master while looking for another issue.

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/286
Author: jhrozek
 Title: #286: I found two Coverity warnings in the current master while looking for another issue.
Action: edited

Changed field: body
Original value:
"""
IPA: Return from function after marking a request as finished

Fixes:
    Error: UNINIT (CWE-457):
    sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:782: var_decl: Declaring variable "ret" without initializer.
    sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:1001: uninit_use: Using uninitialized value "ret".
    #  999|                   name = NULL;
    # 1000|                   fq_name = NULL;
    # 1001|->                 if (ret != EOK) {
    # 1002|                       DEBUG(SSSDBG_OP_FAILURE, "add_to_name_list failed.\n");
    # 1003|                       goto done;

IPA: Avoid using uninitialized ret value when skipping entries from the joined domain

Fixes:
   Error: FORWARD_NULL (CWE-476):
   sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:2659: var_compare_op: Comparing "state->attrs" to null implies that "state->attrs" might be null.
   sssd-1.15.3/src/providers/ipa/ipa_s2n_exop.c:2668: var_deref_op: Dereferencing null pointer "state->attrs".
   # 2666|       }
   # 2667|   
   # 2668|->     ret = sysdb_attrs_get_string(state->attrs->sysdb_attrs, SYSDB_SID_STR,
   # 2669|                                    &sid_str);
   # 2670|       if (ret == ENOENT) {
"""

[sssd PR#286][comment] I found two Coverity warnings in the current master while looking for another issue.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/286
Title: #286: I found two Coverity warnings in the current master while looking for another issue.

lslebodn commented:
"""
master:
* eb404bcdbbff7e080a93d816e17b8cec04f79fc4
* 3e3034199b44e01899ec7ba8152fef3738a0e093
"""

See the full comment at https://github.com/SSSD/sssd/pull/286#issuecomment-303988122

[sssd PR#286][closed] I found two Coverity warnings in the current master while looking for another issue.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/286
Author: jhrozek
 Title: #286: I found two Coverity warnings in the current master while looking for another issue.
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/286/head:pr286
git checkout pr286

[sssd PR#286][+Pushed] I found two Coverity warnings in the current master while looking for another issue.

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/286
Title: #286: I found two Coverity warnings in the current master while looking for another issue.

Label: +Pushed