3:54 a.m.
URL: https://github.com/SSSD/sssd/pull/359
Author: jhrozek
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Action: opened
PR body:
"""
If the domain_type parameter contained an invalid value, the error branch
wouldn't have set the 'ret' parameter to an error condition, which might
crash sssd.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/359/head:pr359
git checkout pr359
7:08 a.m.
New subject: [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
fidencio commented:
"""
Patch looks good and I'll add the "Accepted" label as soon as I get the
result from our internal CI.
"""
See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-325643588
11:57 a.m.
New subject: [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
fidencio commented:
"""
CI failed due to https://pagure.io/SSSD/sssd/issue/2854, which is not related to this
patch.
http://vm-058-233.${abc}/logs/job/74/70/summary.html
ACK!
"""
See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-325727547
11:57 a.m.
New subject: [sssd PR#359][+Accepted] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: +Accepted
3:04 p.m.
New subject: [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
lslebodn commented:
"""
The same problem is in `CONFDB_DOMAIN_CASE_SENSITIVE`
"""
See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-325783670
3:04 p.m.
New subject: [sssd PR#359][-Accepted] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: -Accepted
3:04 p.m.
New subject: [sssd PR#359][+Changes requested] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: +Changes requested
12:49 a.m.
New subject: [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
fidencio commented:
"""
Hmm. Nice catch. @lslebodn.
@jhrozek:
```
diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
index 039d0fd8d..1db5a4862 100644
--- a/src/confdb/confdb.c
+++ b/src/confdb/confdb.c
@@ -1345,6 +1345,7 @@ static int confdb_get_domain_internal(struct confdb_ctx *cdb,
} else {
DEBUG(SSSDBG_FATAL_FAILURE,
"Invalid value for %s\n", CONFDB_DOMAIN_CASE_SENSITIVE);
+ ret = EINVAL;
goto done;
}
} else {
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-325888656
2:55 p.m.
New subject: [sssd PR#359][synchronized] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Author: jhrozek
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/359/head:pr359
git checkout pr359
2:55 p.m.
New subject: [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
jhrozek commented:
"""
new patch pushed
"""
See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-326101033
2:55 p.m.
New subject: [sssd PR#359][-Changes requested] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: -Changes requested
2:56 p.m.
New subject: [sssd PR#359][synchronized] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Author: jhrozek
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/359/head:pr359
git checkout pr359
4:50 p.m.
New subject: [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
fidencio commented:
"""
ACK from me as it also addresses @lslebodn's comments.
"""
See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-326129417
4:50 p.m.
New subject: [sssd PR#359][+Accepted] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: +Accepted
5:10 a.m.
New subject: [sssd PR#359][comment] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
jhrozek commented:
"""
* master: 9787bc5890865be73a6caedaa22b3fae1e3aa671
"""
See the full comment at https://github.com/SSSD/sssd/pull/359#issuecomment-326251981
5:10 a.m.
New subject: [sssd PR#359][closed] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Author: jhrozek
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/359/head:pr359
git checkout pr359
5:10 a.m.
New subject: [sssd PR#359][+Pushed] CONFDB: Do not crash with an invalid domain_type value
URL: https://github.com/SSSD/sssd/pull/359
Title: #359: CONFDB: Do not crash with an invalid domain_type value
Label: +Pushed
2428
days inactive
2430
days old
sssd-devel@lists.fedorahosted.org
16 comments
3 participants
participants (3)
-
fidencio -
jhrozek
-
lslebodn