9:06 a.m.
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: opened
PR body:
"""
This compensates for "forgotten" endXYent() calls during the same session,
as observed with Dovecot authd.
Patch co-authored by Sumit Bose.
XY: setpwent(), setgrent(), setsvcent()
This would fix https://github.com/SSSD/sssd/issues/5523
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
9:43 a.m.
New subject: [sssd PR#5524][synchronized] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
9:46 a.m.
New subject: [sssd PR#5524][synchronized] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
9:49 a.m.
New subject: [sssd PR#5524][synchronized] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
11:03 a.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
PR tested and verified, more detailed description in main issue:
https://github.com/SSSD/sssd/issues/5523
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-794168200
11:09 a.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
My only comment is that maybe those commits should be squashed together in a single
commit. All those changes refer to a single file. Each change touches different logical
module but basically fixes the same thing everywhere.
@pbrezina can you please advise here?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-794175159
2:39 p.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
HeikoSchlittermann commented:
"""
@elkoniu If this would be my own project, I probably would squash the three commits into a
single one, or split them even more, to have a single commit for each of the affected
modules.
In case of a squashed commit: if this squashed commit is spotted as introducing a bug, it
should be easy to determine which of the squashed changes actually introduced the bug.
And, if the current solution introduced a bug, then the bug is likely introduced in all
touched modules, and having them in a single commit avoids forgetting the other modules.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-794424949
5:54 p.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
@HeikoSchlittermann Lets agree to squash all those commits into single one. In commit
message please list all affected functions the same way you did it in 3 existing commits.
Description of issue you created [1] very well explains what the problem is so maybe it is
a good idea to include it in commit message too.
[1] https://github.com/SSSD/sssd/issues/5523
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-794624259
3:47 a.m.
New subject: [sssd PR#5524][synchronized] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
7:03 a.m.
New subject: [sssd PR#5524][+Accepted] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: +Accepted
11:05 a.m.
New subject: [sssd PR#5524][+Accepted] Fix setXYent(): rewind always
elkoniu <sssd-github-notification(a)fedorahosted.org> (Mo 15 Mär 2021 13:03:38 CET):
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: +Accepted
Thank you.
--
Heiko
6:55 a.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
pbrezina commented:
"""
@HeikoSchlittermann Can you please amend the commit message with:
```
Resolves: https://github.com/SSSD/sssd/issues/5523
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-800195072
8:08 a.m.
New subject: [sssd PR#5524][+Changes requested] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: +Changes requested
8:08 a.m.
New subject: [sssd PR#5524][-Accepted] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: -Accepted
6:16 p.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
@HeikoSchlittermann Ping from my side. If you will be able add missing line to commit
message there is a chance to merge this PR quite soon and close corresponding issue.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-802376480
2:16 a.m.
New subject: [sssd PR#5524][synchronized] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
6:47 p.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
Hi @HeikoSchlittermann , thank you for the update. I am afraid it may not be the final one
:)
Our contribution policies [1] requires right information order in commit message body, for
reference:
https://github.com/SSSD/sssd/pull/5494/commits/c15cd84dd151d084dda7d176d8...
Commit message order is:
- one line of title with affected module name
- empty line
- comment section with explanation or any additional change details
- link section where you refer resolved issues / bugzillas
- signed-off section
Your commit message is excellent but information order is wrong, I guess what @pbrezina
means
in his comment [2] was to add "Resolved" part at the end of commit message.
I think correct tail of commit message should be:
```
Patch co-authored by Sumit Bose.
Resolves: #5523
```
[1] https://sssd.io/docs/developers/contribute.html
[2] https://github.com/SSSD/sssd/pull/5524#issuecomment-800195072
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-804472355
6:48 p.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
Hi @HeikoSchlittermann , thank you for the update. I am afraid it may not be the final one
:)
Our contribution policies [1] requires right information order in commit message body, for
reference:
https://github.com/SSSD/sssd/pull/5494/commits/c15cd84dd151d084dda7d176d8...
Commit message order is:
- one line of title with affected module name
- empty line
- comment section with explanation or any additional change details
- link section where you refer resolved issues / bugzillas
- signed-off section
Your commit message is excellent but information order is wrong, I guess what @pbrezina
means
in his comment [2] was to add "Resolved" part at the end of commit message.
I think correct tail of commit message should be:
```
Patch co-authored by Sumit Bose.
Resolves: #5523
```
[1] https://sssd.io/docs/developers/contribute.html
[2] https://github.com/SSSD/sssd/pull/5524#issuecomment-800195072
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-804472355
6:49 p.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
Hi @HeikoSchlittermann , thank you for the update. I am afraid it may not be the final one
:)
Our contribution policies [1] requires right information order in commit message body, for
reference:
https://github.com/SSSD/sssd/pull/5494/commits/c15cd84dd151d084dda7d176d8...
Commit message order is:
- one line of title with affected module name
- empty line
- comment section with explanation or any additional change details
- empty line
- signed-off section
- empty line
- link section where you refer resolved issues / bugzillas
Your commit message is excellent but information order is wrong, I guess what @pbrezina
means
in his comment [2] was to add "Resolved" part at the end of commit message.
I think correct tail of commit message should be:
```
Patch co-authored by Sumit Bose.
Resolves: #5523
```
[1] https://sssd.io/docs/developers/contribute.html
[2] https://github.com/SSSD/sssd/pull/5524#issuecomment-800195072
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-804472355
6:50 p.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
elkoniu commented:
"""
Hi @HeikoSchlittermann , thank you for the update. I am afraid it may not be the final one
:)
Our contribution policies [1] requires right information order in commit message body, for
reference:
https://github.com/SSSD/sssd/pull/5494/commits/c15cd84dd151d084dda7d176d8...
Commit message order is:
- one line of title with affected module name
- empty line
- comment section with explanation or any additional change details
- empty line
- signed-off section
- empty line
- link section where you refer resolved issues / bugzillas
Your commit message is excellent but information order is wrong, I guess what @pbrezina
means
in his comment [2] was to add "Resolved" part at the end of commit message.
I think correct tail of commit message in this case should be:
```
Patch co-authored by Sumit Bose.
Resolves: #5523
```
[1] https://sssd.io/docs/developers/contribute.html
[2] https://github.com/SSSD/sssd/pull/5524#issuecomment-800195072
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-804472355
4:53 a.m.
New subject: [sssd PR#5524][synchronized] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
4:54 a.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
HeikoSchlittermann commented:
"""
Hi @elkoniu , thanks for the info, I now rebased it onto the current master and changed
the commit message as you requested. Hopefully ;)
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-804768799
5:12 a.m.
New subject: [sssd PR#5524][-Changes requested] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: -Changes requested
5:12 a.m.
New subject: [sssd PR#5524][+Accepted] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: +Accepted
5:38 a.m.
New subject: [sssd PR#5524][+Ready to push] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: +Ready to push
5:41 a.m.
New subject: [sssd PR#5524][comment] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5524
* `master`
* 0e0951478d4d4b2b2a65b390bd9f749bbb9c9b2e - Fix setXYent(): rewind always
"""
See the full comment at https://github.com/SSSD/sssd/pull/5524#issuecomment-806544238
5:41 a.m.
New subject: [sssd PR#5524][+Pushed] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: +Pushed
5:41 a.m.
New subject: [sssd PR#5524][-Accepted] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: -Accepted
5:41 a.m.
New subject: [sssd PR#5524][-Ready to push] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Title: #5524: Fix setXYent(): rewind always
Label: -Ready to push
5:41 a.m.
New subject: [sssd PR#5524][closed] Fix setXYent(): rewind always
URL: https://github.com/SSSD/sssd/pull/5524
Author: HeikoSchlittermann
Title: #5524: Fix setXYent(): rewind always
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5524/head:pr5524
git checkout pr5524
1139
days inactive
1163
days old
sssd-devel@lists.fedorahosted.org
29 comments
4 participants
participants (4)
-
elkoniu -
Heiko Schlittermann -
HeikoSchlittermann
-
pbrezina