Fixes https://fedorahosted.org/sssd/ticket/1253
Previously, we were saving both the lower-cased alias names as well as the original capitalization. This was done in order to allow switching case-sensitive/insensitive modes safely, but it had the negative effect of producing duplicate alias entries (differing only by case) on maps like 'services' which have an 'aliases' field.
Jakub and I discussed it and we agreed that switching case-sensitivity should always warrant a cache-purge, as it's a fundamental change to the cache contents.
On 03/15/2012 09:02 PM, Stephen Gallagher wrote:
Fixes https://fedorahosted.org/sssd/ticket/1253
Previously, we were saving both the lower-cased alias names as well as the original capitalization. This was done in order to allow switching case-sensitive/insensitive modes safely, but it had the negative effect of producing duplicate alias entries (differing only by case) on maps like 'services' which have an 'aliases' field.
Jakub and I discussed it and we agreed that switching case-sensitivity should always warrant a cache-purge, as it's a fundamental change to the cache contents.
You forgot to attach the patch. :)
On Fri, 2012-03-16 at 08:48 +0100, Pavel Březina wrote:
On 03/15/2012 09:02 PM, Stephen Gallagher wrote:
Fixes https://fedorahosted.org/sssd/ticket/1253
Previously, we were saving both the lower-cased alias names as well as the original capitalization. This was done in order to allow switching case-sensitive/insensitive modes safely, but it had the negative effect of producing duplicate alias entries (differing only by case) on maps like 'services' which have an 'aliases' field.
Jakub and I discussed it and we agreed that switching case-sensitivity should always warrant a cache-purge, as it's a fundamental change to the cache contents.
You forgot to attach the patch. :)
So I did. Thanks.
On Fri, 2012-03-16 at 08:48 +0100, Pavel Březina wrote:
On 03/15/2012 09:02 PM, Stephen Gallagher wrote:
Fixes https://fedorahosted.org/sssd/ticket/1253
Previously, we were saving both the lower-cased alias names as well as the original capitalization. This was done in order to allow switching case-sensitive/insensitive modes safely, but it had the negative effect of producing duplicate alias entries (differing only by case) on maps like 'services' which have an 'aliases' field.
Jakub and I discussed it and we agreed that switching case-sensitivity should always warrant a cache-purge, as it's a fundamental change to the cache contents.
You forgot to attach the patch. :)
So I did. Thanks.
Just one small thing. For the sake of nice output when debugging, would it be possible to move the DEBUG line out of the for cycle?
Other than that the patch is fine
Thanks Jan
On Fri, 2012-03-16 at 15:28 +0100, Jan Zelený wrote:
On Fri, 2012-03-16 at 08:48 +0100, Pavel Březina wrote:
On 03/15/2012 09:02 PM, Stephen Gallagher wrote:
Fixes https://fedorahosted.org/sssd/ticket/1253
Previously, we were saving both the lower-cased alias names as well as the original capitalization. This was done in order to allow switching case-sensitive/insensitive modes safely, but it had the negative effect of producing duplicate alias entries (differing only by case) on maps like 'services' which have an 'aliases' field.
Jakub and I discussed it and we agreed that switching case-sensitivity should always warrant a cache-purge, as it's a fundamental change to the cache contents.
You forgot to attach the patch. :)
So I did. Thanks.
Just one small thing. For the sake of nice output when debugging, would it be possible to move the DEBUG line out of the for cycle?
Other than that the patch is fine
I moved the DEBUG message and pushed to master and sssd-1-8.
sssd-devel@lists.fedorahosted.org
-
Jan Zelený -
Pavel Březina -
Stephen Gallagher