[sssd PR#1016][opened] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Author: pbrezina
 Title: #1016: proxy: set pwfield to x for files library
Action: opened

PR body:
"""
Resolves:
https://pagure.io/SSSD/sssd/issue/4174
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1016/head:pr1016
git checkout pr1016

[sssd PR#1016][+Waiting for review] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: +Waiting for review

[sssd PR#1016][comment] proxy: set pwfield to x for files library

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

alexey-tikhonov commented:
"""
Code LGTM and works as expected / fixes reported issue (verified manually).

Coverity scan is clean.

But I have a question.
There are a number of other "overrides" in `confdb.c` that depend on `is_files_provider(domain)`.
Should not we apply those to proxy:files as well?

"""

See the full comment at https://github.com/SSSD/sssd/pull/1016#issuecomment-607522961

[sssd PR#1016][-Waiting for review] proxy: set pwfield to x for files library

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: -Waiting for review

[sssd PR#1016][synchronized] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Author: pbrezina
 Title: #1016: proxy: set pwfield to x for files library
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1016/head:pr1016
git checkout pr1016

[sssd PR#1016][comment] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

pbrezina commented:
"""
I switched to `strcasecmp`. I checkd the other cases were `is_files_provider` was used but those special cases should be really used only for a files provider. It is special in the way that it is enabled implicitly and it needs to really return what is in files. Proxy provider can be enabled only explicitly so we can rely on its configuration.
"""

See the full comment at https://github.com/SSSD/sssd/pull/1016#issuecomment-608373363

[sssd PR#1016][+Waiting for review] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: +Waiting for review

[sssd PR#1016][comment] proxy: set pwfield to x for files library

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

alexey-tikhonov commented:
"""
Thank you. ACK.
"""

See the full comment at https://github.com/SSSD/sssd/pull/1016#issuecomment-608543187

[sssd PR#1016][-Waiting for review] proxy: set pwfield to x for files library

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: -Waiting for review

[sssd PR#1016][+Accepted] proxy: set pwfield to x for files library

[alexey-tikhonov]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: +Accepted

[sssd PR#1016][+Ready to push] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: +Ready to push

[sssd PR#1016][comment] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

pbrezina commented:
"""
* `master`
    * ae5a2cdccadae3de29680466c05637b51b113147 - proxy: set pwfield to x for files library

"""

See the full comment at https://github.com/SSSD/sssd/pull/1016#issuecomment-609700093

[sssd PR#1016][-Ready to push] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: -Ready to push

[sssd PR#1016][-Accepted] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: -Accepted

[sssd PR#1016][closed] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Author: pbrezina
 Title: #1016: proxy: set pwfield to x for files library
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1016/head:pr1016
git checkout pr1016

[sssd PR#1016][+Pushed] proxy: set pwfield to x for files library

[pbrezina]

URL: https://github.com/SSSD/sssd/pull/1016
Title: #1016: proxy: set pwfield to x for files library

Label: +Pushed