[PATCH] sudo: allow specifying only one time restriction

[Pavel Březina]

https://fedorahosted.org/sssd/ticket/2100

[Jakub Hrozek]

On Fri, Sep 27, 2013 at 03:07:07PM +0200, Pavel Březina wrote:
> https://fedorahosted.org/sssd/ticket/2100
> From ed747cd79bcb649fd68885c74565d94e31c27997 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
> Date: Fri, 27 Sep 2013 14:49:49 +0200
> Subject: [PATCH] sudo: allow specifying only one time restriction

ACK. I'm just wondering if it makes sense to add some tracing
DEBUG statements when we're touching the function now?

[Pavel Březina]

On 09/30/2013 08:16 PM, Jakub Hrozek wrote:
> On Fri, Sep 27, 2013 at 03:07:07PM +0200, Pavel Březina wrote:
> > https://fedorahosted.org/sssd/ticket/2100
> > From ed747cd79bcb649fd68885c74565d94e31c27997 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
> > Date: Fri, 27 Sep 2013 14:49:49 +0200
> > Subject: [PATCH] sudo: allow specifying only one time restriction
>
> ACK. I'm just wondering if it makes sense to add some tracing
> DEBUG statements when we're touching the function now?

Yeah, that's probably a good idea. Patch is attached.

[Jakub Hrozek]

On Tue, Oct 01, 2013 at 01:47:22PM +0200, Pavel Březina wrote:
> On 09/30/2013 08:16 PM, Jakub Hrozek wrote:
> > On Fri, Sep 27, 2013 at 03:07:07PM +0200, Pavel Březina wrote:
> > > https://fedorahosted.org/sssd/ticket/2100
> > > From ed747cd79bcb649fd68885c74565d94e31c27997 Mon Sep 17 00:00:00 2001
> > > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
> > > Date: Fri, 27 Sep 2013 14:49:49 +0200
> > > Subject: [PATCH] sudo: allow specifying only one time restriction
> >
> > ACK. I'm just wondering if it makes sense to add some tracing
> > DEBUG statements when we're touching the function now?
>
> Yeah, that's probably a good idea. Patch is attached.

ACK to both.

[Jakub Hrozek]

On Tue, Oct 01, 2013 at 06:16:10PM +0200, Jakub Hrozek wrote:
> On Tue, Oct 01, 2013 at 01:47:22PM +0200, Pavel Březina wrote:
> > On 09/30/2013 08:16 PM, Jakub Hrozek wrote:
> > > On Fri, Sep 27, 2013 at 03:07:07PM +0200, Pavel Březina wrote:
> > > > https://fedorahosted.org/sssd/ticket/2100
> > > > From ed747cd79bcb649fd68885c74565d94e31c27997 Mon Sep 17 00:00:00 2001
> > > > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
> > > > Date: Fri, 27 Sep 2013 14:49:49 +0200
> > > > Subject: [PATCH] sudo: allow specifying only one time restriction
> > >
> > > ACK. I'm just wondering if it makes sense to add some tracing
> > > DEBUG statements when we're touching the function now?
> >
> > Yeah, that's probably a good idea. Patch is attached.
>
> ACK to both.

Pushed to master and sssd-1-11

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/01/2013 07:47 AM, Pavel Březina wrote:
> On 09/30/2013 08:16 PM, Jakub Hrozek wrote:
> > On Fri, Sep 27, 2013 at 03:07:07PM +0200, Pavel Březina wrote:
> > > https://fedorahosted.org/sssd/ticket/2100
> > > From ed747cd79bcb649fd68885c74565d94e31c27997 Mon Sep 17
> > > 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
> > >  Date: Fri, 27 Sep 2013 14:49:49 +0200 
> > > Subject: [PATCH] sudo: allow specifying only one time
> > > restriction
> >
> > ACK. I'm just wondering if it makes sense to add some tracing 
> > DEBUG statements when we're touching the function now?
>
> Yeah, that's probably a good idea. Patch is attached.

Patch 2 has a bug in it that Coverity caught[1]. Fix attached.

Coverity Issue #12031
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.14 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iEYEARECAAYFAlJOt40ACgkQeiVVYja6o6MZYQCdGR87ijnBJO7DbSkV4km94Sw6
> dbkAoKVI0TMraCODksue5wIgm96CgKdV
> =6oEX
> -----END PGP SIGNATURE-----

[Pavel Březina]

On 10/04/2013 02:41 PM, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/01/2013 07:47 AM, Pavel Březina wrote:
> > On 09/30/2013 08:16 PM, Jakub Hrozek wrote:
> > > On Fri, Sep 27, 2013 at 03:07:07PM +0200, Pavel Březina wrote:
> > > > https://fedorahosted.org/sssd/ticket/2100
> > > > From ed747cd79bcb649fd68885c74565d94e31c27997 Mon Sep 17
> > > > 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
> > > >  Date: Fri, 27 Sep 2013 14:49:49 +0200
> > > > Subject: [PATCH] sudo: allow specifying only one time
> > > > restriction
> > >
> > > ACK. I'm just wondering if it makes sense to add some tracing
> > > DEBUG statements when we're touching the function now?
> >
> > Yeah, that's probably a good idea. Patch is attached.
>
> Patch 2 has a bug in it that Coverity caught[1]. Fix attached.
>
> Coverity Issue #12031

Obvious ack. Thanks Coverity!

http://i1183.photobucket.com/albums/x470/bintangtimurfull/Facepalm/3Triplefa...

[Jakub Hrozek]

On Fri, Oct 04, 2013 at 02:49:55PM +0200, Pavel Březina wrote:
> On 10/04/2013 02:41 PM, Stephen Gallagher wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 10/01/2013 07:47 AM, Pavel Březina wrote:
> > > On 09/30/2013 08:16 PM, Jakub Hrozek wrote:
> > > > On Fri, Sep 27, 2013 at 03:07:07PM +0200, Pavel Březina wrote:
> > > > > https://fedorahosted.org/sssd/ticket/2100
> > > > > From ed747cd79bcb649fd68885c74565d94e31c27997 Mon Sep 17
> > > > > 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
> > > > >  Date: Fri, 27 Sep 2013 14:49:49 +0200
> > > > > Subject: [PATCH] sudo: allow specifying only one time
> > > > > restriction
> > > >
> > > > ACK. I'm just wondering if it makes sense to add some tracing
> > > > DEBUG statements when we're touching the function now?
> > >
> > > Yeah, that's probably a good idea. Patch is attached.
> >
> > Patch 2 has a bug in it that Coverity caught[1]. Fix attached.
> >
> > Coverity Issue #12031
>
> Obvious ack. Thanks Coverity!
>
> http://i1183.photobucket.com/albums/x470/bintangtimurfull/Facepalm/3Triplefa...

Well, good thing it's just a debug message, I didn't catch it during
review either.

Pushed to master and sssd-1-11