[PATCH] SDAP: Remove unused function

[Jakub Hrozek]

Unused code is broken code, remove it :)

[Pavel Reichl]

On 09/02/2015 04:16 PM, Jakub Hrozek wrote:
> Unused code is broken code, remove it :)
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Should we improve comment in remove_ldap_connection_callbacks() which 
mentions sdap_mark_offline()?

[Pavel Reichl]

On 09/02/2015 04:21 PM, Pavel Reichl wrote:
> On 09/02/2015 04:16 PM, Jakub Hrozek wrote:
> > Unused code is broken code, remove it :)
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
> Should we improve comment in remove_ldap_connection_callbacks() which mentions sdap_mark_offline()?
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

OK, I don't want to stall the patch.

CI passed (with exception of unrelated issues on rawhide):
http://sssd-ci.duckdns.org/logs/job/24/38/summary.html

ACK

[Jakub Hrozek]

On Fri, Sep 04, 2015 at 03:12:06PM +0200, Pavel Reichl wrote:
> On 09/02/2015 04:21 PM, Pavel Reichl wrote:
> > On 09/02/2015 04:16 PM, Jakub Hrozek wrote:
> > > Unused code is broken code, remove it :)
> > >
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >
> > Should we improve comment in remove_ldap_connection_callbacks() which mentions sdap_mark_offline()?
> > _______________________________________________
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
> OK, I don't want to stall the patch.
>
> CI passed (with exception of unrelated issues on rawhide):
> http://sssd-ci.duckdns.org/logs/job/24/38/summary.html
>
> ACK

No, you were right the first time, I just didn't have time to respin the
patch. New one is attached.

[Pavel Reichl]

On 09/08/2015 05:41 PM, Jakub Hrozek wrote:
> On Fri, Sep 04, 2015 at 03:12:06PM +0200, Pavel Reichl wrote:
> > On 09/02/2015 04:21 PM, Pavel Reichl wrote:
> > > On 09/02/2015 04:16 PM, Jakub Hrozek wrote:
> > > > Unused code is broken code, remove it :)
> > > >
> > > > sssd-devel mailing list
> > > > [e-mail]
> > > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > >
> > > Should we improve comment in remove_ldap_connection_callbacks() which mentions sdap_mark_offline()?
> > > _______________________________________________
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >
> > OK, I don't want to stall the patch.
> >
> > CI passed (with exception of unrelated issues on rawhide):
> > http://sssd-ci.duckdns.org/logs/job/24/38/summary.html
> >
> > ACK
>
> No, you were right the first time, I just didn't have time to respin the
> patch. New one is attached.

OK, thanks.

ci passed: http://sssd-ci.duckdns.org/logs/job/25/63/summary.html
ACK

[Jakub Hrozek]

On Wed, Sep 09, 2015 at 12:19:28PM +0200, Pavel Reichl wrote:
> On 09/08/2015 05:41 PM, Jakub Hrozek wrote:
> > On Fri, Sep 04, 2015 at 03:12:06PM +0200, Pavel Reichl wrote:
> > > On 09/02/2015 04:21 PM, Pavel Reichl wrote:
> > > > On 09/02/2015 04:16 PM, Jakub Hrozek wrote:
> > > > > Unused code is broken code, remove it :)
> > > > >
> > > > > sssd-devel mailing list
> > > > > [e-mail]
> > > > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > > >
> > > > Should we improve comment in remove_ldap_connection_callbacks() which mentions sdap_mark_offline()?
> > > > _______________________________________________
> > > > sssd-devel mailing list
> > > > [e-mail]
> > > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > >
> > > OK, I don't want to stall the patch.
> > >
> > > CI passed (with exception of unrelated issues on rawhide):
> > > http://sssd-ci.duckdns.org/logs/job/24/38/summary.html
> > >
> > > ACK
> >
> > No, you were right the first time, I just didn't have time to respin the
> > patch. New one is attached.
>
> OK, thanks.
>
> ci passed: http://sssd-ci.duckdns.org/logs/job/25/63/summary.html
> ACK

* master: 63fb0857378c450d9806b1a3c6bb5657f00a8ba1