[PATCH] libipa_hbac cleanup patches

[Jakub Hrozek]

Hi,

attached are patches that in my opinion make libipa_hbac easier to use
by external projects like pam_hbac.

[PATCH 1/4] libipa_hbac: Do not use C99
- even though we use C99 in the deamon, pam_hbac needs to run on very
  exotic platforms. I don't think the code readability is decreased too
  much

[PATCH 2/4] libipa_hbac: Add more debug messages
- just adds debug messages

[PATCH 3/4] libipa_hbac: Fix typo in constant name
- fixes a typo that breaks compilation on non-GNU systems

[PATCH 4/4] libipa_hbac: Move the library to src/lib/ipa_hbac
- This might be a bit controversial, but in my opinion a library
  shouldn't be present in the provider subdirectory. Please also note
  I added "I$(top_srcdir)/src/util", this is just so that I can copy the
  libipa_hbac code without any changes to pam_hbac (even changes to
  header file locations..)

[Lukas Slebodnik]

On (10/03/16 11:54), Jakub Hrozek wrote:
> Hi,
>
> attached are patches that in my opinion make libipa_hbac easier to use
> by external projects like pam_hbac.
>
> [PATCH 1/4] libipa_hbac: Do not use C99
> - even though we use C99 in the deamon, pam_hbac needs to run on very
>   exotic platforms. I don't think the code readability is decreased too
>   much
>
> [PATCH 2/4] libipa_hbac: Add more debug messages
> - just adds debug messages
>
> [PATCH 3/4] libipa_hbac: Fix typo in constant name
> - fixes a typo that breaks compilation on non-GNU systems
>
> [PATCH 4/4] libipa_hbac: Move the library to src/lib/ipa_hbac
> - This might be a bit controversial, but in my opinion a library
>   shouldn't be present in the provider subdirectory. Please also note
>   I added "I$(top_srcdir)/src/util", this is just so that I can copy the
>   libipa_hbac code without any changes to pam_hbac (even changes to
>   header file locations..) 
> From 3ae3c1fba3e14d3299b121c03c166489fba55741 Mon Sep 17 00:00:00
> 2001
> From: Jakub Hrozek <jhrozek(a)redhat.com&gt;
> Date: Mon, 22 Feb 2016 09:44:19 +0100
> Subject: [PATCH 1/4] libipa_hbac: Do not use C99
>
> libipa_hbac can be used by external consumers like pam_hbac who run on
> old platforms that do not support C99. Refrain from using C99 features
> in that codebase.
> ---
>  src/providers/ipa/hbac_evaluator.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/src/providers/ipa/hbac_evaluator.c b/src/providers/ipa/hbac_evaluator.c
> index f4b76d8e6ca3b63b092f65cdb4aac9e98e8c717e..36376abb4eb834681cf62030c2bc1ba11e1369ce
> 100644
> --- a/src/providers/ipa/hbac_evaluator.c
> +++ b/src/providers/ipa/hbac_evaluator.c
> @@ -146,6 +146,8 @@ enum hbac_eval_result hbac_evaluate(struct hbac_rule **rules,
>                                      struct hbac_eval_req *hbac_req,
>                                      struct hbac_info **info)
>  {
> +    uint32_t i;
> +
>      enum hbac_error_code ret;
>      enum hbac_eval_result result = HBAC_EVAL_DENY;
>      enum hbac_eval_result_int intermediate_result;
> @@ -163,7 +165,7 @@ enum hbac_eval_result hbac_evaluate(struct hbac_rule **rules,
>          (*info)->rule_name = NULL;
>      }
>  
> -    for (uint32_t i = 0; rules[i]; i++) {
> +    for (i = 0; rules[i]; i++) {
>          hbac_rule_debug_print(rules[i]);
>          intermediate_result = hbac_evaluate_rule(rules[i], hbac_req, &ret);
>          if (intermediate_result == HBAC_EVAL_UNMATCHED) {
> @@ -381,6 +383,8 @@ const char *hbac_error_string(enum hbac_error_code code)
>  static void hbac_request_element_debug_print(struct hbac_request_element *el,
>                                               const char *label)
>  {
> +    int i;
> +
>      if (el) {
>          if (el->name) {
>              HBAC_DEBUG(HBAC_DBG_TRACE, "\t\t%s [%s]\n", label, el->name);
> @@ -389,7 +393,7 @@ static void hbac_request_element_debug_print(struct
> hbac_request_element *el,
>          if (el->groups) {
>              if (el->groups[0]) {
>                  HBAC_DEBUG(HBAC_DBG_TRACE, "\t\t%s_group:\n", label);
> -                for (int i = 0; el->groups[i]; i++) {
> +                for (i = 0; el->groups[i]; i++) {
>                      HBAC_DEBUG(HBAC_DBG_TRACE, "\t\t\t[%s]\n",
> el->groups[i]);
>                  }
>              } else {
> @@ -434,6 +438,8 @@ static void hbac_req_debug_print(struct hbac_eval_req *req)
>  static void hbac_rule_element_debug_print(struct hbac_rule_element *el,
>                                            const char *label)
>  {
> +    int i;
> +
>      if (el) {
>          HBAC_DEBUG(HBAC_DBG_TRACE, "\t\tcategory [%#x] [%s]\n",
> el->category,
>                     (el->category == HBAC_CATEGORY_ALL) ? "ALL" :
> "NONE");
> @@ -441,7 +447,7 @@ static void hbac_rule_element_debug_print(struct hbac_rule_element
> *el,
>          if (el->names) {
>              if (el->names[0]) {
>                  HBAC_DEBUG(HBAC_DBG_TRACE, "\t\t%s_names:\n", label);
> -                for (int i = 0; el->names[i]; i++) {
> +                for (i = 0; el->names[i]; i++) {
>                      HBAC_DEBUG(HBAC_DBG_TRACE, "\t\t\t[%s]\n",
> el->names[i]);
>                  }
>              } else {
> @@ -452,7 +458,7 @@ static void hbac_rule_element_debug_print(struct hbac_rule_element
> *el,
>          if (el->groups) {
>              if (el->groups[0]) {
>                  HBAC_DEBUG(HBAC_DBG_TRACE, "\t\t%s_groups:\n", label);
> -                for (int i = 0; el->groups[i]; i++) {
> +                for (i = 0; el->groups[i]; i++) {
>                      HBAC_DEBUG(HBAC_DBG_TRACE, "\t\t\t[%s]\n",
> el->groups[i]);
>                  }
>              } else { 
LGTM but it would be good to enforce old standard with compiler flags.
@see POC in attached diff.

> From 58bf614791539f407495a4b09cb4cccc0bf1f51f Mon Sep 17 00:00:00
> 2001
> From: Jakub Hrozek <jhrozek(a)redhat.com&gt;
> Date: Thu, 10 Mar 2016 07:38:06 +0100
> Subject: [PATCH 2/4] libipa_hbac: Add more debug messages
>
> Adding more debug messages proved to be useful during pam_hbac
> development.
> ---
>  src/providers/ipa/hbac_evaluator.c | 22 +++++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)
>  
ACK

> From 36496d9b8b7850baab9d8c67f35e5d699379c0a6 Mon Sep 17 00:00:00
> 2001
> From: Jakub Hrozek <jhrozek(a)redhat.com&gt;
> Date: Thu, 10 Mar 2016 07:45:28 +0100
> Subject: [PATCH 3/4] libipa_hbac: Fix typo in constant name
>
> On platforms without the format attribute, libhbac could not be
> compiled.
> ---
>  src/providers/ipa/ipa_hbac.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/providers/ipa/ipa_hbac.h b/src/providers/ipa/ipa_hbac.h
> index ee5f1919b0e216bd6dc09e26b1488fc4bf2d28ef..22dd8ffc401d2e6a2b6e4f83e99447b50192102b
> 100644
> --- a/src/providers/ipa/ipa_hbac.h
> +++ b/src/providers/ipa/ipa_hbac.h
> @@ -53,7 +53,7 @@ enum hbac_debug_level {
>  #ifdef HAVE_FUNCTION_ATTRIBUTE_FORMAT
>  #define HBAC_ATTRIBUTE_PRINTF(a1, a2) __attribute__((format(printf, a1, a2)))
>  #else
> -#define HABC_ATTRIBUTE_PRINTF(a1, a2)
> +#define HBAC_ATTRIBUTE_PRINTF(a1, a2) 
I'm sorry for typo.

Obvious ACK.

> From 606e66fe7c18a9e78cd1709f6a95e3a53be24991 Mon Sep 17 00:00:00
> 2001
> From: Jakub Hrozek <jhrozek(a)redhat.com&gt;
> Date: Thu, 10 Mar 2016 08:19:58 +0100
> Subject: [PATCH 4/4] libipa_hbac: Move the library to src/lib/ipa_hbac
>
> Moving the library to the lib directory will force maintainers to think
> twice about changes, because it would be obvious this is a library.
>
> Also don't use includes from sssd source tree paths, but add the util
> path to Makefile's CFLAGS so that other projects can copy the
> hbac_evaluator.c file verbatim.
> ---
>  Makefile.am                                          | 18 +++++++++++-------
>  configure.ac                                         |  2 +-
>  src/{providers/ipa => lib/ipa_hbac}/hbac_evaluator.c |  4 ++--
>  src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.doxy.in |  0
>  src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.exports |  0
>  src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.h       |  0
>  src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.pc.in   |  0
>  src/providers/ipa/ipa_access.c                       |  1 -
>  src/providers/ipa/ipa_hbac_common.c                  |  1 -
>  src/providers/ipa/ipa_hbac_private.h                 |  2 +-
>  src/python/pyhbac.c                                  |  2 +-
>  src/tests/ipa_hbac-tests.c                           |  2 +-
>  12 files changed, 17 insertions(+), 15 deletions(-)
>  rename src/{providers/ipa => lib/ipa_hbac}/hbac_evaluator.c (99%)
>  rename src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.doxy.in (100%)
>  rename src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.exports (100%)
>  rename src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.h (100%)
>  rename src/{providers/ipa => lib/ipa_hbac}/ipa_hbac.pc.in (100%) 
LGTM

LS

[Jakub Hrozek]

On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote:
>  diff --git a/Makefile.am b/Makefile.am
>  index d6eb0fc..f8111d0 100644
>  --- a/Makefile.am
>  +++ b/Makefile.am
>  @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES = src/providers/ipa/ipa_hbac.exports
>   libipa_hbac_la_SOURCES = \
>       src/providers/ipa/hbac_evaluator.c \
>       src/util/sss_utf8.c
>  +libipa_hbac_la_CFLAGS = \
>  +    $(AM_CFLAGS) \
>  +    -std=c90 \
>  +    $(NULL)
>   libipa_hbac_la_LIBADD = \
>       $(UNICODE_LIBS)
>   libipa_hbac_la_LDFLAGS = \
>  diff --git a/src/util/sss_utf8.c b/src/util/sss_utf8.c
>  index 7ba11ca..722f28d 100644
>  --- a/src/util/sss_utf8.c
>  +++ b/src/util/sss_utf8.c
>  @@ -22,6 +22,9 @@
>   
>   #include "config.h"
>   
>  +#include <string.h>
>  +#include <errno.h>
>  +
>   #ifdef HAVE_LIBUNISTRING
>   #include <unistr.h>
>   #include <unicase.h>
>  diff --git a/src/util/sss_utf8.h b/src/util/sss_utf8.h
>  index 95b085f..bca9b2c 100644
>  --- a/src/util/sss_utf8.h
>  +++ b/src/util/sss_utf8.h
>  @@ -23,12 +23,15 @@
>   #ifndef SSS_UTF8_H_
>   #define SSS_UTF8_H_
>   
>  -#include "util/util.h"
>  -
>   #ifndef ENOMATCH
>   #define ENOMATCH -1
>   #endif
>   
>  +#include <stdint.h>
>  +#include <stdbool.h>
>  +
>  +#include "util/util_errors.h"
>  +
>   void sss_utf8_free(void *ptr);
>   
>   /* The result must be freed with sss_utf8_free() */ 
According to make V=1 output, this seems to work:

/bin/sh ./libtool  --tag=CC   --mode=compile /usr/bin/gcc -DHAVE_CONFIG_H -I.
-I/home/remote/jhrozek/devel/sssd  -Wall -I..
-I/home/remote/jhrozek/devel/sssd/src/sss_client -I/home/remote/jhrozek/devel/sssd/src -I.
     -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include      -I/usr/include/libnl3  
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DLIBDIR=\"/usr/lib64\"
-DVARDIR=\"/var\" -DSSS_STATEDIR=\"/var
/lib/sss\" -DSYSCONFDIR=\"/etc\" -DSHLIBEXT=\"\"
-DSSSD_LIBEXEC_PATH=\"/usr/libexec/sssd\"
-DSSSD_CONF_DIR=\"/etc/sssd\" -DSSS_NSS_MCACHE_DIR=\"/var/lib/sss/mc\"
-DSSS_NSS_SOCKET_NAME=\"/var/lib/sss/pipes/nss\"
-DSSS_PAM_SOCKET_NAME=\"/var/lib/sss/pipes/pam\"
-DSSS_PAC_SOCKET_NAME=\"/var/lib/sss/pipes/pac\"
-DSSS_PAM_PRIV_SOCKET_NAME=\"/var/lib/sss/pipes/private/pam\"
-DSSS_SUDO_SOCKET_NAME=\"/var/lib/sss/pipes/sudo\" 
-DSSS_AUTOFS_SOCKET_NAME=\"/var/lib/sss/pipes/autofs\"
-DSSS_SSH_SOCKET_NAME=\"/var/lib/sss/pipes/ssh\"
-DLOCALEDIR=\"/usr/share/locale\"
-DBASE_FILE_STEM=\"libipa_hbac_la-hbac_evaluator\"    -Wall -Wshadow -Wst
rict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wundef
-Werror-implicit-function-declaration -Winit-self -Wmissing-include-dirs
-fno-strict-aliasing -std=gnu99 -I/home/remote/jhrozek/devel/sssd/src/util -std=c90  -O0
-Wp,-U_FORTIFY_SOURCE -ggdb -pipe -Wall -Wextra -Wshadow -Wformat -Wformat-security
-Werror=unused-function -Wunused-variable -Wno-missing-field-initializers
-Wno-missing-field-in
itializers -Wno-unused-parameter -Wno-cast-align -Wno-sign-compare
-Werror=implicit-function-declaration -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -D_FILE_OFFSET_BITS=64 -D_LAR
GEFILE_SOURCE -D_LARGEFILE64_SOURCE -MT src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator.lo
-MD -MP -MF src/lib/ipa_hbac/.deps/libipa_hbac_la-hbac_evaluator.Tpo -c -o
src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator
.lo `test -f 'src/lib/ipa_hbac/hbac_evaluator.c' || echo
'/home/remote/jhrozek/devel/sssd/'`src/lib/ipa_hbac/hbac_evaluator.c

When I reverted the C99 removal patch, I also got an error message:
/home/remote/jhrozek/devel/sssd/src/lib/ipa_hbac/hbac_evaluator.c:166:5: error:
'for' loop initial declarations are only allowed in C99 or C11 mode
     for (uint32_t i = 0; rules[i]; i++) {

But I had to change your diff a bit:
diff --git a/src/util/sss_tc_utf8.c b/src/util/sss_tc_utf8.c
index 4b2c493..44194ab 100644
--- a/src/util/sss_tc_utf8.c
+++ b/src/util/sss_tc_utf8.c
@@ -19,6 +19,7 @@
 */
 
 #include <talloc.h>
+#include "util/util.h"
 #include "util/sss_utf8.h"

Otherwise sss_tc_utf8.c wouldn't compile..

Can you resubmit the patch with a nicer commit message and some comment
in the Makefile.am?

[Lukas Slebodnik]

On (10/03/16 20:02), Jakub Hrozek wrote:
> On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote:
> > diff --git a/Makefile.am b/Makefile.am
> > index d6eb0fc..f8111d0 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES =
> src/providers/ipa/ipa_hbac.exports
> >  libipa_hbac_la_SOURCES = \
> >      src/providers/ipa/hbac_evaluator.c \
> >      src/util/sss_utf8.c
> > +libipa_hbac_la_CFLAGS = \
> > +    $(AM_CFLAGS) \
> > +    -std=c90 \
> > +    $(NULL)
> >  libipa_hbac_la_LIBADD = \
> >      $(UNICODE_LIBS)
> >  libipa_hbac_la_LDFLAGS = \
> > diff --git a/src/util/sss_utf8.c b/src/util/sss_utf8.c
> > index 7ba11ca..722f28d 100644
> > --- a/src/util/sss_utf8.c
> > +++ b/src/util/sss_utf8.c
> > @@ -22,6 +22,9 @@
> >  
> >  #include "config.h"
> >  
> > +#include <string.h>
> > +#include <errno.h>
> > +
> >  #ifdef HAVE_LIBUNISTRING
> >  #include <unistr.h>
> >  #include <unicase.h>
> > diff --git a/src/util/sss_utf8.h b/src/util/sss_utf8.h
> > index 95b085f..bca9b2c 100644
> > --- a/src/util/sss_utf8.h
> > +++ b/src/util/sss_utf8.h
> > @@ -23,12 +23,15 @@
> >  #ifndef SSS_UTF8_H_
> >  #define SSS_UTF8_H_
> >  
> > -#include "util/util.h"
> > -
> >  #ifndef ENOMATCH
> >  #define ENOMATCH -1
> >  #endif
> >  
> > +#include <stdint.h>
> > +#include <stdbool.h>
> > +
> > +#include "util/util_errors.h"
> > +
> >  void sss_utf8_free(void *ptr);
> >  
> >  /* The result must be freed with sss_utf8_free() */
>
> According to make V=1 output, this seems to work:
>
> /bin/sh ./libtool  --tag=CC   --mode=compile /usr/bin/gcc -DHAVE_CONFIG_H -I.
> -I/home/remote/jhrozek/devel/sssd  -Wall -I..
> -I/home/remote/jhrozek/devel/sssd/src/sss_client -I/home/remote/jhrozek/devel/sssd/src -I.
>      -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include      -I/usr/include/libnl3  
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DLIBDIR=\"/usr/lib64\"
> -DVARDIR=\"/var\" -DSSS_STATEDIR=\"/var
> /lib/sss\" -DSYSCONFDIR=\"/etc\" -DSHLIBEXT=\"\"
> -DSSSD_LIBEXEC_PATH=\"/usr/libexec/sssd\"
> -DSSSD_CONF_DIR=\"/etc/sssd\" -DSSS_NSS_MCACHE_DIR=\"/var/lib/sss/mc\"
> -DSSS_NSS_SOCKET_NAME=\"/var/lib/sss/pipes/nss\"
> -DSSS_PAM_SOCKET_NAME=\"/var/lib/sss/pipes/pam\"
> -DSSS_PAC_SOCKET_NAME=\"/var/lib/sss/pipes/pac\"
> -DSSS_PAM_PRIV_SOCKET_NAME=\"/var/lib/sss/pipes/private/pam\"
> -DSSS_SUDO_SOCKET_NAME=\"/var/lib/sss/pipes/sudo\" 
> -DSSS_AUTOFS_SOCKET_NAME=\"/var/lib/sss/pipes/autofs\"
> -DSSS_SSH_SOCKET_NAME=\"/var/lib/sss/pipes/ssh\"
> -DLOCALEDIR=\"/usr/share/locale\"
> -DBASE_FILE_STEM=\"libipa_hbac_la-hbac_evaluator\"    -Wall -Wshadow -Wst
> rict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wundef
> -Werror-implicit-function-declaration -Winit-self -Wmissing-include-dirs
> -fno-strict-aliasing -std=gnu99 -I/home/remote/jhrozek/devel/sssd/src/util -std=c90  -O0
> -Wp,-U_FORTIFY_SOURCE -ggdb -pipe -Wall -Wextra -Wshadow -Wformat -Wformat-security
> -Werror=unused-function -Wunused-variable -Wno-missing-field-initializers
> -Wno-missing-field-in
> itializers -Wno-unused-parameter -Wno-cast-align -Wno-sign-compare
> -Werror=implicit-function-declaration -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -m64 -mtune=generic -D_FILE_OFFSET_BITS=64 -D_LAR
> GEFILE_SOURCE -D_LARGEFILE64_SOURCE -MT src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator.lo
> -MD -MP -MF src/lib/ipa_hbac/.deps/libipa_hbac_la-hbac_evaluator.Tpo -c -o
> src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator
> .lo `test -f 'src/lib/ipa_hbac/hbac_evaluator.c' || echo
> '/home/remote/jhrozek/devel/sssd/'`src/lib/ipa_hbac/hbac_evaluator.c
>
> When I reverted the C99 removal patch, I also got an error message:
> /home/remote/jhrozek/devel/sssd/src/lib/ipa_hbac/hbac_evaluator.c:166:5: error:
> 'for' loop initial declarations are only allowed in C99 or C11 mode
>      for (uint32_t i = 0; rules[i]; i++) {
>
> But I had to change your diff a bit:
> diff --git a/src/util/sss_tc_utf8.c b/src/util/sss_tc_utf8.c
> index 4b2c493..44194ab 100644
> --- a/src/util/sss_tc_utf8.c
> +++ b/src/util/sss_tc_utf8.c
> @@ -19,6 +19,7 @@
>  */
>  
>  #include <talloc.h>
> +#include "util/util.h"
>  #include "util/sss_utf8.h"
>  
It's possible. It was a POC to
get warning for in for loop
"for (uint32_t i = 0; rules[i]; i++)"


> Otherwise sss_tc_utf8.c wouldn't compile..
>
> Can you resubmit the patch with a nicer commit message and some comment
> in the Makefile.am? 
I'm lazy.

just squash it you your 1st patch :-)
and fix other compilation issues.

LS

[Lukas Slebodnik]

On (10/03/16 20:37), Lukas Slebodnik wrote:
> On (10/03/16 20:02), Jakub Hrozek wrote:
> >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote:
> >> diff --git a/Makefile.am b/Makefile.am
> >> index d6eb0fc..f8111d0 100644
> >> --- a/Makefile.am
> >> +++ b/Makefile.am
> >> @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES =
> src/providers/ipa/ipa_hbac.exports
> >>  libipa_hbac_la_SOURCES = \
> >>      src/providers/ipa/hbac_evaluator.c \
> >>      src/util/sss_utf8.c
> >> +libipa_hbac_la_CFLAGS = \
> >> +    $(AM_CFLAGS) \
> >> +    -std=c90 \ 
Actually we shoudl use "-std=c89"
becuase gcc on rhel6 does not have "c90"

It has only:
           c89
           iso9899:1990
               Support all ISO C90 programs (certain GNU extensions that
               conflict with ISO C90 are disabled). Same as -ansi for C code.

           iso9899:199409
               ISO C90 as modified in amendment 1.

           c99
           c9x
           iso9899:1999
           iso9899:199x
               ISO C99.  Note that this standard is not yet fully supported;
               see <http://gcc.gnu.org/gcc-4.4/c99status.html> for more
               information.  The names c9x and iso9899:199x are deprecated.

and c9x might be to new :-)
or we might use "iso9899:1990" if "c89" will be too complicated.

LS

[Jakub Hrozek]

On Fri, Mar 11, 2016 at 10:07:16AM +0100, Lukas Slebodnik wrote:
>  On (10/03/16 20:37), Lukas Slebodnik wrote:
>  >On (10/03/16 20:02), Jakub Hrozek wrote:
>  >>On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote:
>  >>> diff --git a/Makefile.am b/Makefile.am
>  >>> index d6eb0fc..f8111d0 100644
>  >>> --- a/Makefile.am
>  >>> +++ b/Makefile.am
>  >>> @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES =
> src/providers/ipa/ipa_hbac.exports
>  >>>  libipa_hbac_la_SOURCES = \
>  >>>      src/providers/ipa/hbac_evaluator.c \
>  >>>      src/util/sss_utf8.c
>  >>> +libipa_hbac_la_CFLAGS = \
>  >>> +    $(AM_CFLAGS) \
>  >>> +    -std=c90 \
>  Actually we shoudl use "-std=c89"
>  becuase gcc on rhel6 does not have "c90"
>  
>  It has only:
>             c89
>             iso9899:1990
>                 Support all ISO C90 programs (certain GNU extensions that
>                 conflict with ISO C90 are disabled). Same as -ansi for C code.
>  
>             iso9899:199409
>                 ISO C90 as modified in amendment 1.
>  
>             c99
>             c9x
>             iso9899:1999
>             iso9899:199x
>                 ISO C99.  Note that this standard is not yet fully supported;
>                 see <http://gcc.gnu.org/gcc-4.4/c99status.html> for more
>                 information.  The names c9x and iso9899:199x are deprecated.
>  
>  and c9x might be to new :-)
>  or we might use "iso9899:1990" if "c89" will be too complicated.
Yeah, CI already kicked me out when I submitted the patch with -std=c90 :-)

[Jakub Hrozek]

On Thu, Mar 10, 2016 at 08:37:23PM +0100, Lukas Slebodnik wrote:
>  On (10/03/16 20:02), Jakub Hrozek wrote:
>  >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote:
>  >> diff --git a/Makefile.am b/Makefile.am
>  >> index d6eb0fc..f8111d0 100644
>  >> --- a/Makefile.am
>  >> +++ b/Makefile.am
>  >> @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES =
> src/providers/ipa/ipa_hbac.exports
>  >>  libipa_hbac_la_SOURCES = \
>  >>      src/providers/ipa/hbac_evaluator.c \
>  >>      src/util/sss_utf8.c
>  >> +libipa_hbac_la_CFLAGS = \
>  >> +    $(AM_CFLAGS) \
>  >> +    -std=c90 \
>  >> +    $(NULL)
>  >>  libipa_hbac_la_LIBADD = \
>  >>      $(UNICODE_LIBS)
>  >>  libipa_hbac_la_LDFLAGS = \
>  >> diff --git a/src/util/sss_utf8.c b/src/util/sss_utf8.c
>  >> index 7ba11ca..722f28d 100644
>  >> --- a/src/util/sss_utf8.c
>  >> +++ b/src/util/sss_utf8.c
>  >> @@ -22,6 +22,9 @@
>  >>  
>  >>  #include "config.h"
>  >>  
>  >> +#include <string.h>
>  >> +#include <errno.h>
>  >> +
>  >>  #ifdef HAVE_LIBUNISTRING
>  >>  #include <unistr.h>
>  >>  #include <unicase.h>
>  >> diff --git a/src/util/sss_utf8.h b/src/util/sss_utf8.h
>  >> index 95b085f..bca9b2c 100644
>  >> --- a/src/util/sss_utf8.h
>  >> +++ b/src/util/sss_utf8.h
>  >> @@ -23,12 +23,15 @@
>  >>  #ifndef SSS_UTF8_H_
>  >>  #define SSS_UTF8_H_
>  >>  
>  >> -#include "util/util.h"
>  >> -
>  >>  #ifndef ENOMATCH
>  >>  #define ENOMATCH -1
>  >>  #endif
>  >>  
>  >> +#include <stdint.h>
>  >> +#include <stdbool.h>
>  >> +
>  >> +#include "util/util_errors.h"
>  >> +
>  >>  void sss_utf8_free(void *ptr);
>  >>  
>  >>  /* The result must be freed with sss_utf8_free() */
>  >
>  >According to make V=1 output, this seems to work:
>  >
>  >/bin/sh ./libtool  --tag=CC   --mode=compile /usr/bin/gcc -DHAVE_CONFIG_H -I.
> -I/home/remote/jhrozek/devel/sssd  -Wall -I..
> -I/home/remote/jhrozek/devel/sssd/src/sss_client -I/home/remote/jhrozek/devel/sssd/src -I.
>      -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include      -I/usr/include/libnl3  
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DLIBDIR=\"/usr/lib64\"
> -DVARDIR=\"/var\" -DSSS_STATEDIR=\"/var
>  >/lib/sss\" -DSYSCONFDIR=\"/etc\" -DSHLIBEXT=\"\"
> -DSSSD_LIBEXEC_PATH=\"/usr/libexec/sssd\"
> -DSSSD_CONF_DIR=\"/etc/sssd\" -DSSS_NSS_MCACHE_DIR=\"/var/lib/sss/mc\"
> -DSSS_NSS_SOCKET_NAME=\"/var/lib/sss/pipes/nss\"
> -DSSS_PAM_SOCKET_NAME=\"/var/lib/sss/pipes/pam\"
> -DSSS_PAC_SOCKET_NAME=\"/var/lib/sss/pipes/pac\"
> -DSSS_PAM_PRIV_SOCKET_NAME=\"/var/lib/sss/pipes/private/pam\"
> -DSSS_SUDO_SOCKET_NAME=\"/var/lib/sss/pipes/sudo\" 
>  >-DSSS_AUTOFS_SOCKET_NAME=\"/var/lib/sss/pipes/autofs\"
> -DSSS_SSH_SOCKET_NAME=\"/var/lib/sss/pipes/ssh\"
> -DLOCALEDIR=\"/usr/share/locale\"
> -DBASE_FILE_STEM=\"libipa_hbac_la-hbac_evaluator\"    -Wall -Wshadow -Wst
>  >rict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wundef
> -Werror-implicit-function-declaration -Winit-self -Wmissing-include-dirs
> -fno-strict-aliasing -std=gnu99 -I/home/remote/jhrozek/devel/sssd/src/util -std=c90  -O0
> -Wp,-U_FORTIFY_SOURCE -ggdb -pipe -Wall -Wextra -Wshadow -Wformat -Wformat-security
> -Werror=unused-function -Wunused-variable -Wno-missing-field-initializers
> -Wno-missing-field-in
>  >itializers -Wno-unused-parameter -Wno-cast-align -Wno-sign-compare
> -Werror=implicit-function-declaration -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -m64 -mtune=generic -D_FILE_OFFSET_BITS=64 -D_LAR
>  >GEFILE_SOURCE -D_LARGEFILE64_SOURCE -MT
> src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator.lo -MD -MP -MF
> src/lib/ipa_hbac/.deps/libipa_hbac_la-hbac_evaluator.Tpo -c -o
> src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator
>  >.lo `test -f 'src/lib/ipa_hbac/hbac_evaluator.c' || echo
> '/home/remote/jhrozek/devel/sssd/'`src/lib/ipa_hbac/hbac_evaluator.c
>  >
>  >When I reverted the C99 removal patch, I also got an error message:
>  >/home/remote/jhrozek/devel/sssd/src/lib/ipa_hbac/hbac_evaluator.c:166:5: error:
> 'for' loop initial declarations are only allowed in C99 or C11 mode
>  >     for (uint32_t i = 0; rules[i]; i++) {
>  >
>  >But I had to change your diff a bit:
>  >diff --git a/src/util/sss_tc_utf8.c b/src/util/sss_tc_utf8.c
>  >index 4b2c493..44194ab 100644
>  >--- a/src/util/sss_tc_utf8.c
>  >+++ b/src/util/sss_tc_utf8.c
>  >@@ -19,6 +19,7 @@
>  > */
>  > 
>  > #include <talloc.h>
>  >+#include "util/util.h"
>  > #include "util/sss_utf8.h"
>  >
>  It's possible. It was a POC to
>  get warning for in for loop
>  "for (uint32_t i = 0; rules[i]; i++)"
>  
>  
>  >Otherwise sss_tc_utf8.c wouldn't compile..
>  >
>  >Can you resubmit the patch with a nicer commit message and some comment
>  >in the Makefile.am?
>  I'm lazy.
>  
>  just squash it you your 1st patch :-)
>  and fix other compilation issues. 
I would prefer to give you credit for the suggestion, see a new patch
atop mine.

CI: http://sssd-ci.duckdns.org/logs/job/39/02/summary.html

[Lukas Slebodnik]

On (11/03/16 11:14), Jakub Hrozek wrote:
> On Thu, Mar 10, 2016 at 08:37:23PM +0100, Lukas Slebodnik wrote:
> > On (10/03/16 20:02), Jakub Hrozek wrote:
> > >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote:
> > >> diff --git a/Makefile.am b/Makefile.am
> > >> index d6eb0fc..f8111d0 100644
> > >> --- a/Makefile.am
> > >> +++ b/Makefile.am
> > >> @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES =
> src/providers/ipa/ipa_hbac.exports
> > >>  libipa_hbac_la_SOURCES = \
> > >>      src/providers/ipa/hbac_evaluator.c \
> > >>      src/util/sss_utf8.c
> > >> +libipa_hbac_la_CFLAGS = \
> > >> +    $(AM_CFLAGS) \
> > >> +    -std=c90 \
> > >> +    $(NULL)
> > >>  libipa_hbac_la_LIBADD = \
> > >>      $(UNICODE_LIBS)
> > >>  libipa_hbac_la_LDFLAGS = \
> > >> diff --git a/src/util/sss_utf8.c b/src/util/sss_utf8.c
> > >> index 7ba11ca..722f28d 100644
> > >> --- a/src/util/sss_utf8.c
> > >> +++ b/src/util/sss_utf8.c
> > >> @@ -22,6 +22,9 @@
> > >>  
> > >>  #include "config.h"
> > >>  
> > >> +#include <string.h>
> > >> +#include <errno.h>
> > >> +
> > >>  #ifdef HAVE_LIBUNISTRING
> > >>  #include <unistr.h>
> > >>  #include <unicase.h>
> > >> diff --git a/src/util/sss_utf8.h b/src/util/sss_utf8.h
> > >> index 95b085f..bca9b2c 100644
> > >> --- a/src/util/sss_utf8.h
> > >> +++ b/src/util/sss_utf8.h
> > >> @@ -23,12 +23,15 @@
> > >>  #ifndef SSS_UTF8_H_
> > >>  #define SSS_UTF8_H_
> > >>  
> > >> -#include "util/util.h"
> > >> -
> > >>  #ifndef ENOMATCH
> > >>  #define ENOMATCH -1
> > >>  #endif
> > >>  
> > >> +#include <stdint.h>
> > >> +#include <stdbool.h>
> > >> +
> > >> +#include "util/util_errors.h"
> > >> +
> > >>  void sss_utf8_free(void *ptr);
> > >>  
> > >>  /* The result must be freed with sss_utf8_free() */
> > >
> > >According to make V=1 output, this seems to work:
> > >
> > >/bin/sh ./libtool  --tag=CC   --mode=compile /usr/bin/gcc -DHAVE_CONFIG_H -I.
> -I/home/remote/jhrozek/devel/sssd  -Wall -I..
> -I/home/remote/jhrozek/devel/sssd/src/sss_client -I/home/remote/jhrozek/devel/sssd/src -I.
>      -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include      -I/usr/include/libnl3  
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DLIBDIR=\"/usr/lib64\"
> -DVARDIR=\"/var\" -DSSS_STATEDIR=\"/var
> > >/lib/sss\" -DSYSCONFDIR=\"/etc\" -DSHLIBEXT=\"\"
> -DSSSD_LIBEXEC_PATH=\"/usr/libexec/sssd\"
> -DSSSD_CONF_DIR=\"/etc/sssd\" -DSSS_NSS_MCACHE_DIR=\"/var/lib/sss/mc\"
> -DSSS_NSS_SOCKET_NAME=\"/var/lib/sss/pipes/nss\"
> -DSSS_PAM_SOCKET_NAME=\"/var/lib/sss/pipes/pam\"
> -DSSS_PAC_SOCKET_NAME=\"/var/lib/sss/pipes/pac\"
> -DSSS_PAM_PRIV_SOCKET_NAME=\"/var/lib/sss/pipes/private/pam\"
> -DSSS_SUDO_SOCKET_NAME=\"/var/lib/sss/pipes/sudo\" 
> > >-DSSS_AUTOFS_SOCKET_NAME=\"/var/lib/sss/pipes/autofs\"
> -DSSS_SSH_SOCKET_NAME=\"/var/lib/sss/pipes/ssh\"
> -DLOCALEDIR=\"/usr/share/locale\"
> -DBASE_FILE_STEM=\"libipa_hbac_la-hbac_evaluator\"    -Wall -Wshadow -Wst
> > >rict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wundef
> -Werror-implicit-function-declaration -Winit-self -Wmissing-include-dirs
> -fno-strict-aliasing -std=gnu99 -I/home/remote/jhrozek/devel/sssd/src/util -std=c90  -O0
> -Wp,-U_FORTIFY_SOURCE -ggdb -pipe -Wall -Wextra -Wshadow -Wformat -Wformat-security
> -Werror=unused-function -Wunused-variable -Wno-missing-field-initializers
> -Wno-missing-field-in
> > >itializers -Wno-unused-parameter -Wno-cast-align -Wno-sign-compare
> -Werror=implicit-function-declaration -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -m64 -mtune=generic -D_FILE_OFFSET_BITS=64 -D_LAR
> > >GEFILE_SOURCE -D_LARGEFILE64_SOURCE -MT
> src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator.lo -MD -MP -MF
> src/lib/ipa_hbac/.deps/libipa_hbac_la-hbac_evaluator.Tpo -c -o
> src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator
> > >.lo `test -f 'src/lib/ipa_hbac/hbac_evaluator.c' || echo
> '/home/remote/jhrozek/devel/sssd/'`src/lib/ipa_hbac/hbac_evaluator.c
> > >
> > >When I reverted the C99 removal patch, I also got an error message:
> > >/home/remote/jhrozek/devel/sssd/src/lib/ipa_hbac/hbac_evaluator.c:166:5: error:
> 'for' loop initial declarations are only allowed in C99 or C11 mode
> > >     for (uint32_t i = 0; rules[i]; i++) {
> > >
> > >But I had to change your diff a bit:
> > >diff --git a/src/util/sss_tc_utf8.c b/src/util/sss_tc_utf8.c
> > >index 4b2c493..44194ab 100644
> > >--- a/src/util/sss_tc_utf8.c
> > >+++ b/src/util/sss_tc_utf8.c
> > >@@ -19,6 +19,7 @@
> > > */
> > > 
> > > #include <talloc.h>
> > >+#include "util/util.h"
> > > #include "util/sss_utf8.h"
> > >
> > It's possible. It was a POC to
> > get warning for in for loop
> > "for (uint32_t i = 0; rules[i]; i++)"
> > 
> > 
> > >Otherwise sss_tc_utf8.c wouldn't compile..
> > >
> > >Can you resubmit the patch with a nicer commit message and some comment
> > >in the Makefile.am?
> > I'm lazy.
> > 
> > just squash it you your 1st patch :-)
> > and fix other compilation issues.
>
> I would prefer to give you credit for the suggestion, see a new patch
> atop mine.
>
> CI: http://sssd-ci.duckdns.org/logs/job/39/02/summary.html 
ACK to all

LS

[Lukas Slebodnik]

On (12/03/16 21:21), Lukas Slebodnik wrote:
> On (11/03/16 11:14), Jakub Hrozek wrote:
> >On Thu, Mar 10, 2016 at 08:37:23PM +0100, Lukas Slebodnik wrote:
> >> On (10/03/16 20:02), Jakub Hrozek wrote:
> >> >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote:
> >> >> diff --git a/Makefile.am b/Makefile.am
> >> >> index d6eb0fc..f8111d0 100644
> >> >> --- a/Makefile.am
> >> >> +++ b/Makefile.am
> >> >> @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES =
> src/providers/ipa/ipa_hbac.exports
> >> >>  libipa_hbac_la_SOURCES = \
> >> >>      src/providers/ipa/hbac_evaluator.c \
> >> >>      src/util/sss_utf8.c
> >> >> +libipa_hbac_la_CFLAGS = \
> >> >> +    $(AM_CFLAGS) \
> >> >> +    -std=c90 \
> >> >> +    $(NULL)
> >> >>  libipa_hbac_la_LIBADD = \
> >> >>      $(UNICODE_LIBS)
> >> >>  libipa_hbac_la_LDFLAGS = \
> >> >> diff --git a/src/util/sss_utf8.c b/src/util/sss_utf8.c
> >> >> index 7ba11ca..722f28d 100644
> >> >> --- a/src/util/sss_utf8.c
> >> >> +++ b/src/util/sss_utf8.c
> >> >> @@ -22,6 +22,9 @@
> >> >>  
> >> >>  #include "config.h"
> >> >>  
> >> >> +#include <string.h>
> >> >> +#include <errno.h>
> >> >> +
> >> >>  #ifdef HAVE_LIBUNISTRING
> >> >>  #include <unistr.h>
> >> >>  #include <unicase.h>
> >> >> diff --git a/src/util/sss_utf8.h b/src/util/sss_utf8.h
> >> >> index 95b085f..bca9b2c 100644
> >> >> --- a/src/util/sss_utf8.h
> >> >> +++ b/src/util/sss_utf8.h
> >> >> @@ -23,12 +23,15 @@
> >> >>  #ifndef SSS_UTF8_H_
> >> >>  #define SSS_UTF8_H_
> >> >>  
> >> >> -#include "util/util.h"
> >> >> -
> >> >>  #ifndef ENOMATCH
> >> >>  #define ENOMATCH -1
> >> >>  #endif
> >> >>  
> >> >> +#include <stdint.h>
> >> >> +#include <stdbool.h>
> >> >> +
> >> >> +#include "util/util_errors.h"
> >> >> +
> >> >>  void sss_utf8_free(void *ptr);
> >> >>  
> >> >>  /* The result must be freed with sss_utf8_free() */
> >> >
> >> >According to make V=1 output, this seems to work:
> >> >
> >> >/bin/sh ./libtool  --tag=CC   --mode=compile /usr/bin/gcc -DHAVE_CONFIG_H -I.
> -I/home/remote/jhrozek/devel/sssd  -Wall -I..
> -I/home/remote/jhrozek/devel/sssd/src/sss_client -I/home/remote/jhrozek/devel/sssd/src -I.
>      -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include      -I/usr/include/libnl3  
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DLIBDIR=\"/usr/lib64\"
> -DVARDIR=\"/var\" -DSSS_STATEDIR=\"/var
> >> >/lib/sss\" -DSYSCONFDIR=\"/etc\" -DSHLIBEXT=\"\"
> -DSSSD_LIBEXEC_PATH=\"/usr/libexec/sssd\"
> -DSSSD_CONF_DIR=\"/etc/sssd\" -DSSS_NSS_MCACHE_DIR=\"/var/lib/sss/mc\"
> -DSSS_NSS_SOCKET_NAME=\"/var/lib/sss/pipes/nss\"
> -DSSS_PAM_SOCKET_NAME=\"/var/lib/sss/pipes/pam\"
> -DSSS_PAC_SOCKET_NAME=\"/var/lib/sss/pipes/pac\"
> -DSSS_PAM_PRIV_SOCKET_NAME=\"/var/lib/sss/pipes/private/pam\"
> -DSSS_SUDO_SOCKET_NAME=\"/var/lib/sss/pipes/sudo\" 
> >> >-DSSS_AUTOFS_SOCKET_NAME=\"/var/lib/sss/pipes/autofs\"
> -DSSS_SSH_SOCKET_NAME=\"/var/lib/sss/pipes/ssh\"
> -DLOCALEDIR=\"/usr/share/locale\"
> -DBASE_FILE_STEM=\"libipa_hbac_la-hbac_evaluator\"    -Wall -Wshadow -Wst
> >> >rict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings
> -Wundef -Werror-implicit-function-declaration -Winit-self -Wmissing-include-dirs
> -fno-strict-aliasing -std=gnu99 -I/home/remote/jhrozek/devel/sssd/src/util -std=c90  -O0
> -Wp,-U_FORTIFY_SOURCE -ggdb -pipe -Wall -Wextra -Wshadow -Wformat -Wformat-security
> -Werror=unused-function -Wunused-variable -Wno-missing-field-initializers
> -Wno-missing-field-in
> >> >itializers -Wno-unused-parameter -Wno-cast-align -Wno-sign-compare
> -Werror=implicit-function-declaration -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 -m64 -mtune=generic -D_FILE_OFFSET_BITS=64 -D_LAR
> >> >GEFILE_SOURCE -D_LARGEFILE64_SOURCE -MT
> src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator.lo -MD -MP -MF
> src/lib/ipa_hbac/.deps/libipa_hbac_la-hbac_evaluator.Tpo -c -o
> src/lib/ipa_hbac/libipa_hbac_la-hbac_evaluator
> >> >.lo `test -f 'src/lib/ipa_hbac/hbac_evaluator.c' || echo
> '/home/remote/jhrozek/devel/sssd/'`src/lib/ipa_hbac/hbac_evaluator.c
> >> >
> >> >When I reverted the C99 removal patch, I also got an error message:
> >> >/home/remote/jhrozek/devel/sssd/src/lib/ipa_hbac/hbac_evaluator.c:166:5:
> error: 'for' loop initial declarations are only allowed in C99 or C11 mode
> >> >     for (uint32_t i = 0; rules[i]; i++) {
> >> >
> >> >But I had to change your diff a bit:
> >> >diff --git a/src/util/sss_tc_utf8.c b/src/util/sss_tc_utf8.c
> >> >index 4b2c493..44194ab 100644
> >> >--- a/src/util/sss_tc_utf8.c
> >> >+++ b/src/util/sss_tc_utf8.c
> >> >@@ -19,6 +19,7 @@
> >> > */
> >> > 
> >> > #include <talloc.h>
> >> >+#include "util/util.h"
> >> > #include "util/sss_utf8.h"
> >> >
> >> It's possible. It was a POC to
> >> get warning for in for loop
> >> "for (uint32_t i = 0; rules[i]; i++)"
> >> 
> >> 
> >> >Otherwise sss_tc_utf8.c wouldn't compile..
> >> >
> >> >Can you resubmit the patch with a nicer commit message and some comment
> >> >in the Makefile.am?
> >> I'm lazy.
> >> 
> >> just squash it you your 1st patch :-)
> >> and fix other compilation issues.
> >
> >I would prefer to give you credit for the suggestion, see a new patch
> >atop mine.
> >
> >CI: http://sssd-ci.duckdns.org/logs/job/39/02/summary.html
>
> ACK to all
>  
master:
* de5fa34860886ad68fba5e739987e16c342e8f14
* e0c86d21388bffe2e3919e780780c40d96186abb
* 9f18131a2ace84c393982734c93ce22eda558510
* cd8da80527d062ee78bd5f326f0fbb29deff3ee5
* 047c62c251b33f4758c9944748f92d4511158a7e

LS