Simple patch attached.
Thanks Michal
PS: We should really push the patches that Lukas wrote to prevent this kind of errors. It is in thread: [SSSD] [PATCHES] Enable printf format string checking
With them, we will get warning if do the same mistake in the future.
On Tue, Aug 20, 2013 at 03:45:01PM +0200, Michal Židek wrote:
Simple patch attached.
Thanks Michal
ACK
PS: We should really push the patches that Lukas wrote to prevent this kind of errors. It is in thread: [SSSD] [PATCHES] Enable printf format string checking
With them, we will get warning if do the same mistake in the future.
Yes, I just had some concerns about formatting of uid_t and gid_t. But I agree we should push them before the next release.
On (20/08/13 16:05), Jakub Hrozek wrote:
On Tue, Aug 20, 2013 at 03:45:01PM +0200, Michal Židek wrote:
Simple patch attached.
Thanks Michal
ACK
PS: We should really push the patches that Lukas wrote to prevent this kind of errors. It is in thread: [SSSD] [PATCHES] Enable printf format string checking
With them, we will get warning if do the same mistake in the future.
Yes, I just had some concerns about formatting of uid_t and gid_t. But I agree we should push them before the next release.
I am open to discussion about formatting some types. This was a reason why changes were splitted to so many patches.
LS
sssd-devel@lists.fedorahosted.org