[PATCH] Do not run negative resolv test with no network

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

One of our resolv tests tries to resolve a nonexistent hostname. Do not
run this test unless we are explicitly told that a network connection
is available (-n).

Our tests now pass with no network.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkuOaQUACgkQHsardTLnvCUObwCbBcndgy66WBHpJtKl5x+eYBJ5
> USQAn36DbSKZ7d39Ga7n0E09TaDf8RPy
> =ZFoU
> -----END PGP SIGNATURE-----

[Martin Nagy]

On Wed, 2010-03-03 at 14:49 +0100, Jakub Hrozek wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>  
>  One of our resolv tests tries to resolve a nonexistent hostname. Do not
>  run this test unless we are explicitly told that a network connection
>  is available (-n).
>  
>  Our tests now pass with no network. 
ACK

Martin

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/04/2010 06:03 PM, Martin Nagy wrote:
>  On Wed, 2010-03-03 at 14:49 +0100, Jakub Hrozek wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > One of our resolv tests tries to resolve a nonexistent hostname. Do not
> > run this test unless we are explicitly told that a network connection
> > is available (-n).
> >
> > Our tests now pass with no network.
>  
>  ACK
>  
>  Martin
>  
The attached patch also moves the localhost test into the networked
tests so we can safely build on systems that lack the localhost
definition in /etc/hosts.

Also prints a warning when running in non-networked mode.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkuP7XYACgkQHsardTLnvCXa5QCfYTmKAc+QI3OhyF+sHqpRXHTd
> hHwAn1BDi4LUaJWgCgNFgc5PKUFJRSGr
> =pipc
> -----END PGP SIGNATURE-----

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/04/2010 06:27 PM, Jakub Hrozek wrote:
>  The attached patch also moves the localhost test into the networked
>  tests so we can safely build on systems that lack the localhost
>  definition in /etc/hosts.
>  
>  Also prints a warning when running in non-networked mode.
>   
One more patch - rebase against current master and add a test to resolve
"127.0.0.1" which does nothing except calling the specified callback, so
this codepath can be tested even in environments with no network.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkuP8+QACgkQHsardTLnvCUfbACg0y2SmVqUDmnyS1UeJLVs2/8r
> lYoAn0Q4KDReb6Ph8KpeED4JtQy+dIEz
> =GS9G
> -----END PGP SIGNATURE-----

[Sumit Bose]

On Thu, Mar 04, 2010 at 06:54:44PM +0100, Jakub Hrozek wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>  
>  On 03/04/2010 06:27 PM, Jakub Hrozek wrote:
>  > The attached patch also moves the localhost test into the networked
>  > tests so we can safely build on systems that lack the localhost
>  > definition in /etc/hosts.
>  > 
>  > Also prints a warning when running in non-networked mode.
>  > 
>  
>  One more patch - rebase against current master and add a test to resolve
>  "127.0.0.1" which does nothing except calling the specified callback, so
>  this codepath can be tested even in environments with no network. 
ACK

bye,
Sumit

>  -----BEGIN PGP SIGNATURE-----
>  Version: GnuPG v1.4.10 (GNU/Linux)
>  Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>  
>  iEYEARECAAYFAkuP8+QACgkQHsardTLnvCUfbACg0y2SmVqUDmnyS1UeJLVs2/8r
>  lYoAn0Q4KDReb6Ph8KpeED4JtQy+dIEz
>  =GS9G
>  -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/05/2010 07:08 AM, Sumit Bose wrote:
>  On Thu, Mar 04, 2010 at 06:54:44PM +0100, Jakub Hrozek wrote:
>  On 03/04/2010 06:27 PM, Jakub Hrozek wrote:
> >>> The attached patch also moves the localhost test into the networked
> >>> tests so we can safely build on systems that lack the localhost
> >>> definition in /etc/hosts.
> >>>
> >>> Also prints a warning when running in non-networked mode.
> >>>
>  
>  One more patch - rebase against current master and add a test to resolve
>  "127.0.0.1" which does nothing except calling the specified callback, so
>  this codepath can be tested even in environments with no network.
>  
> > ACK
>  
> > bye,
> > Sumit
>   
Pushed to master and 1-1-0.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkuVRdMACgkQeiVVYja6o6NdnwCgiVN2F7ph+p2bf36LpM7RNrFL
> +50AnAxS1raD3+FT3kKAQXckmOQxUk6P
> =X6x3
> -----END PGP SIGNATURE-----