URL: https://github.com/SSSD/sssd/pull/147 Author: fidencio Title: #147: IFP: Update ifp_iface_generated.c Action: opened
PR body: """ These changes are leftovers from commit 78b4b7e. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/147/head:pr147 git checkout pr147
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented: """ Please figure out why sbus codegen didn't remove this code instead of removing it manually. """
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277971276
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
fidencio commented: """ Pavel,
I didn't remove the code manually. I've noticed this file changed after building the project. """
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277972962
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented: """ Interesting, we must have some bug in sbus codegen since it doesn't get removed in my tree. I remember a ticket when sbus_codegen seemed to be randomly generated different code from time to time I don't think we have ever track it down but I can't find the ticket. """
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277976601
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented: """ Ack to the patch. """
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277976661
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented: """ When I explicitly touch ifp_iface.xml it gets regenerated correctly... but why wasn't it back at the time? """
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277976898
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
fidencio commented: """ @pbrezina, may I ask you to open a ticket for this issue? It has to be fixed in the (near) future. """
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277977320
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
lslebodn commented: """ On (07/02/17 03:50), Pavel Březina wrote:
Interesting, we must have some bug in sbus codegen since it doesn't get removed in my tree. I remember a ticket when sbus_codegen seemed to be randomly generated different code from time to time I don't think we have ever track it down but I can't find the ticket.
That was a different bug. It was ordering of "elements" in array. And IIRC it's already fixed.
This change was not related to ordering.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277979463
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
lslebodn commented: """ master: * 2ddcd5785f10de42bf03dfc36eca94dbc1fc1fb3
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/147#issuecomment-277980195
URL: https://github.com/SSSD/sssd/pull/147 Title: #147: IFP: Update ifp_iface_generated.c
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/147 Author: fidencio Title: #147: IFP: Update ifp_iface_generated.c Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/147/head:pr147 git checkout pr147
sssd-devel@lists.fedorahosted.org
-
fidencio -
lslebodn
-
pbrezina