URL: https://github.com/SSSD/sssd/pull/247 Author: mzidek-rh Title: #247: Subdomain inherit Action: opened
PR body: """ I tested if the options that work in subdomain inherit also work in trusted domain section in sssd.conf. Most seem to work without any changes in the code except for two. With these two patches only one that does not work remains (I wanted to send patchset that adds all the options, but I got stuck on the option that sets the ldap principal, so I am sending this in the meantime). """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/247/head:pr247 git checkout pr247
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
lslebodn commented: """ This patch set modified the function `check_subdom_config_file` which is called from the function `new_subdomain`. And this function is already tested in unitests.
``` sh$ git grep new_subdomain -- src/tests/ src/tests/cmocka/test_fqnames.c: /* just to make new_subdomain happy */ src/tests/cmocka/test_fqnames.c: test_ctx->subdom = new_subdomain(dom, dom, SUBDOMNAME, NULL, SUBFLATNAME, src/tests/cmocka/test_nss_srv.c:#include "db/sysdb_private.h" /* new_subdomain() */ src/tests/cmocka/test_nss_srv.c: subdomain = new_subdomain(nss_test_ctx, nss_test_ctx->tctx->dom, src/tests/cmocka/test_simple_access.c:#include "db/sysdb_private.h" /* new_subdomain() */ src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, ```
Please provide unit test. for this change.
"""
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-296985832
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
lslebodn commented: """ This patch set modified the function `check_subdom_config_file` which is called from the function `new_subdomain`. And this function is already tested in unitests.
``` sh$ git grep new_subdomain -- src/tests/ src/tests/cmocka/test_fqnames.c: /* just to make new_subdomain happy */ src/tests/cmocka/test_fqnames.c: test_ctx->subdom = new_subdomain(dom, dom, SUBDOMNAME, NULL, SUBFLATNAME, src/tests/cmocka/test_nss_srv.c:#include "db/sysdb_private.h" /* new_subdomain() */ src/tests/cmocka/test_nss_srv.c: subdomain = new_subdomain(nss_test_ctx, nss_test_ctx->tctx->dom, src/tests/cmocka/test_simple_access.c:#include "db/sysdb_private.h" /* new_subdomain() */ src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, src/tests/sysdb-tests.c: subdomain = new_subdomain(test_ctx, test_ctx->domain, ```
Please provide unit test. for this change.
"""
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-296985832
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
mzidek-rh commented: """ I forgot to comment on this. In order to add tests for this I first need to fix the https://pagure.io/SSSD/sssd/issue/3338 otherwise it would be double work. I already started doing it, before I switched to the https://pagure.io/SSSD/sssd/issue/3381 , which should be fixed soon. """
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-297691415
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
lslebodn commented: """
I forgot to comment on this. In order to add tests for this I first need to fix the https://pagure.io/SSSD/sssd/issue/3338 otherwise it would be double work.
Ticket 3338 is about function `ad_create_sdap_options` in `src/providers/ad/ad_common.c` This change is on sysdb level. They are two different things. We have quite high code coverage done by sysdb test. Therefore ticket 3338 is not a blocker for writing sysdb test.
I already started doing it, before I switched to the https://pagure.io/SSSD/sssd/issue/3381 , which should be fixed soon.
Sure """
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-297934683
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
lslebodn commented: """ @mzidek-rh Do we still need this patch or it should be closed as rejected? Because requested changes were not done in 5.5 week. """
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-306393603
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
mzidek-rh commented: """ @lslebodn the downstream bugs were moved to later milestone, but we still need to do it... unfortunately something with higher priority always pops up... I hope to get back to this before next week """
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-306420726
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
lslebodn commented: """ Bump.
https://pagure.io/SSSD/sssd/issue/3337 is planed for 1.15.4. So it would be good to work on this sooner then later.
"""
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-321735746
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
lslebodn commented: """ Bump """
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-325006983
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
lslebodn commented: """ Bump for 3rd time. Requested unit test has not been written for long time therefore priority for related upstream ticket was changed from critical to blocker """
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-327231749
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
fidencio commented: """ @mzidek-rh, what's the status of this PR? Would you mind giving us a update?
"""
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-336365041
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit
jhrozek commented: """ Hi Michal, since this PR appears quite stalled, I'm going to close it. I still think the work is something that SSSD would benefit from, but the work shouldn't be tracked in a PR, unless there is active interest in merging the code.
Please let me know if I can help with resolving whatever is blocked with the PR. """
See the full comment at https://github.com/SSSD/sssd/pull/247#issuecomment-390783093
URL: https://github.com/SSSD/sssd/pull/247 Author: mzidek-rh Title: #247: Subdomain inherit Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/247/head:pr247 git checkout pr247
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek
-
lslebodn
-
mzidek-rh