[PATCH] Fix warning zero-length gnu_printf format string

[Lukas Slebodnik]

ehlo,

I found a warning "zero-length gnu_printf format string" when I was testing
patches on ALT linux. It is in the ifdef section if nsupdate do not have
support for realm.

Simple patch attached.

LS

[Jakub Hrozek]

On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
>  ehlo,
>  
>  I found a warning "zero-length gnu_printf format string" when I was testing
>  patches on ALT linux. It is in the ifdef section if nsupdate do not have
>  support for realm.
>  
>  Simple patch attached.
>  
>  LS 
Given that this patch is intended for master only and given that
nsupdate has had support for realm for a long time now, would it make
more sense to remove the legacy code instead? I'd prefer to remove the
ifdefs in master where possible :-)

[Jakub Hrozek]

On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
>  On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
>  > ehlo,
>  > 
>  > I found a warning "zero-length gnu_printf format string" when I was
> testing
>  > patches on ALT linux. It is in the ifdef section if nsupdate do not have
>  > support for realm.
>  > 
>  > Simple patch attached.
>  > 
>  > LS
>  
>  Given that this patch is intended for master only and given that
>  nsupdate has had support for realm for a long time now, would it make
>  more sense to remove the legacy code instead? I'd prefer to remove the
>  ifdefs in master where possible :-) 
This thread has stalled.

I changed my opinion on removing the realm, though, since Stephen
provided patches to run newer sssd on el5 and who knows what nsupdate
versions are on the BSDs..

So ACK to the patch.

[Jakub Hrozek]

On Mon, Apr 07, 2014 at 07:18:11PM +0200, Jakub Hrozek wrote:
>  On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
>  > On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
>  > > ehlo,
>  > > 
>  > > I found a warning "zero-length gnu_printf format string" when I was
> testing
>  > > patches on ALT linux. It is in the ifdef section if nsupdate do not have
>  > > support for realm.
>  > > 
>  > > Simple patch attached.
>  > > 
>  > > LS
>  > 
>  > Given that this patch is intended for master only and given that
>  > nsupdate has had support for realm for a long time now, would it make
>  > more sense to remove the legacy code instead? I'd prefer to remove the
>  > ifdefs in master where possible :-)
>  
>  This thread has stalled.
>  
>  I changed my opinion on removing the realm, though, since Stephen
>  provided patches to run newer sssd on el5 and who knows what nsupdate
>  versions are on the BSDs..
>  
>  So ACK to the patch. 
Pushed to master.

[Lukas Slebodnik]

On (07/04/14 19:18), Jakub Hrozek wrote:
> On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
> > On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
> > > ehlo,
> > > 
> > > I found a warning "zero-length gnu_printf format string" when I was
> testing
> > > patches on ALT linux. It is in the ifdef section if nsupdate do not have
> > > support for realm.
> > > 
> > > Simple patch attached.
> > > 
> > > LS
> > 
> > Given that this patch is intended for master only and given that
> > nsupdate has had support for realm for a long time now, would it make
> > more sense to remove the legacy code instead? I'd prefer to remove the
> > ifdefs in master where possible :-)
>
> This thread has stalled.
>
> I changed my opinion on removing the realm, though, since Stephen
> provided patches to run newer sssd on el5 
Which patches do you mean?

LS

>  and who knows what nsupdate
> versions are on the BSDs..
>
> So ACK to the patch.

[Jakub Hrozek]

On Mon, Apr 07, 2014 at 08:07:45PM +0200, Lukas Slebodnik wrote:
>  On (07/04/14 19:18), Jakub Hrozek wrote:
>  >On Wed, Feb 12, 2014 at 11:12:41PM +0100, Jakub Hrozek wrote:
>  >> On Wed, Feb 12, 2014 at 08:57:01PM +0100, Lukas Slebodnik wrote:
>  >> > ehlo,
>  >> > 
>  >> > I found a warning "zero-length gnu_printf format string" when I
> was testing
>  >> > patches on ALT linux. It is in the ifdef section if nsupdate do not have
>  >> > support for realm.
>  >> > 
>  >> > Simple patch attached.
>  >> > 
>  >> > LS
>  >> 
>  >> Given that this patch is intended for master only and given that
>  >> nsupdate has had support for realm for a long time now, would it make
>  >> more sense to remove the legacy code instead? I'd prefer to remove the
>  >> ifdefs in master where possible :-)
>  >
>  >This thread has stalled.
>  >
>  >I changed my opinion on removing the realm, though, since Stephen
>  >provided patches to run newer sssd on el5
>  Which patches do you mean?
>  
>  LS 
Stephen has a COPR repo which builds 1.9 on el5:
http://copr-fe.cloud.fedoraproject.org/coprs/sgallagh/sssd-1.9-rhel5/

I'm not sure if any code changes were needed, actually and I don't have
an el5 VM around to test it.