[PATCHES] Fix assorted issues around the 'force_timeout' option

[Stephen Gallagher]

The manpages and the implementation differed significantly.

Patch 0001: Add some debugging messages to identify the ping timeouts 
for each service/domain.

Patch 0002: Fix the manpages so that 'force_timeout' is listed in the 
SERVICES and DOMAINS sections instead of the monitor section.

Patch 0003: Fix the SSSDConfig API so that the 'force_timeout' option is 
accepted for services and domains (or else consumers of the API like 
ipa-client or authconfig might throw 'unknown option' errors).

[Jakub Hrozek]

On Mon, Nov 05, 2012 at 11:01:07AM -0500, Stephen Gallagher wrote:
> The manpages and the implementation differed significantly.
>
> Patch 0001: Add some debugging messages to identify the ping
> timeouts for each service/domain.

Ack
> Patch 0002: Fix the manpages so that 'force_timeout' is listed in
> the SERVICES and DOMAINS sections instead of the monitor section.

Ack
> Patch 0003: Fix the SSSDConfig API so that the 'force_timeout'
> option is accepted for services and domains (or else consumers of
> the API like ipa-client or authconfig might throw 'unknown option'
> errors).

======================================================================
FAIL: testListOptions (__main__.SSSDConfigTestSSSDDomain)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "././src/config/SSSDConfigTest.py", line 538, in testListOptions
    option)
AssertionError: Option [force_timeout] unexpectedly found

======================================================================
FAIL: testRemoveProvider (__main__.SSSDConfigTestSSSDDomain)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "././src/config/SSSDConfigTest.py", line 877, in testRemoveProvider
    option)
AssertionError: Option [force_timeout] unexpectedly found

[Stephen Gallagher]

On Tue 06 Nov 2012 02:44:09 AM EST, Jakub Hrozek wrote:
> > Patch 0003: Fix the SSSDConfig API so that the 'force_timeout'
> > option is accepted for services and domains (or else consumers of
> > the API like ipa-client or authconfig might throw 'unknown option'
> > errors).
>
> ======================================================================
> FAIL: testListOptions (__main__.SSSDConfigTestSSSDDomain)
>
> Traceback (most recent call last):
>    File "././src/config/SSSDConfigTest.py", line 538, in testListOptions
>      option)
> AssertionError: Option [force_timeout] unexpectedly found
>
> ======================================================================
> FAIL: testRemoveProvider (__main__.SSSDConfigTestSSSDDomain)
>
> Traceback (most recent call last):
>    File "././src/config/SSSDConfigTest.py", line 877, in testRemoveProvider
>      option)
> AssertionError: Option [force_timeout] unexpectedly found

Thanks, I forgot to rerun that. New patches attached

[Jakub Hrozek]

On Tue, Nov 06, 2012 at 08:57:26AM -0500, Stephen Gallagher wrote:
> On Tue 06 Nov 2012 02:44:09 AM EST, Jakub Hrozek wrote:
> > > Patch 0003: Fix the SSSDConfig API so that the 'force_timeout'
> > > option is accepted for services and domains (or else consumers of
> > > the API like ipa-client or authconfig might throw 'unknown option'
> > > errors).
> >
> > ======================================================================
> > FAIL: testListOptions (__main__.SSSDConfigTestSSSDDomain)
> >
> > Traceback (most recent call last):
> >   File "././src/config/SSSDConfigTest.py", line 538, in testListOptions
> >     option)
> > AssertionError: Option [force_timeout] unexpectedly found
> >
> > ======================================================================
> > FAIL: testRemoveProvider (__main__.SSSDConfigTestSSSDDomain)
> >
> > Traceback (most recent call last):
> >   File "././src/config/SSSDConfigTest.py", line 877, in testRemoveProvider
> >     option)
> > AssertionError: Option [force_timeout] unexpectedly found
>
> Thanks, I forgot to rerun that. New patches attached

Ack

[Jakub Hrozek]

On Thu, Nov 08, 2012 at 10:30:02AM +0100, Jakub Hrozek wrote:
> On Tue, Nov 06, 2012 at 08:57:26AM -0500, Stephen Gallagher wrote:
> > On Tue 06 Nov 2012 02:44:09 AM EST, Jakub Hrozek wrote:
> > > > Patch 0003: Fix the SSSDConfig API so that the 'force_timeout'
> > > > option is accepted for services and domains (or else consumers of
> > > > the API like ipa-client or authconfig might throw 'unknown option'
> > > > errors).
> > >
> > > ======================================================================
> > > FAIL: testListOptions (__main__.SSSDConfigTestSSSDDomain)
> > >
> > > Traceback (most recent call last):
> > >   File "././src/config/SSSDConfigTest.py", line 538, in testListOptions
> > >     option)
> > > AssertionError: Option [force_timeout] unexpectedly found
> > >
> > > ======================================================================
> > > FAIL: testRemoveProvider (__main__.SSSDConfigTestSSSDDomain)
> > >
> > > Traceback (most recent call last):
> > >   File "././src/config/SSSDConfigTest.py", line 877, in testRemoveProvider
> > >     option)
> > > AssertionError: Option [force_timeout] unexpectedly found
> >
> > Thanks, I forgot to rerun that. New patches attached
>
> Ack

Pushed to master and sssd-1-9