On (02/06/14 20:18), Jakub Hrozek wrote:
Hi,
this time it's not a straight cherry-pick but a rebase, because starting
with 1.10 the LDAP provider files were split bit differently. But the
code itself is the same, just moved elsewhere.
The attached patches also include fixes we found after we pushed the
original patches.
From 7b9ad4d28e0cdd1ef7d7ea6053aa4f67bd2d9a33 Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Mon, 21 Apr 2014 21:33:36 +0200
Subject: [PATCH 1/4] LDAP: Fix off-by-one bug in sdap_copy_opts
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The sdap_copy_opts function copied all the arguments except for the
sentinel.
Reviewed-by: Simo Sorce <simo(a)redhat.com>
Reviewed-by: Pavel Březina <pbrezina(a)redhat.com>
(cherry picked from commit fcb8e3f1f49bb34c409d8dbd75889eb72be05517)
---
/usr/bin/ld: src/providers/ldap/ipa_ldap_opt_tests-sdap.o: undefined
reference to symbol 'ber_free'
/usr/bin/ld: note: 'ber_free' is defined in DSO /lib64/liblber-2.4.so.2 so try
adding it to the linker command line
/lib64/liblber-2.4.so.2: could not read symbols: Invalid operation
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Problem fixed in master with:
commit d12c95d840ed5de7f34e21002943c48e711a33f4
Author: Lukas Slebodnik <lslebodn(a)redhat.com>
Date: Fri May 2 16:13:58 2014 +0200
TEST: Link ipa_ldap_opt test with openldap libs
LS