4:59 a.m.
URL: https://github.com/SSSD/sssd/pull/351
Author: lslebodn
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Action: opened
PR body:
"""
We always check negcache after getting data from backend since commit
4c09cd008967c5c0ec358dc658ffc6fc1cef2697 because we usually do have a name
in begging of requests "* by ID".
We were not interested in name in request sid by id before. However, function
cache_req_search_ncache_filter always expect name otherwise it returns
ERR_INTERNAL.
[sssd[nss]] [cache_req_set_plugin] (0x2000): CR #8: Setting "Object by ID"
plugin
[sssd[nss]] [cache_req_send] (0x0400): CR #8: New request 'Object by ID'
[sssd[nss]] [cache_req_select_domains] (0x0400): CR #8: Performing a multi-domain search
[sssd[nss]] [cache_req_search_domains] (0x0400): CR #8: Search will check the cache and
check the data provider
[sssd[nss]] [cache_req_validate_domain_type] (0x2000): Request type POSIX-only for domain
sssdad2012r2.com type POSIX is valid
[sssd[nss]] [cache_req_set_domain] (0x0400): CR #8: Using domain [sssdad2012r2.com]
[sssd[nss]] [cache_req_search_send] (0x0400): CR #8: Looking up
ID:233600513@sssdad2012r2.com
[sssd[nss]] [cache_req_search_ncache] (0x0400): CR #8: Checking negative cache for
[ID:233600513@sssdad2012r2.com]
[sssd[nss]] [sss_ncache_check_str] (0x2000): Checking negative cache for
[NCE/UID/sssdad2012r2.com/233600513]
[sssd[nss]] [cache_req_search_ncache] (0x0400): CR #8: [ID:233600513@sssdad2012r2.com] is
not present in negative cache
[sssd[nss]] [cache_req_search_cache] (0x0400): CR #8: Looking up
[ID:233600513@sssdad2012r2.com] in cache
[sssd[nss]] [cache_req_search_send] (0x0400): CR #8: Returning
[ID:233600513@sssdad2012r2.com] from cache
[sssd[nss]] [cache_req_search_ncache_filter] (0x0400): CR #8: Filtering out results by
negative cache
[sssd[nss]] [cache_req_search_ncache_filter] (0x0020): CR #8: sss_get_name_from_msg()
returned NULL, which should never happen in this scenario!
[sssd[nss]] [cache_req_process_result] (0x0400): CR #8: Finished: Error 1432158209:
Internal Error
[sssd[nss]] [nss_protocol_done] (0x4000): Sending reply: error [1432158209]: Internal
Error
[sssd[nss]] [client_recv] (0x0200): Client disconnected!
Resolves:
https://pagure.io/SSSD/sssd/issue/3485
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/351/head:pr351
git checkout pr351
5:01 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
Another solution would be soften requirement for attribute NAME in
`cache_req_search_ncache_filter`
@pbrezina what do you think :-)
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-323702163
5:11 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
fidencio commented:
"""
@lslebodn ... seems that nss_cmd_getsidbyid() is the only function using object_by_id().
Knowing that, I'd also suggest to take a look at
responder/common/cache_req/plugins/cache_req_object_by_id.c in the
cache_req_object_by_id_ncache_filter() function to be sure that's what we really want
...
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-323704428
8:15 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
On (21/08/17 03:11), fidencio wrote:
@lslebodn ... seems that nss_cmd_getsidbyid() is the only function
using object_by_id().
Knowing that, I'd also suggest to take a look at
responder/common/cache_req/plugins/cache_req_object_by_id.c in the
cache_req_object_by_id_ncache_filter() function to be sure that's what we really want
...
Feel free to look there. I need to hunt other bugs.
Current version of PR just allows me to debug other things.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-323741632
8:26 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
On (21/08/17 03:11), fidencio wrote:
@lslebodn ... seems that nss_cmd_getsidbyid() is the only function
using object_by_id().
Knowing that, I'd also suggest to take a look at
responder/common/cache_req/plugins/cache_req_object_by_id.c in the
cache_req_object_by_id_ncache_filter() function to be sure that's what we really want
...
Feel free to look there and file ticket(s). I need to hunt other bugs.
Current version of PR just allows me to debug other things.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-323741632
8:29 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
pbrezina commented:
"""
Since we depend on name attribute here, we should make it part of default attributes that
are merged to the requested attributes in `cache_req_data_create_attrs`.
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-324026162
2:31 p.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
jhrozek commented:
"""
Setting Changes requested as per @pbrezina's last comment
(note that this is NOT a nudge for anyone to work faster, I'm just reconciling the PR
statuses)
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-325454974
2:31 p.m.
New subject: [sssd PR#351][+Changes requested] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Label: +Changes requested
5:08 a.m.
New subject: [sssd PR#351][synchronized] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Author: lslebodn
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/351/head:pr351
git checkout pr351
5:09 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
sorry for long response. I'll provide intg test soon in PR. It needn't block this
bug fix.
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327132296
5:09 a.m.
New subject: [sssd PR#351][-Changes requested] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Label: -Changes requested
8:26 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
pbrezina commented:
"""
These attributes are consumed by `sss_get_name_from_msg` called from
`cache_req_search_ncache_filter`.
This function returns the name in the following order:
1. OVERRIDE_PREFIX SYSDB_NAME
2. SYSDB_DEFAULT_OVERRIDE_NAME
3. SYSDB_NAME
The first two should be added by `sysdb...with_views` searches so only `SYSDB_NAME` is
required. The `ORIGINALAD_PREFIX SYSDB_NAME` is not needed. Or was it required by
something else?
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327174366
8:46 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
sumit-bose commented:
"""
The ORIGINALAD_PREFIX SYSDB_NAME is needed for sid_to_name requests. Sorry, I haven't
check if the sid_to_name code-patch is involed here.
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327179929
8:58 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
pbrezina commented:
"""
But why should it be needed in `cache_req_search_ncache_filter` where it isn't used? I
guess I'm missing something.
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327183601
9:57 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
But why should it be needed in cache_req_search_ncache_filter where it
isn't used? I guess I'm missing something.
It is not directly used by `cache_req_search_ncache_filter` but it is used by
`sss_get_name_from_msg` which is called in `cache_req_search_ncache_filter` as you can see
in debug messages.
https://pagure.io/SSSD/sssd/blob/master/f/src/responder/common/cache_req/...
Anyway. I noticed that `SYSDB_DEFAULT_OVERRIDE_NAME` should be probably added as well
because it is used in `sss_get_name_from_msg`
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327202254
10:24 a.m.
New subject: [sssd PR#351][synchronized] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Author: lslebodn
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/351/head:pr351
git checkout pr351
2:49 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
pbrezina commented:
"""
```c
const char *
sss_get_name_from_msg(struct sss_domain_info *domain,
struct ldb_message *msg)
{
const char *name;
/* If domain has a view associated we return overridden name
* if possible. */
if (DOM_HAS_VIEWS(domain)) {
name = ldb_msg_find_attr_as_string(msg, OVERRIDE_PREFIX SYSDB_NAME,
NULL);
if (name != NULL) {
return name;
}
}
/* Otherwise we try to return name override from
* Default Truest View for trusted users. */
name = ldb_msg_find_attr_as_string(msg, SYSDB_DEFAULT_OVERRIDE_NAME, NULL);
if (name != NULL) {
return name;
}
/* If no override is found we return the original name. */
return ldb_msg_find_attr_as_string(msg, SYSDB_NAME, NULL);
}
```
I don't see `ORIGINALAD_PREFIX SYSDB_NAME` here...
However I thought that the override attributes are added automatically but they are not so
all three of these attributes need to be there.
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327404156
3:10 a.m.
New subject: [sssd PR#351][synchronized] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Author: lslebodn
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/351/head:pr351
git checkout pr351
3:12 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
On (06/09/17 00:49), Pavel Březina wrote:
I don't see `ORIGINALAD_PREFIX SYSDB_NAME` here...
Nice catch. i have no idea where I found `ORIGINALAD_PREFIX ...`.
However I thought that the override attributes are added automatically
but
they are not so all three of these attributes need to be there.
New version pushed.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327409597
6:03 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
pbrezina commented:
"""
Ack.
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327450226
6:04 a.m.
New subject: [sssd PR#351][+Accepted] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Label: +Accepted
6:16 a.m.
New subject: [sssd PR#351][closed] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Author: lslebodn
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/351/head:pr351
git checkout pr351
6:17 a.m.
New subject: [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
lslebodn commented:
"""
master:
* 2e72ababbbadda4c4036f99528460c1d595e0941
"""
See the full comment at https://github.com/SSSD/sssd/pull/351#issuecomment-327452904
6:17 a.m.
New subject: [sssd PR#351][+Pushed] NSS: Look for name attribute also in nss_cmd_getsidbyid
URL: https://github.com/SSSD/sssd/pull/351
Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid
Label: +Pushed
2438
days inactive
2454
days old
sssd-devel@lists.fedorahosted.org
23 comments
5 participants
participants (5)
-
fidencio -
jhrozek
-
lslebodn
-
pbrezina
-
sumit-bose