Hi,
the attached patches work around the Samba bug https://bugzilla.samba.org/show_bug.cgi?id=11036
To reproduce, set a high "log level" in smb.conf and attempt to log in. At least with RHEL-7.1's Samba version, the gpo_child output would contain error messages unless there is a file called /root/.smb/smb.conf exists. Then processing the buffer gpo_child sends to parent would fail.
I'm not thrilled about using such a heavy-weight change and special-casing where gpo_child sends output but I couldn't think of a different fix.
I'll include unit test for the child_common change along with the other child_common tests (it's easier to build upon them).
On Wed, Jan 07, 2015 at 11:56:24AM +0100, Jakub Hrozek wrote:
Hi,
the attached patches work around the Samba bug https://bugzilla.samba.org/show_bug.cgi?id=11036
To reproduce, set a high "log level" in smb.conf and attempt to log in. At least with RHEL-7.1's Samba version, the gpo_child output would contain error messages unless there is a file called /root/.smb/smb.conf exists. Then processing the buffer gpo_child sends to parent would fail.
I'm not thrilled about using such a heavy-weight change and special-casing where gpo_child sends output but I couldn't think of a different fix.
I'll include unit test for the child_common change along with the other child_common tests (it's easier to build upon them).
This one is needed to fix https://bugzilla.redhat.com/show_bug.cgi?id=1177140, too.
On Wed, Jan 07, 2015 at 11:56:24AM +0100, Jakub Hrozek wrote:
Hi,
the attached patches work around the Samba bug https://bugzilla.samba.org/show_bug.cgi?id=11036
To reproduce, set a high "log level" in smb.conf and attempt to log in. At least with RHEL-7.1's Samba version, the gpo_child output would contain error messages unless there is a file called /root/.smb/smb.conf exists. Then processing the buffer gpo_child sends to parent would fail.
I'm not thrilled about using such a heavy-weight change and special-casing where gpo_child sends output but I couldn't think of a different fix.
I'll include unit test for the child_common change along with the other child_common tests (it's easier to build upon them).
ACK, patches are working as advertised.
bye, Sumit
On Tue, Jan 13, 2015 at 05:01:10PM +0100, Sumit Bose wrote:
On Wed, Jan 07, 2015 at 11:56:24AM +0100, Jakub Hrozek wrote:
Hi,
the attached patches work around the Samba bug https://bugzilla.samba.org/show_bug.cgi?id=11036
To reproduce, set a high "log level" in smb.conf and attempt to log in. At least with RHEL-7.1's Samba version, the gpo_child output would contain error messages unless there is a file called /root/.smb/smb.conf exists. Then processing the buffer gpo_child sends to parent would fail.
I'm not thrilled about using such a heavy-weight change and special-casing where gpo_child sends output but I couldn't think of a different fix.
I'll include unit test for the child_common change along with the other child_common tests (it's easier to build upon them).
ACK, patches are working as advertised.
bye, Sumit
Thank you for the review, pushed upstream:
master: f00a61b6079d8de81432077a59daf015d85800d2 16cb0969f0a9ea71524d852077d6a480740d4f12 bb7ddd2be9847bfb07395341c7623da1b104b8a6 sssd-1-12: f00a61b6079d8de81432077a59daf015d85800d2 16cb0969f0a9ea71524d852077d6a480740d4f12 bb7ddd2be9847bfb07395341c7623da1b104b8a6
On Tue, Jan 13, 2015 at 05:59:11PM +0100, Jakub Hrozek wrote:
sssd-1-12: f00a61b6079d8de81432077a59daf015d85800d2 16cb0969f0a9ea71524d852077d6a480740d4f12 bb7ddd2be9847bfb07395341c7623da1b104b8a6
Sorry, the correct commit hashes for sssd-1-12 are: fc62521e72eb9ed8336e4797f2cd9c89d8b013f1 d31fba405f3392f27f0eea861834083cfaa0ef10 9740d8a555dee2e41294f6e4acf558e4998656d9
sssd-devel@lists.fedorahosted.org