On Tue, Jan 13, 2015 at 05:01:10PM +0100, Sumit Bose wrote:
On Wed, Jan 07, 2015 at 11:56:24AM +0100, Jakub Hrozek wrote:
> the attached patches work around the Samba bug
> To reproduce, set a high "log level" in smb.conf and attempt to log in.
> At least with RHEL-7.1's Samba version, the gpo_child output would
> contain error messages unless there is a file called /root/.smb/smb.conf
> exists. Then processing the buffer gpo_child sends to parent would fail.
> I'm not thrilled about using such a heavy-weight change and
> special-casing where gpo_child sends output but I couldn't think of a
> different fix.
> I'll include unit test for the child_common change along with the other
> child_common tests (it's easier to build upon them).
ACK, patches are working as advertised.
Thank you for the review, pushed upstream: