[PATCH] Document ldap_chpass_update_last_change

[Jakub Hrozek]

The option was missing from manual pages and the configAPI.

[Pavel Březina]

On 10/01/2012 12:29 AM, Jakub Hrozek wrote:
> The option was missing from manual pages and the configAPI.
>                   <varlistentry>
>                <term>ldap_chpass_last_change (bool)</term>
>                <listitem>
>                    <para>
>                        Specifies whether to update the
>                        ldap_user_shadow_last_change attribute with
>                        days since the Epoch after a password change
>                        operation.
>                    </para>
>                    <para>
>                        Default: False
>                    </para>
>                </listitem>
>            </varlistentry>

Nack.
Isn't the option ldap_chpass_*update*_last_change?

[Jakub Hrozek]

On Mon, Oct 01, 2012 at 03:22:15PM +0200, Pavel Březina wrote:
> On 10/01/2012 12:29 AM, Jakub Hrozek wrote:
> > The option was missing from manual pages and the configAPI.
> >                  <varlistentry>
> >                <term>ldap_chpass_last_change (bool)</term>
> >                <listitem>
> >                    <para>
> >                        Specifies whether to update the
> >                        ldap_user_shadow_last_change attribute with
> >                        days since the Epoch after a password change
> >                        operation.
> >                    </para>
> >                    <para>
> >                        Default: False
> >                    </para>
> >                </listitem>
> >            </varlistentry>
>
> Nack.
> Isn't the option ldap_chpass_*update*_last_change?

Yes, that's a typo..thanks!

[Pavel Březina]

On 10/01/2012 04:44 PM, Jakub Hrozek wrote:
> On Mon, Oct 01, 2012 at 03:22:15PM +0200, Pavel Březina wrote:
> > On 10/01/2012 12:29 AM, Jakub Hrozek wrote:
> > > The option was missing from manual pages and the configAPI.
> > >                   <varlistentry>
> > >                <term>ldap_chpass_last_change (bool)</term>
> > >                <listitem>
> > >                    <para>
> > >                        Specifies whether to update the
> > >                        ldap_user_shadow_last_change attribute with
> > >                        days since the Epoch after a password change
> > >                        operation.
> > >                    </para>
> > >                    <para>
> > >                        Default: False
> > >                    </para>
> > >                </listitem>
> > >            </varlistentry>
> >
> > Nack.
> > Isn't the option ldap_chpass_*update*_last_change?
>
> Yes, that's a typo..thanks!

Sorry, one more nack. It is also missing in __init__.py.in.

[Jakub Hrozek]

On Mon, Oct 01, 2012 at 04:57:17PM +0200, Pavel Březina wrote:
> On 10/01/2012 04:44 PM, Jakub Hrozek wrote:
> > On Mon, Oct 01, 2012 at 03:22:15PM +0200, Pavel Březina wrote:
> > > On 10/01/2012 12:29 AM, Jakub Hrozek wrote:
> > > > The option was missing from manual pages and the configAPI.
> > > >                  <varlistentry>
> > > >                <term>ldap_chpass_last_change (bool)</term>
> > > >                <listitem>
> > > >                    <para>
> > > >                        Specifies whether to update the
> > > >                        ldap_user_shadow_last_change attribute with
> > > >                        days since the Epoch after a password change
> > > >                        operation.
> > > >                    </para>
> > > >                    <para>
> > > >                        Default: False
> > > >                    </para>
> > > >                </listitem>
> > > >            </varlistentry>
> > >
> > > Nack.
> > > Isn't the option ldap_chpass_*update*_last_change?
> >
> > Yes, that's a typo..thanks!
>
> Sorry, one more nack. It is also missing in __init__.py.in.

Thank you for the careful review. A new patch is attached.

[Pavel Březina]

On 10/01/2012 06:17 PM, Jakub Hrozek wrote:
> On Mon, Oct 01, 2012 at 04:57:17PM +0200, Pavel Březina wrote:
> > On 10/01/2012 04:44 PM, Jakub Hrozek wrote:
> > > On Mon, Oct 01, 2012 at 03:22:15PM +0200, Pavel Březina wrote:
> > > > On 10/01/2012 12:29 AM, Jakub Hrozek wrote:
> > > > > The option was missing from manual pages and the configAPI.
> > > > >                   <varlistentry>
> > > > >                <term>ldap_chpass_last_change (bool)</term>
> > > > >                <listitem>
> > > > >                    <para>
> > > > >                        Specifies whether to update the
> > > > >                        ldap_user_shadow_last_change attribute with
> > > > >                        days since the Epoch after a password change
> > > > >                        operation.
> > > > >                    </para>
> > > > >                    <para>
> > > > >                        Default: False
> > > > >                    </para>
> > > > >                </listitem>
> > > > >            </varlistentry>
> > > >
> > > > Nack.
> > > > Isn't the option ldap_chpass_*update*_last_change?
> > >
> > > Yes, that's a typo..thanks!
> >
> > Sorry, one more nack. It is also missing in __init__.py.in.
>
> Thank you for the careful review. A new patch is attached.

Ack.

[Jakub Hrozek]

On Mon, Oct 01, 2012 at 07:34:24PM +0200, Pavel Březina wrote:
> On 10/01/2012 06:17 PM, Jakub Hrozek wrote:
> > On Mon, Oct 01, 2012 at 04:57:17PM +0200, Pavel Březina wrote:
> > > On 10/01/2012 04:44 PM, Jakub Hrozek wrote:
> > > > On Mon, Oct 01, 2012 at 03:22:15PM +0200, Pavel Březina wrote:
> > > > > On 10/01/2012 12:29 AM, Jakub Hrozek wrote:
> > > > > > The option was missing from manual pages and the configAPI.
> > > > > >                  <varlistentry>
> > > > > >                <term>ldap_chpass_last_change (bool)</term>
> > > > > >                <listitem>
> > > > > >                    <para>
> > > > > >                        Specifies whether to update the
> > > > > >                        ldap_user_shadow_last_change attribute with
> > > > > >                        days since the Epoch after a password change
> > > > > >                        operation.
> > > > > >                    </para>
> > > > > >                    <para>
> > > > > >                        Default: False
> > > > > >                    </para>
> > > > > >                </listitem>
> > > > > >            </varlistentry>
> > > > >
> > > > > Nack.
> > > > > Isn't the option ldap_chpass_*update*_last_change?
> > > >
> > > > Yes, that's a typo..thanks!
> > >
> > > Sorry, one more nack. It is also missing in __init__.py.in.
> >
> > Thank you for the careful review. A new patch is attached.
>
> Ack.

Pushed to master.