[sssd PR#353][opened] libwbclient: Change return code for wbcAuthenticateUserEx

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/353
Author: lslebodn
 Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx
Action: opened

PR body:
"""
Samba-4.6 change behaviour of few functions
New version of code make sure session info for user is stored in cache.
It is a performance optimisation to prevent contacting KDC for each
session. More details in samba bug
https://bugzilla.samba.org/show_bug.cgi?id=11259

Old return code WBC_SSSD_NOT_IMPLEMENTED was translated
to NT_STATUS_LOGON_FAILURE which caused many failures.

    [2017/08/21 11:34:15.044321,  5, pid=27742, effective(0, 0), real(0, 0)]
    ../libcli/security/security_token.c:53(security_token_debug)
      Security token: (NULL)
    [2017/08/21 11:34:15.044330,  5, pid=27742, effective(0, 0), real(0, 0)]
    ../source3/auth/token_util.c:640(debug_unix_user_token)
      UNIX token of user 0
      Primary group is 0 and contains 0 supplementary groups
    [2017/08/21 11:34:15.044349,  4, pid=27742, effective(0, 0), real(0, 0)]
    ../source3/smbd/sec_ctx.c:439(pop_sec_ctx)
      pop_sec_ctx (0, 0) - sec_ctx_stack_ndx = 0
    [2017/08/21 11:34:15.044360,  1, pid=27742, effective(0, 0), real(0, 0)]
    ../source3/smbd/sesssetup.c:290(reply_sesssetup_and_X_spnego)
      Failed to generate session_info (user and group token) for session
    setup: NT_STATUS_LOGON_FAILURE

Resolves:
https://pagure.io/SSSD/sssd/issue/3461
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/353/head:pr353
git checkout pr353

[sssd PR#353][comment] libwbclient: Change return code for wbcAuthenticateUserEx

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/353
Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx

lslebodn commented:
"""
@sumit-bose this PR + #351 together improves situation with sssd-libwbclient and
samba-4.6
"""

See the full comment at https://github.com/SSSD/sssd/pull/353#issuecomment-323998255

[sssd PR#353][comment] libwbclient: Change return code for wbcAuthenticateUserEx

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/353
Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx

sumit-bose commented:
"""
@lslebodn, thank you for taking case of this. For this PR is it a plain ACK from me. Imo
#351 is fine as well but I would prefer the hear if @pbrezina has any comments. Please let
me know if there is some urgency, in this case I would ACK #351 as well.

"""

See the full comment at https://github.com/SSSD/sssd/pull/353#issuecomment-324002611

[sssd PR#353][+Accepted] libwbclient: Change return code for wbcAuthenticateUserEx

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/353
Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx

Label: +Accepted

[sssd PR#353][comment] libwbclient: Change return code for wbcAuthenticateUserEx

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/353
Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx

jhrozek commented:
"""
* master: 725d04cd21016dc6092a9f03cd363bb83d7c054c
"""

See the full comment at https://github.com/SSSD/sssd/pull/353#issuecomment-324029049

[sssd PR#353][closed] libwbclient: Change return code for wbcAuthenticateUserEx

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/353
Author: lslebodn
 Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/353/head:pr353
git checkout pr353

[sssd PR#353][+Pushed] libwbclient: Change return code for wbcAuthenticateUserEx

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/353
Title: #353: libwbclient: Change return code for wbcAuthenticateUserEx

Label: +Pushed