URL: https://github.com/SSSD/sssd/pull/5922 Author: ikerexxe Title: #5922: [WIP] test: fix pep8 complaint Action: opened
PR body: """ Fix pep8 complaint about over-indentation in test_multidomain.py file. I guess this is only happening in RHEL8 and Debian because the tool was forked to pycodestyle, only it is being updated and pycodestyle isn't available for those distributions from the package manager. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5922/head:pr5922 git checkout pr5922
URL: https://github.com/SSSD/sssd/pull/5922 Author: ikerexxe Title: #5922: test: fix pep8 complaint Action: edited
Changed field: body Original value: """ Fix pep8 complaint about over-indentation in test_multidomain.py file. I guess this is only happening in RHEL8 and Debian because the tool was forked to pycodestyle, only it is being updated and pycodestyle isn't available for those distributions from the package manager. """
Changed field: title Original value: """ [WIP] test: fix pep8 complaint """
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
ikerexxe commented: """ @sidecontrol can you review this PR? It solves our current problems with the python code style tool and I don't know if you already solved them. """
See the full comment at https://github.com/SSSD/sssd/pull/5922#issuecomment-995553373
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
ikerexxe commented: """ @sidecontrol can you set the accepted label? """
See the full comment at https://github.com/SSSD/sssd/pull/5922#issuecomment-995911367
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
alexey-tikhonov commented: """ ACK for the patch.
But why newer `pycodestyle` doesn't complain about this? """
See the full comment at https://github.com/SSSD/sssd/pull/5922#issuecomment-995921833
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
ikerexxe commented: """
But why newer `pycodestyle` doesn't complain about this?
I think it's because the tool was modified after its name was changed. I've found https://github.com/PyCQA/pycodestyle/pull/912 that changes the implementation of the visual indentation checks. This change only applies for tags 2.X, which belong to pycodestyle (tags 1.X are for pep8). But I'm not completely sure about what it does apart from specifying some special treatment for `assert`, `raise` and `with` keywords.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5922#issuecomment-995940289
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
alexey-tikhonov commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5922
* `master` * 46843d021376df33455977526e2c79b5c2092890 - test: fix pep8 complaint
"""
See the full comment at https://github.com/SSSD/sssd/pull/5922#issuecomment-995958033
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5922 Title: #5922: test: fix pep8 complaint
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5922 Author: ikerexxe Title: #5922: test: fix pep8 complaint Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5922/head:pr5922 git checkout pr5922
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
ikerexxe