[PATCH] LDAP: Use the common get_uppercase_realm to uppercase the realm

[Jakub Hrozek]

Hi,

attached is a simple clan-up patch.

[Pavel Březina]

On 02/25/2016 02:04 PM, Jakub Hrozek wrote:
>  Hi,
>
>  attached is a simple clan-up patch. 
Hi,
make_realm_upper_case also contains a check that returns the original 
string if delimiter is not found. Are we sure it is safe to remove this 
test?

Can you also rename get_uppercase_realm to something more general since 
it is not really realm specific? Maybe get_uppercase_string? Or 
sss_talloc_toupper?

[Jakub Hrozek]

On Fri, Feb 26, 2016 at 10:47:13AM +0100, Pavel Březina wrote:
>  On 02/25/2016 02:04 PM, Jakub Hrozek wrote:
>  >Hi,
>  >
>  >attached is a simple clan-up patch.
>  
>  Hi,
>  make_realm_upper_case also contains a check that returns the original string
>  if delimiter is not found. Are we sure it is safe to remove this test? 
Ugh, of course the patch is wrong, it would uppercase the whole
principal and not just the realm.

Sorry about that..