[sssd PR#389][opened] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/389
Author: sumit-bose
 Title: #389: sssd_client: add mutex protected call to the PAC responder
Action: opened

PR body:
"""
SSSD's plugin for MIT Kerberos to send the PAC to the PAC responder
currently uses sss_pac_make_request() which does not protect the
communication with the PAC responder with a mutex as e.g. the NSS and
PAM clients.

If an application using threads loads this plugin via libkrb5 in
different threads and is heavily processing Kerberos tickets with PACs
chances are that two threads try to communicate with SSSD at once. In
this case one of the threads will miss a reply and will wait for it
until the default client timeout of 300s is passed.

This patch adds a call which uses a mutex to protect the communication
which will avoid the 300s delay mentioned above.

Resolves https://pagure.io/SSSD/sssd/issue/3518
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/389/head:pr389
git checkout pr389

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

fidencio commented:
"""
Code-wise this patch looks good. Personally I'd split this patch in a few parts, but I
don't think it's worth asking you to do so.

There's a small comment about a issue number that you forgot to mention (and that can
be fixed before pushing). I'm firing a CI build now.
"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-330889037

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

fidencio commented:
"""
CI: http://vm-058-233.${abc}/logs/job/78/03/summary.html
"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-330978212

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

fidencio commented:
"""
@sumit-bose: Can you just fix that nitpick and I'll add the Accepted label after
that?
"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-330978359

[sssd PR#389][synchronized] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/389
Author: sumit-bose
 Title: #389: sssd_client: add mutex protected call to the PAC responder
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/389/head:pr389
git checkout pr389

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

sumit-bose commented:
"""
@fidencio, fixed, thank you for the review.
"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-331075683

[sssd PR#389][+Accepted] sssd_client: add mutex protected call to the PAC responder

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

Label: +Accepted

[sssd PR#389][-Accepted] sssd_client: add mutex protected call to the PAC responder

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

Label: -Accepted

[sssd PR#389][+Changes requested] sssd_client: add mutex protected call to the PAC responder

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

Label: +Changes requested

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

sumit-bose commented:
"""
@lslebodn, what changes are you requesting?
"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-331155346

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

lslebodn commented:
"""
On (21/09/17 06:25), sumit-bose wrote:
> @lslebodn, what changes are you requesting?
>  
I had few inline comments/questions.
Sorry for confusion and missing context.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-331166108

[sssd PR#389][synchronized] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/389
Author: sumit-bose
 Title: #389: sssd_client: add mutex protected call to the PAC responder
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/389/head:pr389
git checkout pr389

[sssd PR#389][synchronized] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

   URL: https://github.com/SSSD/sssd/pull/389
Author: sumit-bose
 Title: #389: sssd_client: add mutex protected call to the PAC responder
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/389/head:pr389
git checkout pr389

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

sumit-bose commented:
"""
new version pushed
"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-331189434

[sssd PR#389][-Changes requested] sssd_client: add mutex protected call to the PAC responder

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

Label: -Changes requested

[sssd PR#389][comment] sssd_client: add mutex protected call to the PAC responder

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

lslebodn commented:
"""
Thank you for comments.

master:
* 1f331476e7d33bb03cc35a2a9064ee1cc5bed6cf
"""

See the full comment at https://github.com/SSSD/sssd/pull/389#issuecomment-331462263

[sssd PR#389][closed] sssd_client: add mutex protected call to the PAC responder

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/389
Author: sumit-bose
 Title: #389: sssd_client: add mutex protected call to the PAC responder
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/389/head:pr389
git checkout pr389

[sssd PR#389][+Pushed] sssd_client: add mutex protected call to the PAC responder

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/389
Title: #389: sssd_client: add mutex protected call to the PAC responder

Label: +Pushed