[PATCH] WIP: PROXY: Adding proxy_max_children option

[Petr Cech]

Hello,

I am fighting with adding new option to sssd.conf.
I slowly running out of breath.

I know proxy could be id, auth or chpass provider. I don't know
where is the right place for my option. And the second issue is
it breaks test for SSSD config. :-(

Is there anyone who would like to join to the fight? Please,
see attached patch.

Regards

[Fabiano Fidêncio]

Petr,

On Wed, Aug 24, 2016 at 4:22 PM, Petr Cech  wrote:
> Hello,
>
> I am fighting with adding new option to sssd.conf.
> I slowly running out of breath.
>
> I know proxy could be id, auth or chpass provider. I don't know
> where is the right place for my option. And the second issue is
> it breaks test for SSSD config. :-(
>
> Is there anyone who would like to join to the fight? Please,
> see attached patch.

I could spot 1 issue and one possible issue with your patch.
Let me paste the (possible) problematic parts here:
> diff --git a/src/config/SSSDConfig/__init__.py.in b/src/config/SSSDConfig/__init__.py.in
> index b3f04ac26309bb5b518fb87cd0dae2962e853179..50917322da74211a54db69fee05589bdddaebd33 100644
> --- a/src/config/SSSDConfig/__init__.py.in
> +++ b/src/config/SSSDConfig/__init__.py.in
> @@ -435,6 +435,7 @@ option_strings = {
>      'proxy_fast_alias' : _('Whether to look up canonical group name from cache if possible'),
>  # [provider/proxy/auth]
> 'proxy_max_children' : _('The number of preforked proxy children.'),
> 'proxy_pam_target' : _('PAM stack to use')
>
> }

As far as I understand from the ticket, proxy_max_children should be a
global option for proxy, so you should put it ander [provider/proxy]
and not under [provider/proxy/auth].
> diff --git a/src/config/etc/sssd.api.d/sssd-proxy.conf b/src/config/etc/sssd.api.d/sssd-proxy.conf
> index 89a6503..96e2d4a 100644
> --- a/src/config/etc/sssd.api.d/sssd-proxy.conf
> +++ b/src/config/etc/sssd.api.d/sssd-proxy.conf
> @@ -1,11 +1,9 @@
> -[provider/proxy]
>
> [provider/proxy/i
>  proxy_lib_name = str, None, true
>  proxy_fast_alias = bool, None, true
>
> [provider/proxy/auth]
>   proxy_pam_target = str, None, true
> +proxy_max_children = int, None, false
>
> [provider/proxy/chpass]

On this part I'm pretty sure you don't want to remove [provider/proxy]
neither the last line of the file.
And as far as I understand from the option you're trying to add, it
should be added under [provider/proxy].

With these 2 changes "make check" passes again and I guess it's enough
for what you're trying to achieve.

Here you can see my changes on top of your changes:
[ffidenci@cat x86_64]$ git diff
diff --git a/src/config/SSSDConfig/__init__.py.in
b/src/config/SSSDConfig/__init__.py.in
index 5091732..9076dd2 100644
--- a/src/config/SSSDConfig/__init__.py.in
+++ b/src/config/SSSDConfig/__init__.py.in
@@ -430,12 +430,14 @@ option_strings = {
     'default_shell' : _('Default shell, /bin/bash'),
     'base_directory' : _('Base for home directories'),

+    # [provider/proxy]
+    'proxy_max_children' : _('The number of preforked proxy children.'),
+
     # [provider/proxy/id]
     'proxy_lib_name' : _('The name of the NSS library to use'),
     'proxy_fast_alias' : _('Whether to look up canonical group name
from cache if possible'),

# [provider/proxy/auth]
-    'proxy_max_children' : _('The number of preforked proxy children.'),
     'proxy_pam_target' : _('PAM stack to use')
 }

diff --git a/src/config/etc/sssd.api.d/sssd-proxy.conf
b/src/config/etc/sssd.api.d/sssd-proxy.conf
index 96e2d4a..09bf82a 100644
--- a/src/config/etc/sssd.api.d/sssd-proxy.conf
+++ b/src/config/etc/sssd.api.d/sssd-proxy.conf
@@ -1,9 +1,12 @@
+[provider/proxy]
+proxy_max_children = int, None, false
+
 [provider/proxy/id]
 proxy_lib_name = str, None, true
 proxy_fast_alias = bool, None, true

[provider/proxy/auth]
 proxy_pam_target = str, None, true
-proxy_max_children = int, None, false

[provider/proxy/chpass]
+

I hope it helps!

Best Regards,
--
Fabiano Fidêncio

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 08/24/2016 05:25 PM, Fabiano Fidêncio wrote:
> Petr,
>
> On Wed, Aug 24, 2016 at 4:22 PM, Petr Cech  wrote:
> > Hello,
> >
> > I am fighting with adding new option to sssd.conf.
> > I slowly running out of breath.
> >
> > I know proxy could be id, auth or chpass provider. I don't know
> > where is the right place for my option. And the second issue is
> > it breaks test for SSSD config. :-(
> >
> > Is there anyone who would like to join to the fight? Please,
> > see attached patch.
>
> I could spot 1 issue and one possible issue with your patch.
> Let me paste the (possible) problematic parts here:
> > diff --git a/src/config/SSSDConfig/__init__.py.in b/src/config/SSSDConfig/__init__.py.in
> > index b3f04ac26309bb5b518fb87cd0dae2962e853179..50917322da74211a54db69fee05589bdddaebd33 100644
> > --- a/src/config/SSSDConfig/__init__.py.in
> > +++ b/src/config/SSSDConfig/__init__.py.in
> > @@ -435,6 +435,7 @@ option_strings = {
> >      'proxy_fast_alias' : _('Whether to look up canonical group name from cache if possible'),
> >  # [provider/proxy/auth]
> > 'proxy_max_children' : _('The number of preforked proxy children.'),
> > 'proxy_pam_target' : _('PAM stack to use')
> >
> > }
>
> As far as I understand from the ticket, proxy_max_children should be a
> global option for proxy, so you should put it ander [provider/proxy]
> and not under [provider/proxy/auth].
> > diff --git a/src/config/etc/sssd.api.d/sssd-proxy.conf b/src/config/etc/sssd.api.d/sssd-proxy.conf
> > index 89a6503..96e2d4a 100644
> > --- a/src/config/etc/sssd.api.d/sssd-proxy.conf
> > +++ b/src/config/etc/sssd.api.d/sssd-proxy.conf
> > @@ -1,11 +1,9 @@
> > -[provider/proxy]
> >
> > [provider/proxy/i
> >  proxy_lib_name = str, None, true
> >  proxy_fast_alias = bool, None, true
> >
> > [provider/proxy/auth]
> >   proxy_pam_target = str, None, true
> > +proxy_max_children = int, None, false
> >
> > [provider/proxy/chpass]
>
> On this part I'm pretty sure you don't want to remove [provider/proxy]
> neither the last line of the file.
> And as far as I understand from the option you're trying to add, it
> should be added under [provider/proxy].
>
> With these 2 changes "make check" passes again and I guess it's enough
> for what you're trying to achieve.
>
> Here you can see my changes on top of your changes:
> [ffidenci@cat x86_64]$ git diff
> diff --git a/src/config/SSSDConfig/__init__.py.in
> b/src/config/SSSDConfig/__init__.py.in
> index 5091732..9076dd2 100644
> --- a/src/config/SSSDConfig/__init__.py.in
> +++ b/src/config/SSSDConfig/__init__.py.in
> @@ -430,12 +430,14 @@ option_strings = {
>      'default_shell' : _('Default shell, /bin/bash'),
>      'base_directory' : _('Base for home directories'),
> # [provider/proxy]
> 'proxy_max_children' : _('The number of preforked proxy children.'),
> # [provider/proxy/id]
>    'proxy_lib_name' : _('The name of the NSS library to use'),
>    'proxy_fast_alias' : _('Whether to look up canonical group name
>
> from cache if possible'),
>  # [provider/proxy/auth]
> 'proxy_max_children' : _('The number of preforked proxy children.'),
> 'proxy_pam_target' : _('PAM stack to use')
>
> }
>
> diff --git a/src/config/etc/sssd.api.d/sssd-proxy.conf
> b/src/config/etc/sssd.api.d/sssd-proxy.conf
> index 96e2d4a..09bf82a 100644
> --- a/src/config/etc/sssd.api.d/sssd-proxy.conf
> +++ b/src/config/etc/sssd.api.d/sssd-proxy.conf
> @@ -1,9 +1,12 @@
> +[provider/proxy]
> +proxy_max_children = int, None, false
>
> [provider/proxy/id]
>  proxy_lib_name = str, None, true
>  proxy_fast_alias = bool, None, true
>
> [provider/proxy/auth]
>  proxy_pam_target = str, None, true
> -proxy_max_children = int, None, false
>
> [provider/proxy/chpass]
>
> I hope it helps!
> Best Regards,
>
> Fabiano Fidêncio

Hi Fabiano,

thank you for help. You was right with section
[provider/proxy].

And I hit little issue with last white line in file.
My IDE did some automagic.

The entry in man page is really short. Please, if you have any idea, 
share it.

Regards

[PATCH] PROXY: Adding proxy_max_children option

[Pavel Březina]

On 08/25/2016 01:43 PM, Petr Cech wrote:
> /* FIXME: get max_children from configuration file */
> auth_ctx->max_children = 10;
> ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path,
>                     CONFDB_PROXY_MAX_CHILDREN, 10,
>                     &max_children);
> if (ret != EOK) {
>    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]: %s\n",
>                               ret, sss_strerror(ret));
>    goto done;
> }
> if (max_children < 1) {
>    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then 1\n",
>                               CONFDB_PROXY_MAX_CHILDREN);
>    goto done;
> }

You need to either set ret here, or set max_children to some reasonable 
value (10?).

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 08/30/2016 12:42 PM, Pavel Březina wrote:
> On 08/25/2016 01:43 PM, Petr Cech wrote:
> > /* FIXME: get max_children from configuration file */
> > auth_ctx->max_children = 10;
> > ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path,
> >                     CONFDB_PROXY_MAX_CHILDREN, 10,
> >                     &max_children);
> > if (ret != EOK) {
> >    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]: %s\n",
> >                               ret, sss_strerror(ret));
> >    goto done;
> > }
> > if (max_children < 1) {
> >    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then 1\n",
> >                               CONFDB_PROXY_MAX_CHILDREN);
> >    goto done;
> > }
>
> You need to either set ret here, or set max_children to some reasonable
> value (10?).

Hello Pavel,

max_children is set on the next line as:
auth_ctx->max_children = max_children;

I use temporary variable max_children,
because there is issue with signed/unsigned
integer value.

10 was original value. I increase it to 50.
And I use constant OPT_MAX_CHILDREN_DEFAULT now.

Fixed patch is attached.

Regards

[PATCH] PROXY: Adding proxy_max_children option

[Lukas Slebodnik]

On (30/08/16 13:03), Petr Cech wrote:
> On 08/30/2016 12:42 PM, Pavel Březina wrote:
> > On 08/25/2016 01:43 PM, Petr Cech wrote:
> > > /* FIXME: get max_children from configuration file */
> > > auth_ctx->max_children = 10;
> > > ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path,
> > >                     CONFDB_PROXY_MAX_CHILDREN, 10,
> > >                     &max_children);
> > > if (ret != EOK) {
> > >    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]: %s\n",
> > >                               ret, sss_strerror(ret));
> > >    goto done;
> > > }
> > > if (max_children < 1) {
> > >    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then 1\n",
> > >                               CONFDB_PROXY_MAX_CHILDREN);
> > >    goto done;
> > > }
> >
> > You need to either set ret here, or set max_children to some reasonable
> > value (10?).
>
> Hello Pavel,
>
> max_children is set on the next line as:
> auth_ctx->max_children = max_children;
>
> I use temporary variable max_children,
> because there is issue with signed/unsigned
> integer value.
>
> 10 was original value. I increase it to 50.
> And I use constant OPT_MAX_CHILDREN_DEFAULT now.

10 is a reasonable default and works for most of users.
I do not think we need to increase default value.
This is a purpose of the new option

LS

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 08/30/2016 01:06 PM, Lukas Slebodnik wrote:
> On (30/08/16 13:03), Petr Cech wrote:
> > On 08/30/2016 12:42 PM, Pavel Březina wrote:
> > > On 08/25/2016 01:43 PM, Petr Cech wrote:
> > > > /* FIXME: get max_children from configuration file */
> > > > auth_ctx->max_children = 10;
> > > > ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path,
> > > >                     CONFDB_PROXY_MAX_CHILDREN, 10,
> > > >                     &max_children);
> > > > if (ret != EOK) {
> > > >    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]: %s\n",
> > > >                               ret, sss_strerror(ret));
> > > >    goto done;
> > > > }
> > > > if (max_children < 1) {
> > > >    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then 1\n",
> > > >                               CONFDB_PROXY_MAX_CHILDREN);
> > > >    goto done;
> > > > }
> > >
> > > You need to either set ret here, or set max_children to some reasonable
> > > value (10?).
> > Hello Pavel,
> >
> > max_children is set on the next line as:
> > auth_ctx->max_children = max_children;
> >
> > I use temporary variable max_children,
> > because there is issue with signed/unsigned
> > integer value.
> >
> > 10 was original value. I increase it to 50.
> > And I use constant OPT_MAX_CHILDREN_DEFAULT now.
>
> 10 is a reasonable default and works for most of users.
> I do not think we need to increase default value.
> This is a purpose of the new option

I agree. I am sorry, I misunderstood to Pavel.

10 is back!

Regards

[PATCH] PROXY: Adding proxy_max_children option

[Pavel Březina]

On 08/30/2016 01:06 PM, Lukas Slebodnik wrote:
> On (30/08/16 13:03), Petr Cech wrote:
> > On 08/30/2016 12:42 PM, Pavel Březina wrote:
> > > On 08/25/2016 01:43 PM, Petr Cech wrote:
> > > > /* FIXME: get max_children from configuration file */
> > > > auth_ctx->max_children = 10;
> > > > ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path,
> > > >                     CONFDB_PROXY_MAX_CHILDREN, 10,
> > > >                     &max_children);
> > > > if (ret != EOK) {
> > > >    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]: %s\n",
> > > >                               ret, sss_strerror(ret));
> > > >    goto done;
> > > > }
> > > > if (max_children < 1) {
> > > >    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then 1\n",
> > > >                               CONFDB_PROXY_MAX_CHILDREN);
> > > >    goto done;
> > > > }
> > >
> > > You need to either set ret here, or set max_children to some reasonable
> > > value (10?).
> >
> > Hello Pavel,
> >
> > max_children is set on the next line as:
> > auth_ctx->max_children = max_children;

No it is not.
> if (ret != EOK) {
>    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]: %s\n",
>                               ret, sss_strerror(ret));
>    goto done;
> }
> if (max_children < 1) {
>    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then 1\n",
>                               CONFDB_PROXY_MAX_CHILDREN);
>    goto done;
> }
> auth_ctx->max_children = max_children;

if max_children < 1, you report an error and goto done, keeping ret = 
EOK from previous successful call. Either we consider it as an error, 
and set ret to e.g. EINVAL, or we set default value and continue.
> > I use temporary variable max_children,
> > because there is issue with signed/unsigned
> > integer value.
> >
> > 10 was original value. I increase it to 50.
> > And I use constant OPT_MAX_CHILDREN_DEFAULT now.
>
> 10 is a reasonable default and works for most of users.
> I do not think we need to increase default value.
> This is a purpose of the new option

Agree.

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 08/30/2016 01:21 PM, Pavel Březina wrote:
> On 08/30/2016 01:06 PM, Lukas Slebodnik wrote:
> > On (30/08/16 13:03), Petr Cech wrote:
> > > On 08/30/2016 12:42 PM, Pavel Březina wrote:
> > > > On 08/25/2016 01:43 PM, Petr Cech wrote:
> > > > > /* FIXME: get max_children from configuration file */
> > > > > auth_ctx->max_children = 10;
> > > > > ret = confdb_get_int(be_ctx->cdb, be_ctx->conf_path,
> > > > >                     CONFDB_PROXY_MAX_CHILDREN, 10,
> > > > >                     &max_children);
> > > > > if (ret != EOK) {
> > > > >    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]:
> > > > >
> > > > > %s\n",
> > > > >                               ret, sss_strerror(ret));
> > > > >    goto done;
> > > > > }
> > > > > if (max_children < 1) {
> > > > >    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then
> > > > >
> > > > > 1\n",
> > > > >                               CONFDB_PROXY_MAX_CHILDREN);
> > > > >    goto done;
> > > > > }
> > > >
> > > > You need to either set ret here, or set max_children to some reasonable
> > > > value (10?).
> > >
> > > Hello Pavel,
> > >
> > > max_children is set on the next line as:
> > > auth_ctx->max_children = max_children;
>
> No it is not.
> > if (ret != EOK) {
> >    DEBUG(SSSDBG_CRIT_FAILURE, "Unable to read confdb [%d]: %s\n",
> >                               ret, sss_strerror(ret));
> >    goto done;
> > }
> > if (max_children < 1) {
> >    DEBUG(SSSDBG_CRIT_FAILURE, "Option %s must be bigger then 1\n",
> >                               CONFDB_PROXY_MAX_CHILDREN);
> >    goto done;
> > }
> > auth_ctx->max_children = max_children;
>
> if max_children < 1, you report an error and goto done, keeping ret =
> EOK from previous successful call. Either we consider it as an error,
> and set ret to e.g. EINVAL, or we set default value and continue.

I see, good point. Thank you.

I chose go to done. It prevents our users to have wrong configuration.
> > > I use temporary variable max_children,
> > > because there is issue with signed/unsigned
> > > integer value.
> > >
> > > 10 was original value. I increase it to 50.
> > > And I use constant OPT_MAX_CHILDREN_DEFAULT now.
> >
> > 10 is a reasonable default and works for most of users.
> > I do not think we need to increase default value.
> > This is a purpose of the new option
>
> Agree.

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

Bump.

[PATCH] PROXY: Adding proxy_max_children option

[Fabiano Fidêncio]

Petr,

I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
50. However, you haven't update the value on sssd.conf.5.xml:

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
                     </listitem>
                 </varlistentry>

+                <varlistentry>
+                    <term>proxy_max_children (integer)</term>
+                    <listitem>
+                        <para>
+                            The number of preforked proxy children.
+                        </para>
+                        <para>
+                            Default: 50
                                   here: ^^^

+                        </para>
+                    </listitem>
+                </varlistentry>
+
             </variablelist>
         </para>

Apart from this minor the patch seems to be following everything that
was requested during the review process. However, I'm not comfortable
with the text used to describe the new option, so adding there a bit
more information would be super. Like, I don't know what's the
influence of the preforked proxy children to the rest of the code
(probably because I'm a newbie here ;-)), but would be nice to have it
clear in the documentation (for newbies like myself ;-)).

Best Regards,
--
Fabiano Fidêncio

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote:
> Petr,
>
> I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
> 50. However, you haven't update the value on sssd.conf.5.xml:
>
> diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
> index ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
> 100644
> --- a/src/man/sssd.conf.5.xml
> +++ b/src/man/sssd.conf.5.xml
> @@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
>                      </listitem>
>                  </varlistentry>
>            <varlistentry>
>                <term>proxy_max_children (integer)</term>
>                <listitem>
>                    <para>
>                        The number of preforked proxy children.
>                    </para>
>                    <para>
>                        Default: 50
>                              here: ^^^
>
>                    </para>
>                </listitem>
>            </varlistentry>
>        </variablelist>
>    </para>
>
> Apart from this minor the patch seems to be following everything that
> was requested during the review process. However, I'm not comfortable
> with the text used to describe the new option, so adding there a bit
> more information would be super. Like, I don't know what's the
> influence of the preforked proxy children to the rest of the code
> (probably because I'm a newbie here ;-)), but would be nice to have it
> clear in the documentation (for newbies like myself ;-)).
> Best Regards,
>
> Fabiano Fidêncio

Hi Fabiano,

thanks for code review. I fixed the default value in man page and I 
reformulated description. Is it better?

Regards

[PATCH] PROXY: Adding proxy_max_children option

[Fabiano Fidêncio]

Petr,

On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech  wrote:
> On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote:
> > Petr,
> >
> > I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
> > 50. However, you haven't update the value on sssd.conf.5.xml:
> >
> > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
> > index
> > ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
> > 100644
> > --- a/src/man/sssd.conf.5.xml
> > +++ b/src/man/sssd.conf.5.xml
> > @@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
> >                      </listitem>
> >                  </varlistentry>
> >            <varlistentry>
> >                <term>proxy_max_children (integer)</term>
> >                <listitem>
> >                    <para>
> >                        The number of preforked proxy children.
> >                    </para>
> >                    <para>
> >                        Default: 50
> >                              here: ^^^
> >
> >                    </para>
> >                </listitem>
> >            </varlistentry>
> >        </variablelist>
> >    </para>
> >
> > Apart from this minor the patch seems to be following everything that
> > was requested during the review process. However, I'm not comfortable
> > with the text used to describe the new option, so adding there a bit
> > more information would be super. Like, I don't know what's the
> > influence of the preforked proxy children to the rest of the code
> > (probably because I'm a newbie here ;-)), but would be nice to have it
> > clear in the documentation (for newbies like myself ;-)).
> > Best Regards,
> >
> > Fabiano Fidêncio
>
> Hi Fabiano,
>
> thanks for code review. I fixed the default value in man page and I
> reformulated description. Is it better?
>
> Regards
>
> --
> Petr^4 Čech
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/admin/lists/[e-mail]

Looking at the changes in the manual ...

+                            In busy environments it is possible sssd
runs out of
+                            available child slots and starts queuing requests
+                            in proxy mode. This option introduces the number of
+                            preforked proxy children.

I personally go for something like:

"This option introduces the number of pre-forked proxy children. It's
useful for busy environments* where sssd may run out of available
child slots, which would cause some issues due to the requests being
queued".

*: Not sure whether busy environments is something clear for everyone ...

IMO the patch is good to go as soon as we have this part done/reviewed
by a native speaker.
Maybe Justin can help us here?

Best Regards,
--
Fabiano Fidêncio

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote:
> Petr,
>
> On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech  wrote:
> > On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote:
> > > Petr,
> > >
> > > I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
> > > 50. However, you haven't update the value on sssd.conf.5.xml:
> > >
> > > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
> > > index
> > > ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
> > > 100644
> > > --- a/src/man/sssd.conf.5.xml
> > > +++ b/src/man/sssd.conf.5.xml
> > > @@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
> > >                      </listitem>
> > >                  </varlistentry>
> > >            <varlistentry>
> > >                <term>proxy_max_children (integer)</term>
> > >                <listitem>
> > >                    <para>
> > >                        The number of preforked proxy children.
> > >                    </para>
> > >                    <para>
> > >                        Default: 50
> > >                              here: ^^^
> > >
> > >                    </para>
> > >                </listitem>
> > >            </varlistentry>
> > >        </variablelist>
> > >    </para>
> > >
> > > Apart from this minor the patch seems to be following everything that
> > > was requested during the review process. However, I'm not comfortable
> > > with the text used to describe the new option, so adding there a bit
> > > more information would be super. Like, I don't know what's the
> > > influence of the preforked proxy children to the rest of the code
> > > (probably because I'm a newbie here ;-)), but would be nice to have it
> > > clear in the documentation (for newbies like myself ;-)).
> > > Best Regards,
> > >
> > > Fabiano Fidêncio
> >
> > Hi Fabiano,
> >
> > thanks for code review. I fixed the default value in man page and I
> > reformulated description. Is it better?
> >
> > Regards
> >
> > --
> > Petr^4 Čech
> >
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/admin/lists/[e-mail]
>
> Looking at the changes in the manual ...
>                        In busy environments it is possible sssd
>
> runs out of
>                        available child slots and starts queuing requests
>                        in proxy mode. This option introduces the number of
>                        preforked proxy children.
>
> I personally go for something like:
>
> "This option introduces the number of pre-forked proxy children. It's
> useful for busy environments* where sssd may run out of available
> child slots, which would cause some issues due to the requests being
> queued".
>
> *: Not sure whether busy environments is something clear for everyone ...
>
> IMO the patch is good to go as soon as we have this part done/reviewed
> by a native speaker.
> Maybe Justin can help us here?
> Best Regards,
>
> Fabiano Fidêncio

Fabiano,

I took your suggestion, thanks. I don't know right term for 'busy 
environments'. I will be glad if native speaker help me with the right 
formulation of description.

Regards

[PATCH] PROXY: Adding proxy_max_children option

[Justin Stephenson]

On 09/05/2016 10:20 AM, Petr Cech wrote:
> On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote:
> > Petr,
> >
> > On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech  wrote:
> > > On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote:
> > > > Petr,
> > > >
> > > > I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
> > > > 50. However, you haven't update the value on sssd.conf.5.xml:
> > > >
> > > > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
> > > > index
> > > > ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
> > > >
> > > > 100644
> > > > --- a/src/man/sssd.conf.5.xml
> > > > +++ b/src/man/sssd.conf.5.xml
> > > > @@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
> > > >                      </listitem>
> > > >                  </varlistentry>
> > > >            <varlistentry>
> > > >                <term>proxy_max_children (integer)</term>
> > > >                <listitem>
> > > >                    <para>
> > > >                        The number of preforked proxy children.
> > > >                    </para>
> > > >                    <para>
> > > >                        Default: 50
> > > >                              here: ^^^
> > > >
> > > >                    </para>
> > > >                </listitem>
> > > >            </varlistentry>
> > > >        </variablelist>
> > > >    </para>
> > > >
> > > > Apart from this minor the patch seems to be following everything that
> > > > was requested during the review process. However, I'm not comfortable
> > > > with the text used to describe the new option, so adding there a bit
> > > > more information would be super. Like, I don't know what's the
> > > > influence of the preforked proxy children to the rest of the code
> > > > (probably because I'm a newbie here ;-)), but would be nice to have it
> > > > clear in the documentation (for newbies like myself ;-)).
> > > > Best Regards,
> > > >
> > > > Fabiano Fidêncio
> > >
> > > Hi Fabiano,
> > >
> > > thanks for code review. I fixed the default value in man page and I
> > > reformulated description. Is it better?
> > >
> > > Regards
> > >
> > > --
> > > Petr^4 Čech
> > >
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://lists.fedorahosted.org/admin/lists/[e-mail]
> >
> > Looking at the changes in the manual ...
> >                        In busy environments it is possible sssd
> >
> > runs out of
> >                        available child slots and starts queuing
> >
> > requests
> >                        in proxy mode. This option introduces the
> >
> > number of
> >                        preforked proxy children.
> >
> > I personally go for something like:
> >
> > "This option introduces the number of pre-forked proxy children. It's
> > useful for busy environments* where sssd may run out of available
> > child slots, which would cause some issues due to the requests being
> > queued".
> >
> > *: Not sure whether busy environments is something clear for everyone ...
> >
> > IMO the patch is good to go as soon as we have this part done/reviewed
> > by a native speaker.
> > Maybe Justin can help us here?
> > Best Regards,
> >
> > Fabiano Fidêncio
>
> Fabiano,
>
> I took your suggestion, thanks. I don't know right term for 'busy
> environments'. I will be glad if native speaker help me with the right
> formulation of description.

Something like "it is useful for high-load SSSD environments" or "it is 
useful for larger environments" may work - whichever you prefer.

Kind regards,
Justin Stephenson
> Regards
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/admin/lists/[e-mail]

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 09/06/2016 04:17 PM, Justin Stephenson wrote:
> On 09/05/2016 10:20 AM, Petr Cech wrote:
> > On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote:
> > > Petr,
> > >
> > > On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech  wrote:
> > > > On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote:
> > > > > Petr,
> > > > >
> > > > > I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
> > > > > 50. However, you haven't update the value on sssd.conf.5.xml:
> > > > >
> > > > > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
> > > > > index
> > > > > ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
> > > > >
> > > > > 100644
> > > > > --- a/src/man/sssd.conf.5.xml
> > > > > +++ b/src/man/sssd.conf.5.xml
> > > > > @@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
> > > > >                      </listitem>
> > > > >                  </varlistentry>
> > > > >            <varlistentry>
> > > > >                <term>proxy_max_children (integer)</term>
> > > > >                <listitem>
> > > > >                    <para>
> > > > >                        The number of preforked proxy children.
> > > > >                    </para>
> > > > >                    <para>
> > > > >                        Default: 50
> > > > >                              here: ^^^
> > > > >
> > > > >                    </para>
> > > > >                </listitem>
> > > > >            </varlistentry>
> > > > >        </variablelist>
> > > > >    </para>
> > > > >
> > > > > Apart from this minor the patch seems to be following everything that
> > > > > was requested during the review process. However, I'm not comfortable
> > > > > with the text used to describe the new option, so adding there a bit
> > > > > more information would be super. Like, I don't know what's the
> > > > > influence of the preforked proxy children to the rest of the code
> > > > > (probably because I'm a newbie here ;-)), but would be nice to have it
> > > > > clear in the documentation (for newbies like myself ;-)).
> > > > > Best Regards,
> > > > >
> > > > > Fabiano Fidêncio
> > > >
> > > > Hi Fabiano,
> > > >
> > > > thanks for code review. I fixed the default value in man page and I
> > > > reformulated description. Is it better?
> > > >
> > > > Regards
> > > >
> > > > --
> > > > Petr^4 Čech
> > > >
> > > > sssd-devel mailing list
> > > > [e-mail]
> > > > https://lists.fedorahosted.org/admin/lists/[e-mail]
> > >
> > > Looking at the changes in the manual ...
> > >                        In busy environments it is possible sssd
> > >
> > > runs out of
> > >                        available child slots and starts queuing
> > >
> > > requests
> > >                        in proxy mode. This option introduces the
> > >
> > > number of
> > >                        preforked proxy children.
> > >
> > > I personally go for something like:
> > >
> > > "This option introduces the number of pre-forked proxy children. It's
> > > useful for busy environments* where sssd may run out of available
> > > child slots, which would cause some issues due to the requests being
> > > queued".
> > >
> > > *: Not sure whether busy environments is something clear for everyone
> > > ...
> > >
> > > IMO the patch is good to go as soon as we have this part done/reviewed
> > > by a native speaker.
> > > Maybe Justin can help us here?
> > > Best Regards,
> > >
> > > Fabiano Fidêncio
> >
> > Fabiano,
> >
> > I took your suggestion, thanks. I don't know right term for 'busy
> > environments'. I will be glad if native speaker help me with the right
> > formulation of description.
>
> Something like "it is useful for high-load SSSD environments" or "it is
> useful for larger environments" may work - whichever you prefer.
>
> Kind regards,
> Justin Stephenson

Hello,

new version attached. Description is:

This option specifies the number of pre-forked
proxy children. It is useful for high-load SSSD
environments where sssd may run out of available
child slots, which would cause some issues due to
the requests being queued.

After hint from Michal I replaced introduces by specifies.

Is this version linguistic right?

Regards

[PATCH] PROXY: Adding proxy_max_children option

[Justin Stephenson]

On 09/06/2016 10:57 AM, Petr Cech wrote:
> On 09/06/2016 04:17 PM, Justin Stephenson wrote:
> > On 09/05/2016 10:20 AM, Petr Cech wrote:
> > > On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote:
> > > > Petr,
> > > >
> > > > On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech  wrote:
> > > > > On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote:
> > > > > > Petr,
> > > > > >
> > > > > > I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
> > > > > > 50. However, you haven't update the value on sssd.conf.5.xml:
> > > > > >
> > > > > > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
> > > > > > index
> > > > > > ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
> > > > > >
> > > > > > 100644
> > > > > > --- a/src/man/sssd.conf.5.xml
> > > > > > +++ b/src/man/sssd.conf.5.xml
> > > > > > @@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
> > > > > >                      </listitem>
> > > > > >                  </varlistentry>
> > > > > >            <varlistentry>
> > > > > >                <term>proxy_max_children (integer)</term>
> > > > > >                <listitem>
> > > > > >                    <para>
> > > > > >                        The number of preforked proxy children.
> > > > > >                    </para>
> > > > > >                    <para>
> > > > > >                        Default: 50
> > > > > >                              here: ^^^
> > > > > >
> > > > > >                    </para>
> > > > > >                </listitem>
> > > > > >            </varlistentry>
> > > > > >        </variablelist>
> > > > > >    </para>
> > > > > >
> > > > > > Apart from this minor the patch seems to be following everything that
> > > > > > was requested during the review process. However, I'm not comfortable
> > > > > > with the text used to describe the new option, so adding there a bit
> > > > > > more information would be super. Like, I don't know what's the
> > > > > > influence of the preforked proxy children to the rest of the code
> > > > > > (probably because I'm a newbie here ;-)), but would be nice to
> > > > > > have it
> > > > > > clear in the documentation (for newbies like myself ;-)).
> > > > > > Best Regards,
> > > > > >
> > > > > > Fabiano Fidêncio
> > > > >
> > > > > Hi Fabiano,
> > > > >
> > > > > thanks for code review. I fixed the default value in man page and I
> > > > > reformulated description. Is it better?
> > > > >
> > > > > Regards
> > > > >
> > > > > --
> > > > > Petr^4 Čech
> > > > >
> > > > > sssd-devel mailing list
> > > > > [e-mail]
> > > > > https://lists.fedorahosted.org/admin/lists/[e-mail]
> > > >
> > > > Looking at the changes in the manual ...
> > > >                        In busy environments it is possible sssd
> > > >
> > > > runs out of
> > > >                        available child slots and starts queuing
> > > >
> > > > requests
> > > >                        in proxy mode. This option introduces the
> > > >
> > > > number of
> > > >                        preforked proxy children.
> > > >
> > > > I personally go for something like:
> > > >
> > > > "This option introduces the number of pre-forked proxy children. It's
> > > > useful for busy environments* where sssd may run out of available
> > > > child slots, which would cause some issues due to the requests being
> > > > queued".
> > > >
> > > > *: Not sure whether busy environments is something clear for everyone
> > > > ...
> > > >
> > > > IMO the patch is good to go as soon as we have this part done/reviewed
> > > > by a native speaker.
> > > > Maybe Justin can help us here?
> > > > Best Regards,
> > > >
> > > > Fabiano Fidêncio
> > >
> > > Fabiano,
> > >
> > > I took your suggestion, thanks. I don't know right term for 'busy
> > > environments'. I will be glad if native speaker help me with the right
> > > formulation of description.
> >
> > Something like "it is useful for high-load SSSD environments" or "it is
> > useful for larger environments" may work - whichever you prefer.
> >
> > Kind regards,
> > Justin Stephenson
>
> Hello,
>
> new version attached. Description is:
>
> This option specifies the number of pre-forked
> proxy children. It is useful for high-load SSSD
> environments where sssd may run out of available
> child slots, which would cause some issues due to
> the requests being queued.
>
> After hint from Michal I replaced introduces by specifies.
>
> Is this version linguistic right?

This description looks good to me.

-Justin
> Regards
>
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/admin/lists/[e-mail]

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 09/06/2016 05:11 PM, Justin Stephenson wrote:
> On 09/06/2016 10:57 AM, Petr Cech wrote:
> > On 09/06/2016 04:17 PM, Justin Stephenson wrote:
> > > On 09/05/2016 10:20 AM, Petr Cech wrote:
> > > > On 09/05/2016 04:05 PM, Fabiano Fidêncio wrote:
> > > > > Petr,
> > > > >
> > > > > On Mon, Sep 5, 2016 at 3:43 PM, Petr Cech  wrote:
> > > > > > On 09/05/2016 09:57 AM, Fabiano Fidêncio wrote:
> > > > > > >
> > > > > > > Petr,
> > > > > > >
> > > > > > > I see you have updated the OPT_MAX_CHILDREN_DEFAULT to 10 instead of
> > > > > > > 50. However, you haven't update the value on sssd.conf.5.xml:
> > > > > > >
> > > > > > > diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
> > > > > > > index
> > > > > > > ae291e0fc8f2f9afabcdf32f18a5ec12252bbbbf..1bf3e799047d9c722487be8657bbee5cfd479cdd
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > 100644
> > > > > > > --- a/src/man/sssd.conf.5.xml
> > > > > > > +++ b/src/man/sssd.conf.5.xml
> > > > > > > @@ -2464,6 +2464,18 @@ subdomain_inherit = ldap_purge_cache_timeout
> > > > > > >                      </listitem>
> > > > > > >                  </varlistentry>
> > > > > > >
> > > > > > > +                <varlistentry>
> > > > > > > +                    <term>proxy_max_children (integer)</term>
> > > > > > > +                    <listitem>
> > > > > > > +                        <para>
> > > > > > > +                            The number of preforked proxy children.
> > > > > > > +                        </para>
> > > > > > > +                        <para>
> > > > > > > +                            Default: 50
> > > > > > >                                    here: ^^^
> > > > > > >
> > > > > > > +                        </para>
> > > > > > > +                    </listitem>
> > > > > > > +                </varlistentry>
> > > > > > > +
> > > > > > >              </variablelist>
> > > > > > >          </para>
> > > > > > >
> > > > > > > Apart from this minor the patch seems to be following everything
> > > > > > > that
> > > > > > > was requested during the review process. However, I'm not
> > > > > > > comfortable
> > > > > > > with the text used to describe the new option, so adding there a bit
> > > > > > > more information would be super. Like, I don't know what's the
> > > > > > > influence of the preforked proxy children to the rest of the code
> > > > > > > (probably because I'm a newbie here ;-)), but would be nice to
> > > > > > > have it
> > > > > > > clear in the documentation (for newbies like myself ;-)).
> > > > > > >
> > > > > > > Best Regards,
> > > > > > > --
> > > > > > > Fabiano Fidêncio
> > > > > >
> > > > > > Hi Fabiano,
> > > > > >
> > > > > > thanks for code review. I fixed the default value in man page and I
> > > > > > reformulated description. Is it better?
> > > > > >
> > > > > > Regards
> > > > > >
> > > > > > --
> > > > > > Petr^4 Čech
> > > > > >
> > > > > > sssd-devel mailing list
> > > > > > [e-mail]
> > > > > > https://lists.fedorahosted.org/admin/lists/[e-mail]
> > > > >
> > > > > Looking at the changes in the manual ...
> > > > >                        In busy environments it is possible sssd
> > > > >
> > > > > runs out of
> > > > >                        available child slots and starts queuing
> > > > >
> > > > > requests
> > > > >                        in proxy mode. This option introduces the
> > > > >
> > > > > number of
> > > > >                        preforked proxy children.
> > > > >
> > > > > I personally go for something like:
> > > > >
> > > > > "This option introduces the number of pre-forked proxy children. It's
> > > > > useful for busy environments* where sssd may run out of available
> > > > > child slots, which would cause some issues due to the requests being
> > > > > queued".
> > > > >
> > > > > *: Not sure whether busy environments is something clear for everyone
> > > > > ...
> > > > >
> > > > > IMO the patch is good to go as soon as we have this part done/reviewed
> > > > > by a native speaker.
> > > > > Maybe Justin can help us here?
> > > > > Best Regards,
> > > > >
> > > > > Fabiano Fidêncio
> > > >
> > > > Fabiano,
> > > >
> > > > I took your suggestion, thanks. I don't know right term for 'busy
> > > > environments'. I will be glad if native speaker help me with the right
> > > > formulation of description.
> > >
> > > Something like "it is useful for high-load SSSD environments" or "it is
> > > useful for larger environments" may work - whichever you prefer.
> > >
> > > Kind regards,
> > > Justin Stephenson
> >
> > Hello,
> >
> > new version attached. Description is:
> >
> > This option specifies the number of pre-forked
> > proxy children. It is useful for high-load SSSD
> > environments where sssd may run out of available
> > child slots, which would cause some issues due to
> > the requests being queued.
> >
> > After hint from Michal I replaced introduces by specifies.
> >
> > Is this version linguistic right?
>
> This description looks good to me.
>
> -Justin

Thanks, Justin.

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

Bump.

[PATCH] PROXY: Adding proxy_max_children option

[Fabiano Fidêncio]

On Mon, Sep 12, 2016 at 9:40 AM, Petr Cech  wrote:
> Bump.
>
> --
> Petr^4 Čech
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/admin/lists/[e-mail]

Patch looks good and all the requested changed were done.
I haven't done any tests with the patch, but the changes themselves
look good to me.

Best Regards,
--
Fabiano Fidêncio

[PATCH] PROXY: Adding proxy_max_children option

[Lukas Slebodnik]

On (13/09/16 14:11), Fabiano Fidêncio wrote:
> On Mon, Sep 12, 2016 at 9:40 AM, Petr Cech  wrote:
> > Bump.
> >
> > --
> > Petr^4 Čech
> > _______________________________________________
> > sssd-devel mailing list
> > [e-mail]
> > https://lists.fedorahosted.org/admin/lists/[e-mail]
>
> Patch looks good and all the requested changed were done.
> I haven't done any tests with the patch, but the changes themselves
> look good to me.

master:
* aef0171e0bdc9a683958d69c7ee984fb10cd5de7

http://sssd-ci.duckdns.org/logs/job/53/30/summary.html

LS

[PATCH] PROXY: Adding proxy_max_children option

[Lukas Slebodnik]

On (13/09/16 16:24), Lukas Slebodnik wrote:
> On (13/09/16 14:11), Fabiano Fidêncio wrote:
> > On Mon, Sep 12, 2016 at 9:40 AM, Petr Cech  wrote:
> > > Bump.
> > >
> > > --
> > > Petr^4 Čech
> > > _______________________________________________
> > > sssd-devel mailing list
> > > [e-mail]
> > > https://lists.fedorahosted.org/admin/lists/[e-mail]
> >
> > Patch looks good and all the requested changed were done.
> > I haven't done any tests with the patch, but the changes themselves
> > look good to me.
>
> master:
> aef0171e0bdc9a683958d69c7ee984fb10cd5de7
>
> http://sssd-ci.duckdns.org/logs/job/53/30/summary.html

Could you also prepare patch for 1.13 branch?

LS

[PATCH] PROXY: Adding proxy_max_children option

[Petr Cech]

On 09/13/2016 04:27 PM, Lukas Slebodnik wrote:
> On (13/09/16 16:24), Lukas Slebodnik wrote:
> > On (13/09/16 14:11), Fabiano Fidêncio wrote:
> > > On Mon, Sep 12, 2016 at 9:40 AM, Petr Cech  wrote:
> > > > Bump.
> > > >
> > > > --
> > > > Petr^4 Čech
> > > > _______________________________________________
> > > > sssd-devel mailing list
> > > > [e-mail]
> > > > https://lists.fedorahosted.org/admin/lists/[e-mail]
> > >
> > > Patch looks good and all the requested changed were done.
> > > I haven't done any tests with the patch, but the changes themselves
> > > look good to me.
> >
> > master:
> > aef0171e0bdc9a683958d69c7ee984fb10cd5de7
> >
> > http://sssd-ci.duckdns.org/logs/job/53/30/summary.html
>
> Could you also prepare patch for 1.13 branch?

Yes, see attachment, please.

Regards

[PATCH] PROXY: Adding proxy_max_children option

[Lukas Slebodnik]

On (13/09/16 17:57), Petr Cech wrote:
> On 09/13/2016 04:27 PM, Lukas Slebodnik wrote:
> > On (13/09/16 16:24), Lukas Slebodnik wrote:
> > > On (13/09/16 14:11), Fabiano Fidêncio wrote:
> > > > On Mon, Sep 12, 2016 at 9:40 AM, Petr Cech  wrote:
> > > > > Bump.
> > > > >
> > > > > --
> > > > > Petr^4 Čech
> > > > > _______________________________________________
> > > > > sssd-devel mailing list
> > > > > [e-mail]
> > > > > https://lists.fedorahosted.org/admin/lists/[e-mail]
> > > >
> > > > Patch looks good and all the requested changed were done.
> > > > I haven't done any tests with the patch, but the changes themselves
> > > > look good to me.
> > >
> > > master:
> > > aef0171e0bdc9a683958d69c7ee984fb10cd5de7
> > >
> > > http://sssd-ci.duckdns.org/logs/job/53/30/summary.html
> >
> > Could you also prepare patch for 1.13 branch?
>
> Yes, see attachment, please.

sssd-1-13:
* 90c62a1b4bac450712bc5a194b793761329a1d3a

LS