[PATCH] netlink integration: ensure that interface name is NULL-terminated

[Jakub Hrozek]

Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107

In the unlikely case that the interface name was IFNAMSIZ bytes long or
longer, strncpy wouldn't NULL-terminate the buffer. Copy one byte less
to ensure the buffer is NULL-terminated.

[Marco Pizzoli]

Hi Jakub,

On Thu, Apr 5, 2012 at 8:07 PM, Jakub Hrozek <jhrozek(a)redhat.com&gt; wrote:

>  Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107

Is it normal that I cannot access that ticket?

You are not authorized to access bug #808107

I know I'm not a redhat guy, but I thought I was allowed to access RH
tickets. Just as a curiosity...

Thanks in advance
Marco

[Stephen Gallagher]

On Thu, 2012-04-05 at 20:14 +0200, Marco Pizzoli wrote:
>  Hi Jakub,
>  
>  On Thu, Apr 5, 2012 at 8:07 PM, Jakub Hrozek <jhrozek(a)redhat.com&gt;
>  wrote:
>          Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107
>  
>  
>  Is it normal that I cannot access that ticket?
>  
>  
>  You are not authorized to access bug #808107
>  
>  
>  I know I'm not a redhat guy, but I thought I was allowed to access RH
>  tickets. Just as a curiosity... 

Certain tickets are made non-public for some reasons.

Some examples (non-exhaustive):
 * There is a real or possible security vulnerability being discussed.
 * They contain private customer data that should not be shared.

[Marco Pizzoli]

Hi Stephen,

On Thu, Apr 5, 2012 at 8:17 PM, Stephen Gallagher <sgallagh(a)redhat.com&gt;wrote:

>  On Thu, 2012-04-05 at 20:14 +0200, Marco Pizzoli wrote:
>  > Hi Jakub,
>  >
>  > On Thu, Apr 5, 2012 at 8:07 PM, Jakub Hrozek <jhrozek(a)redhat.com&gt;
>  > wrote:
>  >         Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107
>  >
>  >
>  > Is it normal that I cannot access that ticket?
>  >
>  >
>  > You are not authorized to access bug #808107
>  >
>  >
>  > I know I'm not a redhat guy, but I thought I was allowed to access RH
>  > tickets. Just as a curiosity...
>
>
>  Certain tickets are made non-public for some reasons.
>
>  Some examples (non-exhaustive):
>   * There is a real or possible security vulnerability being discussed.
>   * They contain private customer data that should not be shared.
>  
I agree. Thanks for clarifing.

M.


>  _______________________________________________
>  sssd-devel mailing list
>  sssd-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/sssd-devel
>
>

[Stephen Gallagher]

On Thu, 2012-04-05 at 14:07 -0400, Jakub Hrozek wrote:
>  Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107
>  
>  In the unlikely case that the interface name was IFNAMSIZ bytes long or
>  longer, strncpy wouldn't NULL-terminate the buffer. Copy one byte less
>  to ensure the buffer is NULL-terminated. 
Nack, this is incomplete. You need to do:

strncpy(iwr.ifr_ifrn.ifrn_name, ifname, IFNAMSIZ-1);
iwr.ifr_ifrn.ifrn_name[IFNAMSIZ-1] = '\0';

[Jakub Hrozek]

On Thu, Apr 05, 2012 at 11:15:18AM -0700, Stephen Gallagher wrote:
>  On Thu, 2012-04-05 at 14:07 -0400, Jakub Hrozek wrote:
>  > Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107
>  > 
>  > In the unlikely case that the interface name was IFNAMSIZ bytes long or
>  > longer, strncpy wouldn't NULL-terminate the buffer. Copy one byte less
>  > to ensure the buffer is NULL-terminated.
>  
>  Nack, this is incomplete. You need to do:
>  
>  strncpy(iwr.ifr_ifrn.ifrn_name, ifname, IFNAMSIZ-1);
>  iwr.ifr_ifrn.ifrn_name[IFNAMSIZ-1] = '\0'; 
Thank you, a new patch is attached.

[Stephen Gallagher]

On Thu, 2012-04-05 at 14:23 -0400, Jakub Hrozek wrote:
>  On Thu, Apr 05, 2012 at 11:15:18AM -0700, Stephen Gallagher wrote:
>  > On Thu, 2012-04-05 at 14:07 -0400, Jakub Hrozek wrote:
>  > > Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107
>  > > 
>  > > In the unlikely case that the interface name was IFNAMSIZ bytes long or
>  > > longer, strncpy wouldn't NULL-terminate the buffer. Copy one byte less
>  > > to ensure the buffer is NULL-terminated.
>  > 
>  > Nack, this is incomplete. You need to do:
>  > 
>  > strncpy(iwr.ifr_ifrn.ifrn_name, ifname, IFNAMSIZ-1);
>  > iwr.ifr_ifrn.ifrn_name[IFNAMSIZ-1] = '\0';
>  
>  Thank you, a new patch is attached. 
Ack

[Stephen Gallagher]

On Thu, 2012-04-05 at 16:03 -0700, Stephen Gallagher wrote:
>  On Thu, 2012-04-05 at 14:23 -0400, Jakub Hrozek wrote:
>  > On Thu, Apr 05, 2012 at 11:15:18AM -0700, Stephen Gallagher wrote:
>  > > On Thu, 2012-04-05 at 14:07 -0400, Jakub Hrozek wrote:
>  > > > Reported in https://bugzilla.redhat.com/show_bug.cgi?id=808107
>  > > > 
>  > > > In the unlikely case that the interface name was IFNAMSIZ bytes long or
>  > > > longer, strncpy wouldn't NULL-terminate the buffer. Copy one byte
> less
>  > > > to ensure the buffer is NULL-terminated.
>  > > 
>  > > Nack, this is incomplete. You need to do:
>  > > 
>  > > strncpy(iwr.ifr_ifrn.ifrn_name, ifname, IFNAMSIZ-1);
>  > > iwr.ifr_ifrn.ifrn_name[IFNAMSIZ-1] = '\0';
>  > 
>  > Thank you, a new patch is attached.
>  
>  Ack 
Pushed to master and sssd-1-8.