On Tue, Apr 09, 2013 at 11:15:49AM -0500, Ariel Barria wrote:
Patch for remove BUILD.txt content.
Thank you, but I think the sentence should be reworded slightly. Instead of "In the following link" I think "On the following page" sounds better.
Also we no longer tell people how to build the libraries, maybe just say "build the SSSD and contribute to the project".
Thanks for the patch!
done. Thank you for comments.
Date: Fri, 12 Apr 2013 16:53:02 +0200 From: jhrozek@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATCH] Removing BUILD.txt content
On Tue, Apr 09, 2013 at 11:15:49AM -0500, Ariel Barria wrote:
Patch for remove BUILD.txt content.
Thank you, but I think the sentence should be reworded slightly. Instead of "In the following link" I think "On the following page" sounds better.
Also we no longer tell people how to build the libraries, maybe just say "build the SSSD and contribute to the project".
Thanks for the patch! _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course.
On 06/18/2013 09:02 AM, Jakub Hrozek wrote:
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Why would it be found by Coverity?
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course.
Ack.
On Tue, Jun 18, 2013 at 09:39:20AM +0200, Pavel Březina wrote:
On 06/18/2013 09:02 AM, Jakub Hrozek wrote:
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Why would it be found by Coverity?
s/Coverity/Patchwork/ :-)
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course.
Ack.
sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On Tue, Jun 18, 2013 at 09:39:20AM +0200, Pavel Březina wrote:
On 06/18/2013 09:02 AM, Jakub Hrozek wrote:
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Why would it be found by Coverity?
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course.
Ack.
Pushed to master.
On Tue, 2013-06-18 at 09:02 +0200, Jakub Hrozek wrote:
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course. _
Hi This assumes that we're using git. What about building from the tarball? Steve.
On Tue, Jun 18, 2013 at 09:43:04AM +0200, steve wrote:
On Tue, 2013-06-18 at 09:02 +0200, Jakub Hrozek wrote:
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course. _
Hi This assumes that we're using git. What about building from the tarball? Steve.
The process would be the same, the tarball is just a different way of acquiring the sources, no?
On 18/06/13 11:54, Jakub Hrozek wrote:
On Tue, Jun 18, 2013 at 09:43:04AM +0200, steve wrote:
On Tue, 2013-06-18 at 09:02 +0200, Jakub Hrozek wrote:
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course. _
Hi This assumes that we're using git. What about building from the tarball? Steve.
The process would be the same, the tarball is just a different way of acquiring the sources, no?
Hi No. The tarball comes with a .configure file. You should not run autoreconf on the tarball. If you do, it will not build.
On Tue, Jun 18, 2013 at 12:05:44PM +0200, steve wrote:
On 18/06/13 11:54, Jakub Hrozek wrote:
On Tue, Jun 18, 2013 at 09:43:04AM +0200, steve wrote:
On Tue, 2013-06-18 at 09:02 +0200, Jakub Hrozek wrote:
On Fri, Apr 12, 2013 at 10:58:54AM -0500, Ariel Barria wrote:
done. Thank you for comments.
I must admit I forgot about this patch (it wasn't even found by Coverity), I'm sorry.
Attached is a version with slightly reworded BUILD.txt contents. The attribution still belongs to Ariel, of course. _
Hi This assumes that we're using git. What about building from the tarball? Steve.
The process would be the same, the tarball is just a different way of acquiring the sources, no?
Hi No. The tarball comes with a .configure file.
True, it also comes with translated man pages.
You should not run autoreconf on the tarball. If you do, it will not build.
That was a bug that should be fixed now. As a matter of fact, we do run autoreconf even in the Fedora specfiles which do build from tarball.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 06/18/2013 06:12 AM, Jakub Hrozek wrote:
On Tue, Jun 18, 2013 at 12:05:44PM +0200, steve wrote:
You should not run autoreconf on the tarball. If you do, it will not build.
That was a bug that should be fixed now. As a matter of fact, we do run autoreconf even in the Fedora specfiles which do build from tarball.
Yes, if it's ever not safe to run autoreconf on the tarball, that's a critical release bug in my opinion. Anyone who wants to package SSSD for their distribution should *always* be running autoreconf, since it will ensure that SSSD is built according to that distribution's requirements and build system.
sssd-devel@lists.fedorahosted.org
-
Ariel Barria -
Jakub Hrozek -
Pavel Březina -
Stephen Gallagher -
steve