[PATCH] Fix incorrect type comparison

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Fixes https://fedorahosted.org/sssd/ticket/657

sss_cli_check_socket returns an enum sss_status result code, but we were
assigning it to an enum nss_status variable before checking it.

Coincidentally, the success codes were the same, so we weren't seeing a
bug here, but it throws a warning on newer gcc and is just generally
wrong, so we'll fix it.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEUEARECAAYFAkzhlv4ACgkQeiVVYja6o6NedACYgEDBnCS9K3J9qIpoXaWtr2AF
> cACeKpSiePGfbeN6YzX/PJpI/pb+G2Y=
> =ymxA
> -----END PGP SIGNATURE-----

[Sumit Bose]

On Mon, Nov 15, 2010 at 03:24:30PM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Fixes https://fedorahosted.org/sssd/ticket/657
>
> sss_cli_check_socket returns an enum sss_status result code, but we were
> assigning it to an enum nss_status variable before checking it.
>
> Coincidentally, the success codes were the same, so we weren't seeing a
> bug here, but it throws a warning on newer gcc and is just generally
> wrong, so we'll fix it.

ACK

bye,
Sumit
> Stephen Gallagher
> RHCE 804006346421761
>
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEUEARECAAYFAkzhlv4ACgkQeiVVYja6o6NedACYgEDBnCS9K3J9qIpoXaWtr2AF
> cACeKpSiePGfbeN6YzX/PJpI/pb+G2Y=
> =ymxA
> -----END PGP SIGNATURE-----

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/15/2010 03:48 PM, Sumit Bose wrote:
> On Mon, Nov 15, 2010 at 03:24:30PM -0500, Stephen Gallagher wrote:
> Fixes https://fedorahosted.org/sssd/ticket/657
>
> sss_cli_check_socket returns an enum sss_status result code, but we were
> assigning it to an enum nss_status variable before checking it.
>
> Coincidentally, the success codes were the same, so we weren't seeing a
> bug here, but it throws a warning on newer gcc and is just generally
> wrong, so we'll fix it.
> > ACK

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkzhnZwACgkQeiVVYja6o6MBnQCcDSDJswkt5zCtFnnmVtp2Tjdo
> cPIAmQHJ4QS/bLKZPsPNFsY1Y8x0Bypk
> =Z49B
> -----END PGP SIGNATURE-----