URL: https://github.com/SSSD/sssd/pull/5735 Author: cryptomilk Title: #5735: util: Avoid an extern variable by using sss_chain_id_get() Action: opened
PR body: """ None """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5735/head:pr5735 git checkout pr5735
URL: https://github.com/SSSD/sssd/pull/5735 Author: cryptomilk Title: #5735: util: Avoid an extern variable by using sss_chain_id_get() Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5735/head:pr5735 git checkout pr5735
URL: https://github.com/SSSD/sssd/pull/5735 Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented: """ In general this feels cleaner but this would require inclusion of `sss_chain_id.c` to `libsss_debug`: ``` libsss_debug.so: undefined reference to `sss_chain_id_get' ``` and this, in turn, would require linking against `libtevent`. """
See the full comment at https://github.com/SSSD/sssd/pull/5735#issuecomment-892485276
URL: https://github.com/SSSD/sssd/pull/5735 Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented: """ In general this feels cleaner but this would require inclusion of `sss_chain_id.c` to `libsss_debug`: ``` libsss_debug.so: undefined reference to `sss_chain_id_get' ``` and this, in turn, would require linking against `libtevent` (not the case currently and probably better to be avoided as `libsss_debug` is used in different helpers that doesn't link against libtevent) """
See the full comment at https://github.com/SSSD/sssd/pull/5735#issuecomment-892485276
URL: https://github.com/SSSD/sssd/pull/5735 Author: cryptomilk Title: #5735: util: Avoid an extern variable by using sss_chain_id_get() Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5735/head:pr5735 git checkout pr5735
URL: https://github.com/SSSD/sssd/pull/5735 Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented: """ Other functions in `sss_chain_id.c ` still need to access `debug_chain_id` """
See the full comment at https://github.com/SSSD/sssd/pull/5735#issuecomment-892657039
URL: https://github.com/SSSD/sssd/pull/5735 Author: cryptomilk Title: #5735: util: Avoid an extern variable by using sss_chain_id_get() Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5735/head:pr5735 git checkout pr5735
URL: https://github.com/SSSD/sssd/pull/5735 Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented: """ I guess include of `stdint.h` is missing in `debug.h`
But, in general, I'm not sure the split of ` sss_chain_id_*` function to different files is much better then single extern var... """
See the full comment at https://github.com/SSSD/sssd/pull/5735#issuecomment-892703698
URL: https://github.com/SSSD/sssd/pull/5735 Author: cryptomilk Title: #5735: util: Avoid an extern variable by using sss_chain_id_get() Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5735/head:pr5735 git checkout pr5735
URL: https://github.com/SSSD/sssd/pull/5735 Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
alexey-tikhonov commented: """ I guess include of `stdint.h` is missing in `debug.h`
But, in general, I'm not sure the split of ` sss_chain_id_*` functions to different files is much better then single extern var... """
See the full comment at https://github.com/SSSD/sssd/pull/5735#issuecomment-892703698
URL: https://github.com/SSSD/sssd/pull/5735 Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
pbrezina commented: """ We already have multiple extern debug variables. Removing this one with the cost of splitting the implementation seems as unnecessary paranoia. Additionally, the main reason that I access the variable directly inside sss_chain_id.c is to avoid unnecessary functions calls since it has little impact in performance (negligible that's true, but easily avoided) .
I'll leave it to others to decide. Also _get should be inlined. """
See the full comment at https://github.com/SSSD/sssd/pull/5735#issuecomment-896682104
URL: https://github.com/SSSD/sssd/pull/5735 Title: #5735: util: Avoid an extern variable by using sss_chain_id_get()
cryptomilk commented: """ Then lets just close it ... :-) """
See the full comment at https://github.com/SSSD/sssd/pull/5735#issuecomment-896942640
URL: https://github.com/SSSD/sssd/pull/5735 Author: cryptomilk Title: #5735: util: Avoid an extern variable by using sss_chain_id_get() Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5735/head:pr5735 git checkout pr5735
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
cryptomilk
-
pbrezina