URL: https://github.com/SSSD/sssd/pull/5747 Author: elkoniu Title: #5747: general: Fix compilation warnings Action: opened
PR body: """ Commit 44525a9995c775ac284a6203d0e505dc4bf0d459 introduced compilation warnings related to type casting. This commit fixes this by align types of pointer used in code. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5747/head:pr5747 git checkout pr5747
URL: https://github.com/SSSD/sssd/pull/5747 Author: elkoniu Title: #5747: general: Fix compilation warnings Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5747/head:pr5747 git checkout pr5747
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
ikerexxe commented: """ The code changes LGTM but the commit message doesn't. The `align` word is what confounds. Can you try to find a better word for it? """
See the full comment at https://github.com/SSSD/sssd/pull/5747#issuecomment-899281546
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/5747 Author: elkoniu Title: #5747: general: Fix compilation warnings Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5747/head:pr5747 git checkout pr5747
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
elkoniu commented: """ @ikerexxe thank you for the review, please take a look if current version is more meaningful. """
See the full comment at https://github.com/SSSD/sssd/pull/5747#issuecomment-899337945
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
ikerexxe commented: """ Thank you! Not everything LGTM. """
See the full comment at https://github.com/SSSD/sssd/pull/5747#issuecomment-899343773
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
ikerexxe commented: """ Thank you! Now everything LGTM. """
See the full comment at https://github.com/SSSD/sssd/pull/5747#issuecomment-899343773
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5747
* `master` * c1dd121142fb22648793a38e45257b348d658460 - general: Fix compilation warnings
"""
See the full comment at https://github.com/SSSD/sssd/pull/5747#issuecomment-899563096
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5747 Title: #5747: general: Fix compilation warnings
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5747 Author: elkoniu Title: #5747: general: Fix compilation warnings Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5747/head:pr5747 git checkout pr5747
sssd-devel@lists.fedorahosted.org
-
elkoniu -
ikerexxe
-
pbrezina