[PATCH] AD: Continue if sssd failes to check extra members

[Lukas Slebodnik]

ehlo,

Warning reported by scan-build

for (mi = 0; group_only[mi]; mi++) {
                 ^~~~~~~~~~
warning: Array access (from variable 'group_only') results in a null pointer
dereference

It can happend if function ad_group_extra_members fails (ret != EOK)

Patch is attched.

LS

[Lukas Slebodnik]

On (12/03/14 17:51), Lukas Slebodnik wrote:
> ehlo,
>
> Warning reported by scan-build
>
> for (mi = 0; group_only[mi]; mi++) {
>                 ^~~~~~~~~~
> warning: Array access (from variable 'group_only') results in a null pointer
> dereference
>
> It can happend if function ad_group_extra_members fails (ret != EOK)
>
> Patch is attched.

^^^^^^^
There was a type :-)

LS

[Simo Sorce]

On Wed, 2014-03-12 at 17:56 +0100, Lukas Slebodnik wrote:
> On (12/03/14 17:51), Lukas Slebodnik wrote:
> > ehlo,
> >
> > Warning reported by scan-build
> >
> > for (mi = 0; group_only[mi]; mi++) {
> >                 ^~~~~~~~~~
> > warning: Array access (from variable 'group_only') results in a null pointer
> > dereference
> >
> > It can happend if function ad_group_extra_members fails (ret != EOK)
> >
> > Patch is attched.
>       ^^^^^^^
>
> There was a type :-)

A typo in 'typo' ? :-)

ACK to the patch.

Simo.

[Jakub Hrozek]

On Wed, Mar 12, 2014 at 02:42:36PM -0400, Simo Sorce wrote:
> On Wed, 2014-03-12 at 17:56 +0100, Lukas Slebodnik wrote:
> > On (12/03/14 17:51), Lukas Slebodnik wrote:
> > > ehlo,
> > >
> > > Warning reported by scan-build
> > >
> > > for (mi = 0; group_only[mi]; mi++) {
> > >                 ^~~~~~~~~~
> > > warning: Array access (from variable 'group_only') results in a null pointer
> > > dereference
> > >
> > > It can happend if function ad_group_extra_members fails (ret != EOK)
> > >
> > > Patch is attched.
> >       ^^^^^^^
> >
> > There was a type :-)
>
> A typo in 'typo' ? :-)
>
> ACK to the patch.
>
> Simo.

Thanks for the review, pushed to master and sssd-1-11