[sssd PR#360][opened] TESTS: Relax the assert in test_idle_timeout

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/360
Author: jhrozek
 Title: #360: TESTS: Relax the assert in test_idle_timeout
Action: opened

PR body:
"""
Resolves:
   https://pagure.io/SSSD/sssd/issue/3473

We're being quite strict in test_idle_timeout when checking for the number
of open fds which leads to spurious failures like:
=================================== FAILURES ===================================
______________________________ test_idle_timeout _______________________________
Traceback (most recent call last):
 File
"/var/lib/jenkins/workspace/ci/label/fedora23/src/tests/intg/test_secrets.py",
line 427, in test_idle_timeout
   assert nfds_pre + 1 == nfds_conn AssertionError: assert (27 + 1) == 27
==================== 1 failed, 221 passed in 473.37 seconds ====================
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/360/head:pr360
git checkout pr360

[sssd PR#360][comment] TESTS: Relax the assert in test_idle_timeout

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

fidencio commented:
"""
ACK!
"""

See the full comment at https://github.com/SSSD/sssd/pull/360#issuecomment-325628617

[sssd PR#360][+Accepted] TESTS: Relax the assert in test_idle_timeout

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

Label: +Accepted

[sssd PR#360][comment] TESTS: Relax the assert in test_idle_timeout

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

lslebodn commented:
"""
IIRC there was a plan to update error reporting. Because following error is not very
useful for troubleshooting:
`AssertionError: assert (27 + 1) == 27`
"""

See the full comment at https://github.com/SSSD/sssd/pull/360#issuecomment-325781346

[sssd PR#360][-Accepted] TESTS: Relax the assert in test_idle_timeout

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

Label: -Accepted

[sssd PR#360][+Changes requested] TESTS: Relax the assert in test_idle_timeout

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

Label: +Changes requested

[sssd PR#360][synchronized] TESTS: Relax the assert in test_idle_timeout

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/360
Author: jhrozek
 Title: #360: TESTS: Relax the assert in test_idle_timeout
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/360/head:pr360
git checkout pr360

[sssd PR#360][-Changes requested] TESTS: Relax the assert in test_idle_timeout

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

Label: -Changes requested

[sssd PR#360][comment] TESTS: Relax the assert in test_idle_timeout

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

jhrozek commented:
"""
OK, see new patches
"""

See the full comment at https://github.com/SSSD/sssd/pull/360#issuecomment-326098584

[sssd PR#360][comment] TESTS: Relax the assert in test_idle_timeout

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

fidencio commented:
"""
You have an ACK from me!

@lslebodn, is the error message okay for you?
"""

See the full comment at https://github.com/SSSD/sssd/pull/360#issuecomment-326513860

[sssd PR#360][+Accepted] TESTS: Relax the assert in test_idle_timeout

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

Label: +Accepted

[sssd PR#360][comment] TESTS: Relax the assert in test_idle_timeout

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

jhrozek commented:
"""
* master: 4d1e380fea70e917cdfba560b899cca2f3e2ffd1
"""

See the full comment at https://github.com/SSSD/sssd/pull/360#issuecomment-326977647

[sssd PR#360][closed] TESTS: Relax the assert in test_idle_timeout

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/360
Author: jhrozek
 Title: #360: TESTS: Relax the assert in test_idle_timeout
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/360/head:pr360
git checkout pr360

[sssd PR#360][+Pushed] TESTS: Relax the assert in test_idle_timeout

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/360
Title: #360: TESTS: Relax the assert in test_idle_timeout

Label: +Pushed