[sssd PR#410][opened] IPA: sanitize name in override search filter

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/410
Author: lslebodn
 Title: #410: IPA: sanitize name in override search filter
Action: opened

PR body:
"""
Resolves:
https://pagure.io/SSSD/sssd/issue/3545
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/410/head:pr410
git checkout pr410

[sssd PR#410][+Changes requested] IPA: sanitize name in override search filter

[fidencio]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter

Label: +Changes requested

[sssd PR#410][synchronized] IPA: sanitize name in override search filter

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/410
Author: lslebodn
 Title: #410: IPA: sanitize name in override search filter
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/410/head:pr410
git checkout pr410

[sssd PR#410][synchronized] IPA: sanitize name in override search filter

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/410
Author: lslebodn
 Title: #410: IPA: sanitize name in override search filter
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/410/head:pr410
git checkout pr410

[sssd PR#410][-Changes requested] IPA: sanitize name in override search filter

[fidencio]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter

Label: -Changes requested

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

lslebodn commented:
"""
Bump after 6 weeks.
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347490896

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

fidencio commented:
"""
Patch looks okay, but I didn't have time to test it on el6.
Am I safe to assume that you did? Otherwise it'll be postponed as there are things with higher prio in my list (or someone else can take it over and actually do the tests).
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347502024

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

fidencio commented:
"""
Just for the record, I've talked to @lslebodn on IRC and I'll get to this PR later Today.
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347504623

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

fidencio commented:
"""
I've tried to reproduce the very same issue using sssd-1.13.3-57.el6_9 and I simply can't. May it be related to the ipa version?

I'll give it another try using an el7 system with 1.13 branch installed.
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347840457

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

fidencio commented:
"""
One thing that I have notice (with or without the patch) is that `getent group [e-mail]`, [e-mail] being an AD group from the trusted domain doesn't return me any results. I only can get some results after an `id any_user_who_s_part_of_foo_ad_ff_group`.

I guess this is not expected at all, or am I mistaken?
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-347841071

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

lslebodn commented:
"""
On (29/11/17 12:03), fidencio wrote:
> I've tried to reproduce the very same issue using sssd-1.13.3-57.el6_9 and I simply can't. May it be related to the ipa version?

Maybe, I do not know whether you used the same of IPA server for testing
master and 1.13 but version of ipa-client should not have anything with this
bug.

"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-348519835

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[lslebodn]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

lslebodn commented:
"""
On (29/11/17 12:06), fidencio wrote:
> One thing that I have notice (with or without the patch) is that `getent group [e-mail]`, [e-mail] being an AD group from the trusted domain doesn't return me any results. I only can get some results after an `id any_user_who_s_part_of_foo_ad_ff_group`.
>
> I guess this is not expected at all, or am I mistaken?

Does it behave the same with sssd-1.15/-1.16?

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-348520126

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[fidencio]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

fidencio commented:
"""
> Maybe, I do not know whether you used the same of IPA server for testing
> master and 1.13 but version of ipa-client should not have anything with this
> bug.

Yep, I've used the very same ipa server.
> Does it behave the same with sssd-1.15/-1.16?

And no, I couldn't notice the very same behave on 1.15/1.16.

As this PR does not have high prio (or higher prio) than a few other work that I have on my back, I'll visit it back in a few days/week. As said before, anyone else can review this and mainly **test** this patch/behaviour in order to not leave it blocked in case a few days/weeks is not acceptable.
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-348883656

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

sumit-bose commented:
"""
Hi Lukas,

I think you backported the changes to the wrong function. In 1.13 in ipa_get_ad_override_connect_done() be_acct_req_to_override_filter() is called to create the filter for the override search and not get_be_acct_req_for_xyz().

be_acct_req_to_override_filter() was renamed to dp_id_data_to_override_filter() by 3d29430867cf92b2d71afa95abb679711231117c that's why the patch for master (c2dec0dc740ba426f26563563c0aea3a38f3c3c1) adds the sanitation to this function.

HTH

bye,
Sumit
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-359458111

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

jhrozek commented:
"""
I haven't looked at the code at all, but judging by the previous message, the state of this PR should be "Changes Requested".
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-367666723

[sssd PR#410][+Changes requested] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[sumit-bose]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

Label: +Changes requested

[sssd PR#410][comment] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13

jhrozek commented:
"""
Since I don't think this PR will get any updates now, we should just close it.

If anyone (probably a user or a maintainer of a stable distribution) will like to see this patch backported, please do submit a PR.
"""

See the full comment at https://github.com/SSSD/sssd/pull/410#issuecomment-390784545

[sssd PR#410][closed] IPA: sanitize name in override search filter - Backport to SSSD-1.13

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/410
Author: lslebodn
 Title: #410: IPA: sanitize name in override search filter - Backport to SSSD-1.13
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/410/head:pr410
git checkout pr410