[PATCH] GPO: error out instead of leaving array element uninitialized

[Sumit Bose]

Hi,

this patch should fix a segfault which was recently found in the GPO
code.

bye,
Sumit

[Jakub Hrozek]

On Fri, Mar 20, 2015 at 06:47:09PM +0100, Sumit Bose wrote:
> Hi,
>
> this patch should fix a segfault which was recently found in the GPO
> code.
>
> bye,
> Sumit

Based on the discussion we had in the bug (sorry, private comments because
they contained data from the deployment) I know this will fix the segfault,
so ACK.

Do you also plan on checking why there was an entry without SYSDB_SID_STR
or shall I open another ticket?

[Sumit Bose]

On Fri, Mar 20, 2015 at 06:52:17PM +0100, Jakub Hrozek wrote:
> On Fri, Mar 20, 2015 at 06:47:09PM +0100, Sumit Bose wrote:
> > Hi,
> >
> > this patch should fix a segfault which was recently found in the GPO
> > code.
> >
> > bye,
> > Sumit
>
> Based on the discussion we had in the bug (sorry, private comments because
> they contained data from the deployment) I know this will fix the segfault,
> so ACK.
>
> Do you also plan on checking why there was an entry without SYSDB_SID_STR
> or shall I open another ticket?

Currently I have no idea how this can happen, maybe the debug message in
the patch will help to track it down.

bye,
Sumit
> sssd-devel mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[Jakub Hrozek]

On Fri, Mar 20, 2015 at 07:48:34PM +0100, Sumit Bose wrote:
> On Fri, Mar 20, 2015 at 06:52:17PM +0100, Jakub Hrozek wrote:
> > On Fri, Mar 20, 2015 at 06:47:09PM +0100, Sumit Bose wrote:
> > > Hi,
> > >
> > > this patch should fix a segfault which was recently found in the GPO
> > > code.
> > >
> > > bye,
> > > Sumit
> >
> > Based on the discussion we had in the bug (sorry, private comments because
> > they contained data from the deployment) I know this will fix the segfault,
> > so ACK.
> >
> > Do you also plan on checking why there was an entry without SYSDB_SID_STR
> > or shall I open another ticket?
>
> Currently I have no idea how this can happen, maybe the debug message in
> the patch will help to track it down.
>
> bye,
> Sumit

OK, I'll prepare a test build for the affected user.

Pushed to master: 4cfab2330323834574c179f774a0c6b1fff4936e
and sssd-1-12: 0d628f98500a0fd642ba0c720c40393460988f73