[sssd PR#680][opened] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Author: mrniranjan
 Title: #680: pytest: Add test case for Expired sudo rule
Action: opened

PR body:
"""

"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/680/head:pr680
git checkout pr680

[sssd PR#680][synchronized] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Author: mrniranjan
 Title: #680: pytest: Add test case for Expired sudo rule
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/680/head:pr680
git checkout pr680

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

jhrozek commented:
"""
btw did you manage to reproduce the bug with this test and the buggy sssd version? I reverted the patches that fix the sssd bug but the tests still passed..
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-431330397

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

mrniranjan commented:
"""
On the buggy version, i could see the sssd_sudo crashes. 
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-431362948

[sssd PR#680][synchronized] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Author: mrniranjan
 Title: #680: pytest: Add test case for Expired sudo rule
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/680/head:pr680
git checkout pr680

[sssd PR#680][synchronized] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Author: mrniranjan
 Title: #680: pytest: Add test case for Expired sudo rule
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/680/head:pr680
git checkout pr680

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

mrniranjan commented:
"""
I have fixed the issues raised in the review comments, but for some reason github is not updating the PR with latest commits. 
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-431748369

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

mrniranjan commented:
"""
I have fixed the issues raised in the review comments, but for some reason github is not updating the PR with latest commits. 
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-431748508

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

jhrozek commented:
"""
github has issues: https://status.github.com/messages
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-431769461

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[mrniranjan]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

mrniranjan commented:
"""
@jhrozek Can you review this ?
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-438595888

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

jhrozek commented:
"""
I'm sorry for the very long delay. Except for the extra import, I don't have any more comments. I'll leave it up to you whether you want to remove the import and resubmit or if you prefer I do it before pushing. Anyway, I'll push the patches later today to avoid blocking CI for development.
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-440947866

[sssd PR#680][comment] pytest: Add test case for Expired sudo rule

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

jhrozek commented:
"""
I fixed the unused import and pushed the patches to master:
5c550e72ea9939139d2e9b0b7e3c6a534568d799                                                                                                                                                                                                    
fa2106a7af9d70380c9694a1a15752f39531f6f0
a5133f3ab384c2e3f37081bb73fdf705edc45ee6
4dcef883255b25f3a38cd67bcef3a6d3eb7d1c26
ba87d78343a42e716a2ea32890b16f33c62002a2
6dcc34d09e0f583743dc4a74076eb30e505deed1
"""

See the full comment at https://github.com/SSSD/sssd/pull/680#issuecomment-441123603

[sssd PR#680][closed] pytest: Add test case for Expired sudo rule

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/680
Author: mrniranjan
 Title: #680: pytest: Add test case for Expired sudo rule
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/680/head:pr680
git checkout pr680

[sssd PR#680][+Accepted] pytest: Add test case for Expired sudo rule

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

Label: +Accepted

[sssd PR#680][+Pushed] pytest: Add test case for Expired sudo rule

[jhrozek]

URL: https://github.com/SSSD/sssd/pull/680
Title: #680: pytest: Add test case for Expired sudo rule

Label: +Pushed